From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE3BFC433EF for ; Wed, 6 Jul 2022 18:50:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 071706B0072; Wed, 6 Jul 2022 14:50:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3BB16B0073; Wed, 6 Jul 2022 14:50:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDC636B0074; Wed, 6 Jul 2022 14:50:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C92056B0072 for ; Wed, 6 Jul 2022 14:50:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A13C0EC0 for ; Wed, 6 Jul 2022 18:50:37 +0000 (UTC) X-FDA: 79657566114.23.A0A7486 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf04.hostedemail.com (Postfix) with ESMTP id 140B94000D for ; Wed, 6 Jul 2022 18:50:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 20CE0CE21E4; Wed, 6 Jul 2022 18:50:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C2EFC341C8; Wed, 6 Jul 2022 18:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657133432; bh=F0/XVKDg3YIqGzbpwY8z/7I/yJ1VvZPV4zJoaMEXJZk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dL7SYbgE8qHk3Il2TkQbLtQ2BF9Tkfy7gnziK5j4rWO1QLPZdvwaVcHl6qVpsOGRo m1LXPIUwMRYr3WFU/Pm9W8idoEAa+EZn0nonlho2ljY5HyF1R2RgnpPe5izc/+zA/x 3+rPQSyAKABfLW2UFY2RJ016Wc0/+XrzU7B9pTCE= Date: Wed, 6 Jul 2022 11:50:31 -0700 From: Andrew Morton To: Nico Pache Cc: Joel Savitz , LKML , Shuah Khan , Linux MM , linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests/vm: enable running select groups of tests Message-Id: <20220706115031.3c312d9268bf87287be0b8f9@linux-foundation.org> In-Reply-To: References: <20220705185605.3889110-1-jsavitz@redhat.com> <20220705133456.d5572b2e36ebb36188369988@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657133437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gJsENqge9qU8JvkY7Xz2zFxXzM/SWAid0XvdRKNOVy8=; b=okNKGd1ikuy0UL7B5ukD56zWCbhrEEerYW4rbK8OgMr9s/egcB2Z7bUEHysrCGG2Rs5CB7 qbApkLoA7Kbw4lX4Rkc3DUVUwl1SlcPLFf5fc4sRpPH13URF1GCglS908OrUiutJV2V62A oIsIJ/g6NzQGoEYItR0K6Mu0Pvq/r6o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657133437; a=rsa-sha256; cv=none; b=UIE8Oe6FNoYbk7hrsdyRtVfEZCLk1OTkhS3kOVH0sKFNDMgpDchvXV1SeVXQ1GB8znYvVM wooeX8s59aGN/L/yq43QyeYPRQRTCr0mUnevSOZbdNC8/uz1lWIkvZlxQwXcUY1gQ2R0Es zn9ttljY4k+963dfh5pq8OUw7fl/nxM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dL7SYbgE; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: e5b3oufpckn6oxkaui75amrimgzz1nro X-Rspamd-Queue-Id: 140B94000D X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=dL7SYbgE; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam10 X-HE-Tag: 1657133436-321072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 6 Jul 2022 14:38:03 -0400 Nico Pache wrote: > On Tue, Jul 5, 2022 at 4:35 PM Andrew Morton wrote: > > > > On Tue, 5 Jul 2022 14:56:05 -0400 Joel Savitz wrote: > > > > > Add the ability to run one or more groups of vm tests (specified > > > by the environment variable TEST_ITEMS). Preserve existing default > > > behavior of running all tests when TEST_ITEMS is empty or "default". > > > Hi Andrew, > > > What is the reason for this? What's the use case? > > The current design of vm selftests is all-or-none. We'd like to be > able to selectively run these tests (We settled for selective groups > of tests rather than individual tests). > > The main reason for doing this is our efforts to expand RedHats MM CI > testing. There are two use cases for these changes that relate to our > reasoning: > 1) Our current CI has overlapping tests between LTP and vm selftests, > so we'd like a way to prevent running the same test in two places. > 2) We'd like the ability to skip a test if it is determined to be > unstable or requires certain hardware requirements. > > By adding this functionality we are really expanding what we are able > to do with the stock vm-selftests. OK, please let's get this info into the changelog - it's the most important part. > > And why via the environment rather than via commandline args? > Just a design choice I suppose. I'm sure Joel would be willing to > implement it as a cmdline arg if you'd prefer that approach. I think that would be best.