From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 051A2C43334 for ; Mon, 4 Jul 2022 09:46:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 706F46B0072; Mon, 4 Jul 2022 05:46:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B5806B0073; Mon, 4 Jul 2022 05:46:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57DA76B0074; Mon, 4 Jul 2022 05:46:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 461DB6B0072 for ; Mon, 4 Jul 2022 05:46:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC14C3C0DB for ; Mon, 4 Jul 2022 09:43:47 +0000 (UTC) X-FDA: 79648930494.02.93A7FEB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id D79E3160562 for ; Mon, 4 Jul 2022 09:27:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DAC1E613FB; Mon, 4 Jul 2022 09:27:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9AECC3411E; Mon, 4 Jul 2022 09:27:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656926826; bh=hH3spFHQdwa+gBgAQj1zYN9yiX7A+GyWbQNkSUNtmqE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tPgH5MviYy9ljQGlgk2YGIiFgQ8NkEu/yXE76JqtS8NDw6dJRXw0NALaVYioW0QRv sO7GRsJSFEvCL37fwZTrUV1KRtLzjUd1qcAjSbNHezIvUyPFhpNOdR7R65xhA1Bzna xdh4ctJKv6zSFXk1dw18xyL9kStkntDYzzEnIPp/Gw4DO5bMUPhipv3D099StIfaYg op2O9GNXgwghxWt0W6k1nPUVzGeYaifFqQdn7NcCRy5D7iijvfoOasn133QL4+KyD7 qdeWKZuMu8Hl5DMVRekLenYO0rMF8Cmq8lY0fT/jDIcYYM8DJiIfO1RJD7jq2fzpI6 aGn3RxHukrnKg== Date: Mon, 4 Jul 2022 10:26:58 +0100 From: Will Deacon To: Huacai Chen Cc: Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , loongarch@lists.linux.dev, linux-arch@vger.kernel.org, Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , linux-mm@kvack.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Feiyang Chen Subject: Re: [PATCH V3 3/4] mm/sparse-vmemmap: Generalise vmemmap_populate_hugepages() Message-ID: <20220704092658.GA31220@willie-the-truck> References: <20220702080021.1167190-1-chenhuacai@loongson.cn> <20220702080021.1167190-4-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220702080021.1167190-4-chenhuacai@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656926829; a=rsa-sha256; cv=none; b=lxcWEhqQ0r5J7jUTMU6xfKBYXGGCowIjPvjbXWO4cCwICGpMEytYOkWhm9MOu27/XBVYZu XAJ4j+W79l2zIfnRLGQX2YIideKwDRVwaeoICLvzcy6Ub1PvxYuTB9Q53K+RMwjeiO3VXg gOY5kgyGduB0V02TIK5QH9PJ4sWgtqo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tPgH5Mvi; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656926829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=su/qiV0/gOnZqwxpGnPDGdT+IiavqxstQhE22A3uoM0=; b=PnBzs2NddA9ZGamu074m4kG0Vlvq8cwU+lnTZ+25c0m2U0PfG0dlptXOXjWPlWuqmEt7fl STxw4qkRAxcgwDkDKdhhpbOVVwVG/zp7QKAhLTNN0mrnw8GAOSvizkNu+GgrfZj11VV2nK paS5zkcPpUyEh7F4O1zg+yDLLs3/Uf4= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tPgH5Mvi; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D79E3160562 X-Rspam-User: X-Stat-Signature: ixj4aqc3fgqcokgbns9jz9cixrz1p1ro X-HE-Tag: 1656926828-27571 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 02, 2022 at 04:00:20PM +0800, Huacai Chen wrote: > From: Feiyang Chen > > Generalise vmemmap_populate_hugepages() so ARM64 & X86 & LoongArch can > share its implementation. > > Signed-off-by: Feiyang Chen > Signed-off-by: Huacai Chen > --- > arch/arm64/mm/mmu.c | 53 ++++++----------------- > arch/loongarch/mm/init.c | 63 ++++++++------------------- > arch/x86/mm/init_64.c | 92 ++++++++++++++-------------------------- > include/linux/mm.h | 6 +++ > mm/sparse-vmemmap.c | 54 +++++++++++++++++++++++ > 5 files changed, 124 insertions(+), 144 deletions(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index 626ec32873c6..b080a65c719d 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1158,49 +1158,24 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, > return vmemmap_populate_basepages(start, end, node, altmap); > } > #else /* !ARM64_KERNEL_USES_PMD_MAPS */ > +void __meminit vmemmap_set_pmd(pmd_t *pmd, void *p, int node, > + unsigned long addr, unsigned long next) > +{ > + pmd_set_huge(pmd, __pa(p), __pgprot(PROT_SECT_NORMAL)); > +} > + > +int __meminit vmemmap_check_pmd(pmd_t *pmd, int node, unsigned long addr, > + unsigned long next) > +{ > + vmemmap_verify((pte_t *)pmd, node, addr, next); > + return 1; > +} nit, but please can you use 'pmdp' instead of 'pmd' for the pointers? We're pretty consistent elsewhere for arch/arm64 and it makes the READ_ONCE() usage easier to follow once functions end up loading the entry. Thanks, Will