From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63726C433EF for ; Mon, 4 Jul 2022 01:43:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2D6C6B0072; Sun, 3 Jul 2022 21:43:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDD606B0073; Sun, 3 Jul 2022 21:43:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC198E0001; Sun, 3 Jul 2022 21:43:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AE0B46B0072 for ; Sun, 3 Jul 2022 21:43:02 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6EDBB8166A for ; Mon, 4 Jul 2022 01:43:02 +0000 (UTC) X-FDA: 79647719004.31.D4D0BE9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id DAC511A0055 for ; Mon, 4 Jul 2022 01:43:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E808361356; Mon, 4 Jul 2022 01:43:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8FC9C341C6; Mon, 4 Jul 2022 01:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656898980; bh=/LMQ8BboRFFus9I/l+fXn306egan/qVJVZnhwpwGzBw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QYjD4qaV1QJKWOycKvk8iwmzRD8fmoKoPmYJtUEuuPU6jL+YskiZxAQepyT47cyZt XGe+2xlP/tORKOZPfqfARmSU0oI923n/NM1ZghDyo1yDT3x/bfP7UnJFJPg/iG0YcS Adm05c6sOnFb+/uRhYOJ4aLgv+8NgxsnCqMVzBCE= Date: Sun, 3 Jul 2022 18:42:59 -0700 From: Andrew Morton To: Naoya Horiguchi Cc: linux-mm@kvack.org, David Hildenbrand , Mike Kravetz , Miaohe Lin , Liu Shixin , Yang Shi , Oscar Salvador , Muchun Song , Naoya Horiguchi , linux-kernel@vger.kernel.org Subject: Re: [mm-unstable PATCH v4 2/9] mm/hugetlb: separate path for hwpoison entry in copy_hugetlb_page_range() Message-Id: <20220703184259.99a37313037000bd2e9ace9a@linux-foundation.org> In-Reply-To: <20220704013312.2415700-3-naoya.horiguchi@linux.dev> References: <20220704013312.2415700-1-naoya.horiguchi@linux.dev> <20220704013312.2415700-3-naoya.horiguchi@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656898982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JfkJEj/WqT1F2otXKjUQAyvU6CkkQ7nUdG/hu5jciW4=; b=svuneb8LCTi3T4UoofF66jmPlAUroWYn7wYZrSMjNWypABMgL75pj1uvHHer9dwZuPpevq 9G1IRD8sLd1u+v1iJykFJK2UHtYht+Yx1a0YHp6j1LtApN5VnZJpmioxM+SoOWwGf8KbXD euwgO30j8QGQ14w80QQHa8lMd1YSU6k= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QYjD4qaV; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656898982; a=rsa-sha256; cv=none; b=wIT/q7yJFiWnCqk2SOIfFTfTv0PqbS/U0CGgIyNUTM/+MUwBzf2TDi0d4UqnJ55LE52Hvo aorb0nJUGj2jC8Cyk5kCTa/zFkRCEtIhHIb0a2hZp2cu6zGhH+thGwrTXQvcbdA9DKD1Ty g+Y2EXbNi0RU4z5fgvUACnpVlkR2Z9U= X-Stat-Signature: 3w3qsghgjhf5p4oxx9n9sjw6eajigifx X-Rspamd-Queue-Id: DAC511A0055 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=QYjD4qaV; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1656898981-799735 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 4 Jul 2022 10:33:05 +0900 Naoya Horiguchi wrote: > Originally copy_hugetlb_page_range() handles migration entries and hwpoisoned > entries in similar manner. But recently the related code path has more code > for migration entries, and when is_writable_migration_entry() was converted > to !is_readable_migration_entry(), hwpoison entries on source processes got > to be unexpectedly updated (which is legitimate for migration entries, but > not for hwpoison entries). This results in unexpected serious issues like > kernel panic when forking processes with hwpoison entries in pmd. > > Separate the if branch into one for hwpoison entries and one for migration > entries. > > ... > > Cc: # 5.18 It's unusual to have a cc:stable patch in the middle of a series like this. One would expect the fix to be a standalone thing against current -linus. As presented, this patch won't get into mainline until after 5.20-rc1. If that's OK then OK. Otherwise I can shuffle things around and stage this patch in mm-hotfixes?