From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFCD6C43334 for ; Sun, 3 Jul 2022 23:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 443B86B0072; Sun, 3 Jul 2022 19:14:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CCB96B0073; Sun, 3 Jul 2022 19:14:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26CA38E0001; Sun, 3 Jul 2022 19:14:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 14B1E6B0072 for ; Sun, 3 Jul 2022 19:14:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DF3B761855 for ; Sun, 3 Jul 2022 23:14:25 +0000 (UTC) X-FDA: 79647344490.19.8664F00 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf31.hostedemail.com (Postfix) with ESMTP id 7A5AA2000D for ; Sun, 3 Jul 2022 23:14:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83C2961237; Sun, 3 Jul 2022 23:14:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E006C341C6; Sun, 3 Jul 2022 23:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656890063; bh=eraPqmwROOb16b2jw4w/lY5LSrsNKAf5gsz/yzIab8s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=00wNNTZxm5k38yElTqGTrmvzRw8kLFqJOvQNb0pINHpqZUz3XC1uBlfeDyPfed3pw J792ub8Tx5cnrQ2kh2UH9cLFNPndI8ZbNx4s3D0neHF7SVB9imOHoSOD7MdU4sNkk6 GrarUUdH0nG4C43R0bhMcRNp3CbR+F/XAp6TT1ds= Date: Sun, 3 Jul 2022 16:14:22 -0700 From: Andrew Morton To: Yang Shi Cc: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, zokeefe@google.com, linmiaohe@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [mm-unstable v5 PATCH 0/7] Cleanup transhuge_xxx helpers Message-Id: <20220703161422.71e0c7316cca0442c682fcaf@linux-foundation.org> In-Reply-To: <20220616174840.1202070-1-shy828301@gmail.com> References: <20220616174840.1202070-1-shy828301@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656890065; a=rsa-sha256; cv=none; b=aTaPQrkWF2WCsyABuVI8amAGotf3qPyeiHPNxzux6LoCaz6uOgzb0IPcIw7kkZSHvNb0L0 aH918lFM4+GsUc3ob3a2bNleGgXv6WDti0DYwQHrchWdg5XMwweHNM7cz23MGUUxRQVrXU 3+9KR95PSO218Z3GTyd9Bv56rWSMD4c= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=00wNNTZx; dmarc=none; spf=pass (imf31.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656890065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jM3TGPtxJkgmTFpBCG9ciqLYWyWJgBvv60WOzB8Av8A=; b=637r0HQm6vdCuYW3kFMrflXw4omhDY/4rB02J5w+Jj2iDmzQvoJU8Ai1AkUSDPxlCn7hua EcnYxbT/YK7NDqKRZEAlDzFD8+OYmOCmwJ+tznkxLZOJXbwkoFRNDpr9Bxky7xeQ5Yw2O3 ItvqEVJ9P4b6QXJm2NfSrim8LmuKC84= X-Rspamd-Queue-Id: 7A5AA2000D X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=00wNNTZx; dmarc=none; spf=pass (imf31.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam02 X-Stat-Signature: i9tss3ykzc9rjoitkoyukkur5x7a5d6b X-HE-Tag: 1656890065-608396 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Jun 2022 10:48:33 -0700 Yang Shi wrote: > This series is the follow-up of the discussion about cleaning up transhuge_xxx > helpers at https://lore.kernel.org/linux-mm/627a71f8-e879-69a5-ceb3-fc8d29d2f7f1@suse.cz/. > > THP has a bunch of helpers that do VMA sanity check for different paths, they > do the similar checks for the most callsites and have a lot duplicate codes. > And it is confusing what helpers should be used at what conditions. > > This series reorganized and cleaned up the code so that we could consolidate > all the checks into hugepage_vma_check(). > > The transhuge_vma_enabled(), transparent_hugepage_active() and > __transparent_hugepage_enabled() are killed by this series. I plan to move this into mm-stable later this week, along with two fixups: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix.patch https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix-fix.patch