From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9129ECCA473 for ; Sun, 3 Jul 2022 10:44:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2C556B0072; Sun, 3 Jul 2022 06:44:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDBDC6B0073; Sun, 3 Jul 2022 06:44:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA7E56B0074; Sun, 3 Jul 2022 06:44:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9BF356B0072 for ; Sun, 3 Jul 2022 06:44:02 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6A3AD81096 for ; Sun, 3 Jul 2022 10:44:02 +0000 (UTC) X-FDA: 79645453524.25.45A0145 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf26.hostedemail.com (Postfix) with ESMTP id 3D8A5140027 for ; Sun, 3 Jul 2022 10:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656845041; x=1688381041; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=vTTAw9QKNXkaEQrbW3B9/sW65KKD9yPkaMxgTxRHzfs=; b=UlrVG0Ew/62yTcM2n02+ZXocm0Us1t+PVi7aXvjyfzFAUzqwd/sgONuc QNDAQTXGtOiqNxRBHa28hRD890mC8RGOdOtB2u8aL/hrhRmwiaa73Ago7 6FdSy/XZ1gqBT/Ytgh4UtLYcT/Woo3QhHMeDz9ztLXI22j0XSH0BBCfNc GIxWUgmODvF9qrVssHJ5k8THnSk1pRjn+377B6P32lf2LSXP2xeWTfdh/ GyDLj4gJEjQW+C6Ya58hq80AgTVxvvisvt8ApYmcp4JEH0GdJljQ8N8MV LnLCNaP1U7YKj+bK4x/jEkxcghJsoSJR9Clq/J30ZyTSxe8PkuFR5dY75 Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10396"; a="281693799" X-IronPort-AV: E=Sophos;i="5.92,241,1650956400"; d="scan'208";a="281693799" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2022 03:43:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,241,1650956400"; d="scan'208";a="618916129" Received: from shbuild999.sh.intel.com (HELO localhost) ([10.239.146.138]) by orsmga008.jf.intel.com with ESMTP; 03 Jul 2022 03:43:53 -0700 Date: Sun, 3 Jul 2022 18:43:53 +0800 From: Feng Tang To: Shakeel Butt Cc: Eric Dumazet , Linux MM , Andrew Morton , Roman Gushchin , Michal Hocko , Johannes Weiner , Muchun Song , Jakub Kicinski , Xin Long , Marcelo Ricardo Leitner , kernel test robot , Soheil Hassas Yeganeh , LKML , network dev , linux-s390@vger.kernel.org, MPTCP Upstream , "linux-sctp @ vger . kernel . org" , lkp@lists.01.org, kbuild test robot , Huang Ying , Xing Zhengjun , Yin Fengwei , Ying Xu Subject: Re: [net] 4890b686f4: netperf.Throughput_Mbps -69.4% regression Message-ID: <20220703104353.GB62281@shbuild999.sh.intel.com> References: <20220624144358.lqt2ffjdry6p5u4d@google.com> <20220625023642.GA40868@shbuild999.sh.intel.com> <20220627023812.GA29314@shbuild999.sh.intel.com> <20220627123415.GA32052@shbuild999.sh.intel.com> <20220627144822.GA20878@shbuild999.sh.intel.com> <20220628034926.GA69004@shbuild999.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656845042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FOzmge2yZjitb2nq17R8iZzyXQi6COJ05mxwUBsT+xw=; b=W7gt3JVxjTBoo0tJZHQLs6EnBbVnF3g55adSLq2MeguDn1rjWw4khRsYbCL5wmrIDuRlte IN8cxutnCtd5fOpLF80QT7LUTWc+fo4kzdOadxnEQdeUAfJOZdS7BnIyO+PKQ2be1lr5rH 58oc0ddZjDHHMvqteG6a4tiK5SZLgO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656845042; a=rsa-sha256; cv=none; b=fgz7zBzYKObB2jyg/zbfxHf4ULR1ArIgsFqJ/mFYNnkkWCez/28INoefBGaxAcddqpwMXb 3PCKGFF82cqC2nfOuWSYdEbqXU3kde3yhTAWDMcKlx2igsQL4z33cSA/JHMIgOJ1xJf45s J/nhQ4mtY+6x63SDmyBREUe7z0+GVbE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UlrVG0Ew; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf26.hostedemail.com: domain of feng.tang@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=feng.tang@intel.com X-Stat-Signature: jwmh3hxg31saniyhnafhar7zymi1nsjb X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UlrVG0Ew; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf26.hostedemail.com: domain of feng.tang@intel.com has no SPF policy when checking 192.55.52.120) smtp.mailfrom=feng.tang@intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3D8A5140027 X-HE-Tag: 1656845040-665873 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Shakeel, On Fri, Jul 01, 2022 at 08:47:29AM -0700, Shakeel Butt wrote: > On Mon, Jun 27, 2022 at 8:49 PM Feng Tang wrote: > > I just tested it, it does perform better (the 4th is with your patch), > > some perf-profile data is also listed. > > > > 7c80b038d23e1f4c 4890b686f4088c90432149bd6de 332b589c49656a45881bca4ecc0 e719635902654380b23ffce908d > > ---------------- --------------------------- --------------------------- --------------------------- > > 15722 -69.5% 4792 -40.8% 9300 -27.9% 11341 netperf.Throughput_Mbps > > > > 0.00 +0.3 0.26 ± 5% +0.5 0.51 +1.3 1.27 ± 2%pp.self.__sk_mem_raise_allocated > > 0.00 +0.3 0.32 ± 15% +1.7 1.74 ± 2% +0.4 0.40 ± 2% pp.self.propagate_protected_usage > > 0.00 +0.8 0.82 ± 7% +0.9 0.90 +0.8 0.84 pp.self.__mod_memcg_state > > 0.00 +1.2 1.24 ± 4% +1.0 1.01 +1.4 1.44 pp.self.try_charge_memcg > > 0.00 +2.1 2.06 +2.1 2.13 +2.1 2.11 pp.self.page_counter_uncharge > > 0.00 +2.1 2.14 ± 4% +2.7 2.71 +2.6 2.60 ± 2% pp.self.page_counter_try_charge > > 1.12 ± 4% +3.1 4.24 +1.1 2.22 +1.4 2.51 pp.self.native_queued_spin_lock_slowpath > > 0.28 ± 9% +3.8 4.06 ± 4% +0.2 0.48 +0.4 0.68 pp.self.sctp_eat_data > > 0.00 +8.2 8.23 +0.8 0.83 +1.3 1.26 pp.self.__sk_mem_reduce_allocated > > > > And the size of 'mem_cgroup' is increased from 4224 Bytes to 4608. > > Hi Feng, can you please try two more configurations? Take Eric's patch > of adding ____cacheline_aligned_in_smp in page_counter and for first > increase MEMCG_CHARGE_BATCH to 64 and for second increase it to 128. > Basically batch increases combined with Eric's patch. With increasing batch to 128, the regression could be reduced to -12.4%. Some more details with perf-profile data below: 7c80b038d23e1f4c 4890b686f4088c90432149bd6de Eric's patch Eric's patch + batch-64 Eric's patch + batch-128 ---------------- --------------------------- --------------------------- --------------------------- --------------------------- 15722 -69.5% 4792 -27.9% 11341 -14.0% 13521 -12.4% 13772 netperf.Throughput_Mbps 0.05 +0.2 0.27 ± 18% +0.0 0.08 ± 6% -0.1 0.00 -0.0 0.03 ±100% pp.self.timekeeping_max_deferment 0.00 +0.3 0.26 ± 5% +1.3 1.27 ± 2% +1.8 1.82 ± 10% +2.0 1.96 ± 9% pp.self.__sk_mem_raise_allocated 0.00 +0.3 0.32 ± 15% +0.4 0.40 ± 2% +0.1 0.10 ± 5% +0.0 0.00 pp.self.propagate_protected_usage 0.00 +0.8 0.82 ± 7% +0.8 0.84 +0.5 0.48 +0.4 0.36 ± 2% pp.self.__mod_memcg_state 0.00 +1.2 1.24 ± 4% +1.4 1.44 +0.4 0.40 ± 3% +0.2 0.24 ± 6% pp.self.try_charge_memcg 0.00 +2.1 2.06 +2.1 2.11 +0.5 0.50 +0.2 0.18 ± 8% pp.self.page_counter_uncharge 0.00 +2.1 2.14 ± 4% +2.6 2.60 ± 2% +0.6 0.58 +0.2 0.20 pp.self.page_counter_try_charge 1.12 ± 4% +3.1 4.24 +1.4 2.51 +1.0 2.10 ± 2% +1.0 2.10 ± 9% pp.self.native_queued_spin_lock_slowpath 0.28 ± 9% +3.8 4.06 ± 4% +0.4 0.68 +0.6 0.90 ± 9% +0.7 1.00 ± 11% pp.self.sctp_eat_data 0.00 +8.2 8.23 +1.3 1.26 +1.7 1.72 ± 6% +2.0 1.95 ± 10% pp.self.__sk_mem_reduce_allocated Thanks, Feng