From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B76A5C43334 for ; Fri, 1 Jul 2022 16:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 237BE6B0071; Fri, 1 Jul 2022 12:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E7D16B0073; Fri, 1 Jul 2022 12:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AFD86B0074; Fri, 1 Jul 2022 12:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EC0216B0071 for ; Fri, 1 Jul 2022 12:41:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C594480276 for ; Fri, 1 Jul 2022 16:41:13 +0000 (UTC) X-FDA: 79639096026.09.FBB76F5 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf07.hostedemail.com (Postfix) with ESMTP id 6293740062 for ; Fri, 1 Jul 2022 16:41:13 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id b133so2217295qkc.6 for ; Fri, 01 Jul 2022 09:41:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UIQhm0URAojUxcbwYfOFzbJ0pGM2Vdxb/C/kZcqe4VQ=; b=M96M9FGgN55/D7eZDhzRJ8+m7umZHg+I3CyG8VDpkhT6fE9wE7bUGdc/Fe6N//CK8J HTbUcbOBE/KMPR5hhAh9TqkIlMHp3ANGw5/N28+mOb6Qut9hzqfGB7tpxD5rmCgqxNvT 8o0F/s3pmNCM+1xhV6vIhH8TwtlqC9Yq+RvrkU2lBkdD6K6uxB9HvrT03ycV5efMNx3u bYoygND8XAUhdUHHd5EQXDY0O/zT3V25uPFdcXWa/gB8puhbePFXm/VwPHtfFaSF/so/ X8NNjLbgGMdH48kjeownLKFsfGEo9SUFrFWViu41N6aNUJ0+i7zBe3BhQh75Y5XWB7Hy EXcg== X-Gm-Message-State: AJIora93n4Pvkk9LgSeXrWNmIRNgcFjIr9IPTTWgA+nilifvviUyQcgx bwDebg1Hrp18cSYmwAcC+w9cjDxoTL9VPQ== X-Google-Smtp-Source: AGRyM1vndaLSOYBd70XYrwmb1uh8vY8U0sRMSIpiF0MD7ay4tlJaL/BsI9LEd8Mc/9J1P77yagbFJw== X-Received: by 2002:a05:620a:4305:b0:6a9:3829:c03 with SMTP id u5-20020a05620a430500b006a938290c03mr10450532qko.363.1656693672549; Fri, 01 Jul 2022 09:41:12 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-118.fbsv.net. [2a03:2880:20ff:76::face:b00c]) by smtp.gmail.com with ESMTPSA id y9-20020a05620a25c900b006a370031c3esm18674203qko.106.2022.07.01.09.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Jul 2022 09:41:12 -0700 (PDT) Date: Fri, 1 Jul 2022 09:41:10 -0700 From: David Vernet To: Adam Sindelar Cc: Andrew Morton , linux-mm@kvack.org, Adam Sindelar , kernel-team@fb.com Subject: Re: [PATCH v6] selftests/vm: Only run 128TBswitch with 5-level paging Message-ID: <20220701164110.dtbhogjjgdb25cjz@dev0025.ash9.facebook.com> References: <20220701163030.415735-1-adam@wowsignal.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701163030.415735-1-adam@wowsignal.io> User-Agent: NeoMutt/20211029 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656693673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UIQhm0URAojUxcbwYfOFzbJ0pGM2Vdxb/C/kZcqe4VQ=; b=YQwgT9iqLbsg1P/nHCeeeIeTAzpinVTByEYm4VZh9IX7VgsMRrRRIVmOwspTLCEQq/lBZ9 6c8zNNEWUHwYTsK01xYkmTruK5OrOMnnzMYGVq+Wifg6japPid0gzkSYPLIiNDYOFR61e+ LzfWkWuk3lx2msRxHIkqtlwmuUVXHLY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656693673; a=rsa-sha256; cv=none; b=dq4+EDOp8EGAl8k4MSMrqdCgakV4If941jUAaeJWSQrtvJQcXHvJQ2PT8n/BkXT/GvdjVg 1TWit0VjPBSgN0V8MTE1qVbp814dW8Mke10QH8sKug243OnwnANkn0tc4wKtKwtxASnw1r GsfvYcvG3zp2pURXMufrxQk/7Kjm9/c= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=dcvernet@gmail.com; dmarc=none X-Stat-Signature: 7u83xfos54kg9jzk5mtx9pxp8i7qkdrh X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.222.173 as permitted sender) smtp.mailfrom=dcvernet@gmail.com; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6293740062 X-HE-Tag: 1656693673-69389 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 01, 2022 at 06:30:30PM +0200, Adam Sindelar wrote: > The test va_128TBswitch.c expects to be able to pass mmap an address hint > and length that cross the address 1<<47. On x86_64, this is not possible > without 5-level page tables, so the test fails. > > The test is already only run on 64-bit powerpc and x86_64 archs, but this > patch adds an additional check on x86_64 that skips the test if > PG_TABLE_LEVELS < 5. There is precedent for checking /proc/config.gz in > selftests, e.g. in selftests/firmware. > > Running the tests produces the desired output: > > sudo make -C tools/testing/selftests TARGETS=vm run_tests > --------------------------- > running ./va_128TBswitch.sh > --------------------------- > ./va_128TBswitch.sh: PG_TABLE_LEVELS=4, must be >= 5 to run this test > [SKIP] > ------------------------------- > > Signed-off-by: Adam Sindelar [...] Thanks, Adam. Looks good to me. Reviewed-by: David Vernet