From: David Vernet <void@manifault.com>
To: Adam Sindelar <adam@wowsignal.io>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Adam Sindelar <ats@fb.com>,
kernel-team@fb.com
Subject: Re: [PATCH v6] selftests/vm: Only run 128TBswitch with 5-level paging
Date: Fri, 1 Jul 2022 09:41:10 -0700 [thread overview]
Message-ID: <20220701164110.dtbhogjjgdb25cjz@dev0025.ash9.facebook.com> (raw)
In-Reply-To: <20220701163030.415735-1-adam@wowsignal.io>
On Fri, Jul 01, 2022 at 06:30:30PM +0200, Adam Sindelar wrote:
> The test va_128TBswitch.c expects to be able to pass mmap an address hint
> and length that cross the address 1<<47. On x86_64, this is not possible
> without 5-level page tables, so the test fails.
>
> The test is already only run on 64-bit powerpc and x86_64 archs, but this
> patch adds an additional check on x86_64 that skips the test if
> PG_TABLE_LEVELS < 5. There is precedent for checking /proc/config.gz in
> selftests, e.g. in selftests/firmware.
>
> Running the tests produces the desired output:
>
> sudo make -C tools/testing/selftests TARGETS=vm run_tests
> ---------------------------
> running ./va_128TBswitch.sh
> ---------------------------
> ./va_128TBswitch.sh: PG_TABLE_LEVELS=4, must be >= 5 to run this test
> [SKIP]
> -------------------------------
>
> Signed-off-by: Adam Sindelar <adam@wowsignal.io>
[...]
Thanks, Adam. Looks good to me.
Reviewed-by: David Vernet <void@manifault.com>
prev parent reply other threads:[~2022-07-01 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 16:30 Adam Sindelar
2022-07-01 16:41 ` David Vernet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701164110.dtbhogjjgdb25cjz@dev0025.ash9.facebook.com \
--to=void@manifault.com \
--cc=adam@wowsignal.io \
--cc=akpm@linux-foundation.org \
--cc=ats@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox