From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB57DC43334 for ; Thu, 30 Jun 2022 09:33:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 485088E0001; Thu, 30 Jun 2022 05:33:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40E416B0073; Thu, 30 Jun 2022 05:33:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AF388E0001; Thu, 30 Jun 2022 05:33:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 15A896B0072 for ; Thu, 30 Jun 2022 05:33:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E3BF735659 for ; Thu, 30 Jun 2022 09:33:53 +0000 (UTC) X-FDA: 79634390346.25.111B11A Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf28.hostedemail.com (Postfix) with ESMTP id E0D80C0044 for ; Thu, 30 Jun 2022 09:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656581632; x=1688117632; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PgPzLl4LLLWiWoEp5qpCglqPZ3JOM/ueCvqywhPsDcA=; b=XCK0YWCev7wJ6u+BBducJboWABGa1M4vS1LpCaYA5dWDGj4cCgbvHoAs jqGv6tYL/qr29/Lky9wsvRkzndgnyGLZJbXiDV/Z2htI2dHJbfDNUQ32v e1HYLutcRSiQtXUnKLoUC3URKxOK5nXdv3KhG35czKYy3zs0Aqa644Sq+ gz6GWs6vLDPZJ+zh7kt78nw+NCrTXD7BCI21SSXnq8vp23BiIMgvTwHb0 cZg0Wc18rV1QYlBqkrmtjpOQ0NpH8NkbzwuNE7+p5NguHV6Kamn2WiqAb WW4vwXlRrB7Hzp7IAtMjl/3Yu3AcYtNZCSdkrNRPMUnxoyha1im9HlazN g==; X-IronPort-AV: E=McAfee;i="6400,9594,10393"; a="283398484" X-IronPort-AV: E=Sophos;i="5.92,233,1650956400"; d="scan'208";a="283398484" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 02:33:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,233,1650956400"; d="scan'208";a="693983715" Received: from shbuild999.sh.intel.com (HELO localhost) ([10.239.146.138]) by fmsmga002.fm.intel.com with ESMTP; 30 Jun 2022 02:33:47 -0700 Date: Thu, 30 Jun 2022 17:33:46 +0800 From: Feng Tang To: Robin Murphy Cc: Joerg Roedel , Will Deacon , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, Andrew Morton , Christoph Lameter , Vlastimil Babka , linux-mm@kvack.org, Paul Menzel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/iova: change IOVA_MAG_SIZE to 127 to save memory Message-ID: <20220630093346.GD4668@shbuild999.sh.intel.com> References: <20220630073304.26945-1-feng.tang@intel.com> <13db50bb-57c7-0d54-3857-84b8a4591d9e@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13db50bb-57c7-0d54-3857-84b8a4591d9e@arm.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656581633; a=rsa-sha256; cv=none; b=b5ZY8afN1H75/TL0rJYLYg7Fpy2kWEFtDhlP+YZ5zl80v0w+G/RuEteLzxN2WL+PfoYO1y l+2TGoBaZF2BAZmKA0m5PVYysSMlglA+b65KNdr/94goSxznzjBRP4K8x+nz+mYzdRQY5y 8F4vfxUidoOXvt8zbazvwhsK/Q8b2b4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XCK0YWCe; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of feng.tang@intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=feng.tang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656581633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sQZgcid25Yemi13FF0tBdp8lQLrgD8EoLEOAxdGWS1w=; b=maI8MDPK1A2KJdtony7+22l8jWWYIY177OOPo85ON2WBUjX71OKCNrF02haiq6E0COoh+f SVH76MxIuWJKjQWreXRZfQhqUWseEarufaIT94gdXsg86te+ousrPKQ6NF+DHjddJYTxVg Q/PhFiXiPLDg848Ylj5/atFt9LjgNkE= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E0D80C0044 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XCK0YWCe; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of feng.tang@intel.com has no SPF policy when checking 134.134.136.65) smtp.mailfrom=feng.tang@intel.com X-Rspam-User: X-Stat-Signature: xiw443wewq6fkihwnwknguamxn6j9wgg X-HE-Tag: 1656581632-118088 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Robin, On Thu, Jun 30, 2022 at 10:02:00AM +0100, Robin Murphy wrote: > On 2022-06-30 08:33, Feng Tang wrote: > > kmalloc will round up the request size to power of 2, and current > > iova_magazine's size is 1032 (1024+8) bytes, so each instance > > allocated will get 2048 bytes from kmalloc, causing around 1KB > > waste. > > > > And in some exstreme case, the memory wasted can trigger OOM as > > reported in 2019 on a crash kernel with 256 MB memory [1]. > > I don't think it really needs pointing out that excessive memory consumption > can cause OOM. Especially not in the particularly silly context of a system > with only 2MB of RAM per CPU - that's pretty much guaranteed to be doomed > one way or another. Yes, the 256MB for 128 CPU is kind of extreme, will remove this. > > [ 4.319253] iommu: Adding device 0000:06:00.2 to group 5 > > [ 4.325869] iommu: Adding device 0000:20:01.0 to group 15 > > [ 4.332648] iommu: Adding device 0000:20:02.0 to group 16 > > [ 4.338946] swapper/0 invoked oom-killer: gfp_mask=0x6040c0(GFP_KERNEL|__GFP_COMP), nodemask=(null), order=0, oom_score_adj=0 > > [ 4.350251] swapper/0 cpuset=/ mems_allowed=0 > > [ 4.354618] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.19.57.mx64.282 #1 > > [ 4.355612] Hardware name: Dell Inc. PowerEdge R7425/08V001, BIOS 1.9.3 06/25/2019 > > [ 4.355612] Call Trace: > > [ 4.355612] dump_stack+0x46/0x5b > > [ 4.355612] dump_header+0x6b/0x289 > > [ 4.355612] out_of_memory+0x470/0x4c0 > > [ 4.355612] __alloc_pages_nodemask+0x970/0x1030 > > [ 4.355612] cache_grow_begin+0x7d/0x520 > > [ 4.355612] fallback_alloc+0x148/0x200 > > [ 4.355612] kmem_cache_alloc_trace+0xac/0x1f0 > > [ 4.355612] init_iova_domain+0x112/0x170 > > [ 4.355612] amd_iommu_domain_alloc+0x138/0x1a0 > > [ 4.355612] iommu_group_get_for_dev+0xc4/0x1a0 > > [ 4.355612] amd_iommu_add_device+0x13a/0x610 > > [ 4.355612] add_iommu_group+0x20/0x30 > > [ 4.355612] bus_for_each_dev+0x76/0xc0 > > [ 4.355612] bus_set_iommu+0xb6/0xf0 > > [ 4.355612] amd_iommu_init_api+0x112/0x132 > > [ 4.355612] state_next+0xfb1/0x1165 > > [ 4.355612] amd_iommu_init+0x1f/0x67 > > [ 4.355612] pci_iommu_init+0x16/0x3f > > ... > > [ 4.670295] Unreclaimable slab info: > > ... > > [ 4.857565] kmalloc-2048 59164KB 59164KB > > > > Change IOVA_MAG_SIZE from 128 to 127 to make size of 'iova_magazine' > > 1024 bytes so that no memory will be wasted. > > > > [1]. https://lkml.org/lkml/2019/8/12/266 > > > > Signed-off-by: Feng Tang > > --- > > drivers/iommu/iova.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iommu/iova.c b/drivers/iommu/iova.c > > index db77aa675145b..27634ddd9b904 100644 > > --- a/drivers/iommu/iova.c > > +++ b/drivers/iommu/iova.c > > @@ -614,7 +614,12 @@ EXPORT_SYMBOL_GPL(reserve_iova); > > * dynamic size tuning described in the paper. > > */ > > -#define IOVA_MAG_SIZE 128 > > +/* > > + * As kmalloc's buffer size is fixed to power of 2, 127 is chosen to > > + * assure size of 'iova_magzine' to be 1024 bytes, so that no memory > > Typo: iova_magazine will fix. > > + * will be wasted. > > + */ > > +#define IOVA_MAG_SIZE 127 > > The change itself seems perfectly reasonable, though. > > Acked-by: Robin Murphy Thanks for the review! - Feng > > #define MAX_GLOBAL_MAGS 32 /* magazines per bin */ > > struct iova_magazine {