From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D40C43334 for ; Wed, 29 Jun 2022 23:24:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D8986B0071; Wed, 29 Jun 2022 19:24:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 487F76B0072; Wed, 29 Jun 2022 19:24:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 376E38E0001; Wed, 29 Jun 2022 19:24:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 27D2B6B0071 for ; Wed, 29 Jun 2022 19:24:18 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id D8DA41209B4 for ; Wed, 29 Jun 2022 23:24:17 +0000 (UTC) X-FDA: 79632854154.23.CC2C0F2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 576C18003D for ; Wed, 29 Jun 2022 23:24:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 710AD614D9; Wed, 29 Jun 2022 23:24:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51CB1C34114; Wed, 29 Jun 2022 23:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656545053; bh=Dnxtg2+47dMB9fvk3mpZuwgNcKCi6p+et4oU9iDj/kY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yIUhyRd1UmOnjNmm25XNKViGfXOi0X4HOJ10GLIlf13tTMKTjOUKLDyQ4Z2DbDg0O cVQjech3q/YmOGPV9iO+PcS3fpGyfcUYsFfe1708PQjUEfslyL6ytDB/D+Pq4Yvxiq Yqsj0t71BtS8NGnMPbzTZ5t6X4C+LtXr/VhhiUbg= Date: Wed, 29 Jun 2022 16:24:12 -0700 From: Andrew Morton To: Felix Kuehling Cc: David Hildenbrand , Alex Sierra , jgg@nvidia.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org Subject: Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages Message-Id: <20220629162412.d6aa0bf6244e487e4279fc31@linux-foundation.org> In-Reply-To: <575b48a6-e372-acda-9a7c-449f307a588c@amd.com> References: <20220629035426.20013-1-alex.sierra@amd.com> <20220629035426.20013-2-alex.sierra@amd.com> <575b48a6-e372-acda-9a7c-449f307a588c@amd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656545055; a=rsa-sha256; cv=none; b=txkvYxWDPMiRjOwctAhOP5neUqmkGMywUheE8gDr/SAhVBtHlmMtafmmAMwEK/Wl7PzmC2 RL5I+7SCnv2iMdukSfE4hZ741D//aS7KURFEIdDzhSfjuLD+3qj15RCm7z3FwZLp+g6s5G lM+Etsrc/J/iAbVo5kNRawp4o09dtfo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yIUhyRd1; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656545055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sivMz5SfiF5S53/Rl1WMnAN0B8PkqhNJOlE8OzlViBE=; b=sGysGSOzX+rNMVk8DOwyOzel7iRU8fi3b659yKsQm9xRZmxoiMVZF+7mx5B2Ux916Ngbv5 EV3GUjWiLBIg9K3XTd0pQRX4y9k9DE8ZFmvgdQFWoq3BsUXRz1tcJw69WCZueAAasGv0Si VrKi4rxjzVeVGzlwD6Ffr1TSyMxZoJg= X-Stat-Signature: ghud4atj4ce6mah3u8148mkp3wxxubk5 X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 576C18003D Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yIUhyRd1; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1656545055-870677 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 29 Jun 2022 18:08:40 -0400 Felix Kuehling wrote: > > > > I'd have called it "is_longterm_pinnable_page", but I am not a native > > speaker, so no strong opinion :) > > I think only the patch title has the name backwards. The code uses > is_longterm_pinnable_page. Patch title was quite buggy ;) I made it "mm: rename is_pinnable_page() to is_longterm_pinnable_page()" in my copy.