From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72425C43334 for ; Wed, 29 Jun 2022 06:42:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F14A6B0072; Wed, 29 Jun 2022 02:42:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A3628E0003; Wed, 29 Jun 2022 02:42:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED4088E0001; Wed, 29 Jun 2022 02:42:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DF6426B0072 for ; Wed, 29 Jun 2022 02:42:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id BDBD6811E2 for ; Wed, 29 Jun 2022 06:42:39 +0000 (UTC) X-FDA: 79630330038.10.7B0B979 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf09.hostedemail.com (Postfix) with ESMTP id E5A6D140030 for ; Wed, 29 Jun 2022 06:42:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2864567373; Wed, 29 Jun 2022 08:42:36 +0200 (CEST) Date: Wed, 29 Jun 2022 08:42:35 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni , Ralph Campbell , Jason Gunthorpe , Max Gurtovoy Subject: Re: [PATCH v7 11/21] RDMA/core: introduce ib_dma_pci_p2p_dma_supported() Message-ID: <20220629064235.GK17234@lst.de> References: <20220615161233.17527-1-logang@deltatee.com> <20220615161233.17527-12-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615161233.17527-12-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656484959; a=rsa-sha256; cv=none; b=SvOPBSi53g4GOcQ3GFZaFTLuIDMPkpKiE1VUdsYdDFonFrKWig/eysbZjC8+n1TWgc7Dx6 K6eob7ym5F81KuKEastm/bFJNBSOG9mNKTX2h+0a5i4PtG/iA5vCiCxJzsGhRD2SQLlgB5 rzJLSnTKTDyBIe5qzceLjpyXetFYN/Y= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=none (imf09.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656484959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ABoTTpU3JTWfBWE3xlxTeugKJPEA+6jj3ElYfHE7mXc=; b=HK6tu+rviVJFUb25RZNRpaLgbluIf/5glmCL5gFMNwp/finhr4rtSWtsJFAOdJQVy69Bhz k4VZeFApbMtnsVeDQDU9+AVGe2NfVb1Jq8dR/iEU1RitWiuI+8jKBrq00pv7uEVhTWR5ze svU4neoPmE9jqPLGdVBMEyQ2RrCNhqM= X-Rspam-User: X-Stat-Signature: x8763jiu8cqag4yc8fsice6b9wa1hm9i X-Rspamd-Queue-Id: E5A6D140030 Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=none (imf09.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam03 X-HE-Tag: 1656484958-215108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 10:12:23AM -0600, Logan Gunthorpe wrote: > Introduce the helper function ib_dma_pci_p2p_dma_supported() to check > if a given ib_device can be used in P2PDMA transfers. This ensures > the ib_device is not using virt_dma and also that the underlying > dma_device supports P2PDMA. > > Use the new helper in nvme-rdma to replace the existing check for > ib_uses_virt_dma(). Adding the dma_pci_p2pdma_supported() check allows > switching away from pci_p2pdma_[un]map_sg(). > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Jason Gunthorpe > Reviewed-by: Max Gurtovoy Looks good: Reviewed-by: Christoph Hellwig