From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56A19C433EF for ; Wed, 29 Jun 2022 00:25:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E45696B0071; Tue, 28 Jun 2022 20:25:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF57E6B0072; Tue, 28 Jun 2022 20:25:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6FCB8E0001; Tue, 28 Jun 2022 20:25:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B61136B0071 for ; Tue, 28 Jun 2022 20:25:48 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8A6D8607CE for ; Wed, 29 Jun 2022 00:25:48 +0000 (UTC) X-FDA: 79629380376.19.125EE7F Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf28.hostedemail.com (Postfix) with ESMTP id 153E0C003A for ; Wed, 29 Jun 2022 00:25:47 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25SMXtJR031263; Wed, 29 Jun 2022 00:25:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=An0ODL+Yja2FJ2SPIimIPek1MCwhvoc1rXsLS9EE2CQ=; b=BQOl9Qj7ZOuOX+s7zzjh3NfshaEX0bygBueWKIwBSALWjH8UspGSyE7gyJ7L3mtyaIeG +e6VWbDyoyCNNEeMl4qGB1JYuAjFLLh63pSm2Jx2IbeOftkontcT5J2Yns1d3djrmymH Baimpmjl/DbBL8ybKoimt+2/Ep8P0NQ+DH4Cd0VdwqD0JQWGBk5pSw8dZPa3CNtgs23f 5Vi7Ii4w7XRjW6p9Ipu2HS69lViNsd+hCwiha/sScTbUZxQoWJquZO0ksxH/tMl2GnB4 jWAyUXpJSJPztdKBITT5KJzaOi6uqD3+Hyv1Z+UupFtdZM89rsVdzLEI3zPeJC2h1ZrE bQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gwsysfpa0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jun 2022 00:25:27 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25T0BU9v018872; Wed, 29 Jun 2022 00:25:26 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2105.outbound.protection.outlook.com [104.47.55.105]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3gwrt2abf8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Jun 2022 00:25:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nomfWTWMaBadABWTNQIMG8GfV5DQgvksByYhBTUlZfjJnsPdjhagOaVRL2bmzEhXConvl6nhHxVBCvdmqSFJ9R6EoNziMaCu7nBFHFrazVzq+eQILIYPtuuXJRAMHR+kIGznIG1kcYBDFWBuNlaUY9UEHWfHzDAo6vSrGsarYtUZQ5QLZpr2tiHBNLiBdAQRZOijf5rAJ/mF2aIL+hFVRmZwLpbw9tjPt9MdEsrLsydrYeHQt9JUiKFPDSG+Zx1S7Sh8rfdhbIhyDDgsbY6PJgT0pHrwDmN+U2jxyNQ20+j0GqBuWjWHh+S1uWP/iQzG13YGTa3vk+NwGcci81JmkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=An0ODL+Yja2FJ2SPIimIPek1MCwhvoc1rXsLS9EE2CQ=; b=eJt8bZvANlmTnCkgpCJz2oKMl6PNM5rLB6BYEwFJaorAYCE/HxcqmEecg5Or0+eaRvzYI9i8mgSdH+l2abtYZ+hXir5iIWUK1DePj5JkPvrm47uAQ9hOl9obe7HYu6Cu5HTIz05HZqi8xlwk0NYTGL/Kbf/KNWVnA0rixrqiPxy6SvCSqdopqG3dUn5eqat/ExifcIYAD+gyXbDf+ZVIr6fsCKyET8HSL+anUpbz7gHrC4OZnk5IV+RwcCS6/Vjw/+gccUYdzPI0gKqN5RsDRUJJRKWclOOv89ZDC9drCRP9Dl3C3nprtD2whFQhKLh+Di9jDc9iGL/2NvmT8OjewQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=An0ODL+Yja2FJ2SPIimIPek1MCwhvoc1rXsLS9EE2CQ=; b=KoWZXFttKs479blvBER7vjKVz3QHt9yiOs8CNeRUP+CLMJ8GzKTa9WirRg0UUGx9S+zHrwyutld38Cd2BtLvuvvwZZXFBzPkNkMRdkBflCaJaQw7OA4LK2gS6TAjCKb8VFZswweqK4c0zeeQboD9PmYORhUzJZpnH/kB1bxZX7U= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by PH0PR10MB5593.namprd10.prod.outlook.com (2603:10b6:510:f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Wed, 29 Jun 2022 00:25:24 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::f59a:175d:d24:949c]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::f59a:175d:d24:949c%7]) with mapi id 15.20.5373.018; Wed, 29 Jun 2022 00:25:24 +0000 From: Liam Howlett To: Mauro Carvalho Chehab CC: Linux Doc Mailing List , Jonathan Corbet , "Matthew Wilcox (Oracle)" , Mauro Carvalho Chehab , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 15/22] mm: document maple tree pointer at unmap_vmas() at memory.c Thread-Topic: [PATCH 15/22] mm: document maple tree pointer at unmap_vmas() at memory.c Thread-Index: AQHYitP43WO/YWbn3keMiniJGtEfGK1lh8KA Date: Wed, 29 Jun 2022 00:25:24 +0000 Message-ID: <20220629002517.7xzweisyydh2mseb@revolver> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af7c25c8-e539-4819-b38e-08da5965dbe7 x-ms-traffictypediagnostic: PH0PR10MB5593:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f3SaUnRIwvK9ExSSnqXniJ+zvG4hEOC08F3mjJI5pB1GdOfOrExknrVtEGklbA0pgq6O0Eza8vi4Esu/EhopH0Aonh7tr9SziwbyP27w+dVVNPBtPcFJiAKw8HMDOXln+11VGTcOo3x5wtpSaLCLTpR+Q9aOP7d/orm7HrN4FjpQKsBVxsU3mfnmOvJdDHYBRoUD0nN3HmQqQsNbiktsoYMk1z86msoZzPI6kdRLfTc2/s8rZuKH4v+mJWQ/XX6+vUSp/3WLE2nNMMUrxqoTB7gC4jQCCLqL6CjIXxMjURrs8/iY/H7Zdlqf9Wl4RJw6rkcccT8MDqNSsRirHUvkd/XPZYagI/LGA7D3yyWwrlN3/d6LXcZgfwyUcmLESnHYKqaiToPUcMCRvgwMO20B+jGl38n8Whjwz2CrpglIIL+M5hq2dFl29par56bs31IyNDNR2G4SSdsLwP4unSXYWdK3IlkXlK0fslXH33LC/GTB1XAEx4JONOYAGpym6jdbkKPIR1t1OqerCyMd+EZFK8lU+oQg8O7neRbZPns7xGDTw8ppZWxf+iox6BdsHROEibVsbU0Ry1/zkxxlHwAZkuV5elLH1jbEH8qT6FPnqFNc3jTml9Q7h9+M2MG1YE4gQN2Qqiy3I0NfnK4pORsMBVAO2Y9+YbZKud3jMaruD1G6v6euutug7ES+Nt1nB728tdIlwfX2ubVFE/caHFOgG3onwOtLtWY6Mu6K8Md9lsCUo+yr+WmID3N8Nuq0t2eB+oemKvGLPtM7o70wyf3pFzXDkg2KwklT9GEkIyOMs8bHoE3l1JceXJHRQSxIbSoF x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(346002)(39860400002)(366004)(376002)(396003)(136003)(1076003)(6512007)(5660300002)(83380400001)(41300700001)(9686003)(86362001)(38070700005)(6486002)(966005)(6506007)(38100700002)(26005)(8676002)(66446008)(44832011)(316002)(478600001)(54906003)(64756008)(66476007)(2906002)(66556008)(91956017)(33716001)(8936002)(122000001)(71200400001)(186003)(76116006)(66946007)(6916009)(4326008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ps/ju7C9RyxL/620RXTlgl/paJ8qcISLRbtkw0P1Oyqm8p66mQ+wMfyaHmZV?= =?us-ascii?Q?TPUFR3/8TPS6l7X54VaOaAfdhuIEsM3Uo8x5WLqV9bI5h9AY/+MKONSoL+do?= =?us-ascii?Q?vO/ssEXKIxoTkwM+GWDNstNAdF+uEq/0go7AvWBZCS8XBqCoOm43PvQ6wD7m?= =?us-ascii?Q?8vHoO6v1H8BXrGSC2ImQrvySJst6F9kWzUJL8wlQMEagKm0yAsRV+8JHFVb1?= =?us-ascii?Q?V2KT/jQ+AqUF5r/JKBnnFbvWqW8Xsu/+n2vCreRMocf6oTYa3A/pyORWsjC7?= =?us-ascii?Q?gxVZTxn5hKT5ZNzRCYBHoFpzSYu6J2akqC28cTFLYI8vAttwde60D+gPbQZv?= =?us-ascii?Q?r/hVL/Sb0jFCRk1jM1F4MCWPKeoHNFbe6LTduOZ71y6QJ97yYw0VV7n88Xjx?= =?us-ascii?Q?xfIz8rK212027aAJeco1TAd3xlWnRZNpZGd8niTx8DZnEdEhbeusXVz48CHW?= =?us-ascii?Q?0hmst1Z3Xbe0pn6o7tgOy7ksuiz5NigU6x8anjRkLruGzwBkFUgMSEcs3+Up?= =?us-ascii?Q?apLUgK6SCONAiHLSnM2hDHB3Ldiz1wL7xFZKVh+Rm9ZC0ECQMxuvMNWE7zXN?= =?us-ascii?Q?y4ci8eN/M3OwDK4fGk4GrrDIpII8PpRV4GnrslxdZKZ82+S/U0J5vrOggdUA?= =?us-ascii?Q?5dinE//fx99IoI9wHq0Ce9cNrnR21oMYNxBF0nT2JqIwlVycmbuup+cK2WqN?= =?us-ascii?Q?2LS0SQVOfVRaqb1KgAxG2Wr6gvgRTTCYIuLCFgFSF1j7o4JFuRRMhJWrKeLL?= =?us-ascii?Q?UfDgfJZPThsglSByrVltBZZqNdcZgszK+kY63ppruY2Z0jlWyrridq2/dHRx?= =?us-ascii?Q?4akx/YdnPzl0EHBtvPhPYuP65XMEGOiSaSPi2n74tF7vGLS2RAkFGf+wEo4i?= =?us-ascii?Q?C8VHiCsSqgSeAZTb1kaHZdT/+BO2n8oG4gp2GHaHHwHolDqRW0zuxaO2BSb3?= =?us-ascii?Q?pXu//EIWGV5nU48MiVS+2qEszMyq9HXS7BP9n33JXojCnJb8rX8xpmSwHAc9?= =?us-ascii?Q?CHOTaNw75Y93hWdH5hyXAmbO5F8kyZ89kwSVxeNdnLvqH1r3XzrWV6K/lebL?= =?us-ascii?Q?J6c7Cwkt25PdLKxZJDRR+jxNRWpYHnAiRnscBFjjKmjL/y3halCwEzFcsf39?= =?us-ascii?Q?ePuzEQEQGnR42bA8auU8AnZ/PwdQsC51iYnoqZsp2XFFfHBavR5GgjoZG7J4?= =?us-ascii?Q?Rn5Gwp9cUPgS3i0WN0J0pjSjXu97AlXJe0r55uAbvfRgYVrMQjuuYv379LxV?= =?us-ascii?Q?hKHDbmA5bgo9PP9CMoAq1EnIxQPhPyww+mdYjoibUZ6hAAKi0kfRpJJ/2+LE?= =?us-ascii?Q?6XhslgNjZMJ9Q2MVdazj+edhl5oyYeCZohcbkr3blag5LNC8Ygv4MqOMreh3?= =?us-ascii?Q?kjoT1WxSIPwdn/95CW0igtHhBoPCYBPWSbHyFWlyxASKF0sRyu1wxxlX7OcZ?= =?us-ascii?Q?IA7hru88T+R3eeSYkTYap8rC/9PBW72oHfgeB+Ni/fErjIen3DHdbeQzdBRX?= =?us-ascii?Q?7hmK7qjEJLaMdKRGz2juz/ww7SetKBqeaRNZBiyFUAMohjHAXwR1d29GiHMQ?= =?us-ascii?Q?1/pZumKXwOwu7p9xMgYRpa1SWHStoeurR5DZgDqJw2g7FNQL6wB+3eBwVP5V?= =?us-ascii?Q?kg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <33791F33C9A83B489F24AD5552D818CB@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af7c25c8-e539-4819-b38e-08da5965dbe7 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 00:25:24.1685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ryQx+/ipJKU/wE4NbwXz3a58EwBK794Ig7swVdd1XwbCBjTgvm4IN8s1Bd402Bsh2VDD959RFpGpujQdN5i4KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5593 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-28_11:2022-06-28,2022-06-28 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 mlxlogscore=851 adultscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206280095 X-Proofpoint-ORIG-GUID: vWhxlCoFIMBHaV1o00VNYNS6O_qqwLGG X-Proofpoint-GUID: vWhxlCoFIMBHaV1o00VNYNS6O_qqwLGG ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1656462348; a=rsa-sha256; cv=pass; b=dOFtmIOTosiqEsS9DDBJuefD8SNEg9w8WXoyr+PI0g0B44HYGGABr+B0pqIrlSYflc1mdr TEQvL7uBVUYvC/ABySI7XH0o/FpGlf+PjjtJhbY19/shnzzBNY6VFdNQkkfQ46oWRsoYwV aQjT3Ih3bsALw0hRZf3Hy0Ahc5cFa5U= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=BQOl9Qj7; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=KoWZXFtt; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf28.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656462348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=An0ODL+Yja2FJ2SPIimIPek1MCwhvoc1rXsLS9EE2CQ=; b=MBJOk+jPTZNvCcCkmqDxxAgrW2P8X03e4sYmjjxNvqin8DDQ1SqAjP9iaYZ/bxqu4Hy4yh qyySB9v80bMHslJ9Tlg0UAKghRaRG32IDVHkC/+V8/7WtEc6aYTe/uB9Nd5+cCjpauNdEf 3lTWUY3ySks7gIpri17wmO3z6Me/6jk= X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=BQOl9Qj7; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=KoWZXFtt; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf28.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspamd-Server: rspam02 X-Stat-Signature: sy8oenzpjbh7chdsgujbjyus777da88g X-Rspamd-Queue-Id: 153E0C003A X-HE-Tag: 1656462347-446915 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Mauro Carvalho Chehab [220628 05:46]: > A maple tree pointer parameter was added at unmap_vmas() without > description: >=20 > mm/memory.c:1729: warning: Function parameter or member 'mt' not describ= ed in 'unmap_vmas' >=20 > Document it it. >=20 > Fixes: 5966e5c968b2 ("mm: remove the vma linked list") > Fixes: f8acc5e9581e ("Maple Tree: add new data structure") > Signed-off-by: Mauro Carvalho Chehab > --- >=20 > To avoid mailbombing on a large number of people, only mailing lists were= C/C on the cover. > See [PATCH 00/22] at: https://lore.kernel.org/all/cover.1656409369.git.mc= hehab@kernel.org/ >=20 > mm/memory.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/mm/memory.c b/mm/memory.c > index e3d3596068f2..771b61444507 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1707,6 +1707,8 @@ static void unmap_single_vma(struct mmu_gather *tlb= , > /** > * unmap_vmas - unmap a range of memory covered by a list of vma's > * @tlb: address of the caller's struct mmu_gather > + * @mt: maple tree pointer. A maple tree is a RCU-safe range based B-tre= e > + * designed to use modern processor cache efficiently Thanks, but I think that's a little too descriptive of type and a little lacking of description of what this tree actually holds. Maybe something like: @mt: The maple tree pointer for the VMAs? > * @vma: the starting vma > * @start_addr: virtual address at which to start unmapping > * @end_addr: virtual address at which to end unmapping > --=20 > 2.36.1 >=20 > =