From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819C8C433EF for ; Tue, 28 Jun 2022 11:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08F888E0002; Tue, 28 Jun 2022 07:03:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03F218E0001; Tue, 28 Jun 2022 07:03:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4A178E0002; Tue, 28 Jun 2022 07:03:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D63768E0001 for ; Tue, 28 Jun 2022 07:03:10 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 96B53F13 for ; Tue, 28 Jun 2022 11:03:10 +0000 (UTC) X-FDA: 79627357740.16.A41CE50 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 6573040043 for ; Tue, 28 Jun 2022 11:03:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 676D9619CF; Tue, 28 Jun 2022 11:03:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09003C341CA; Tue, 28 Jun 2022 11:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656414187; bh=uTdZoZ1skcBJGBohuXIOVKRZtrAs0MBBTX+3FECPSPM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gTFnpETkyGVGCIM4IT+CvqMTRBxfyUH2ihtD+Z6y8Fzhuz4K6ByL17dn/JqWo8U52 cnkKJSbGRShN9x+q28qb8+1m77QJFbv3jW+QYoE88uZmQ34rBdSvSZLN26Xvqs+3tQ cYVl5Fhu2urVJCiAdyRBsC++ERu6xrPgJOcZygVO/x+neqyExKrH9fDG9FZlQZpnlQ lcM6W3Mr7Olw/eiFcb1Iw6w8fAd+Qub5SNLeXBHghqtoR0eltM1t/2O+TAJ2Wy1snX YViUPVJ/3BWwr8PTT1a3nX6ZjKV/Xx3yAuq9ED4fBURDkfXglUOus9Ay1UiiqnduEk KmS0ChAUYW93A== Date: Tue, 28 Jun 2022 12:03:02 +0100 From: Will Deacon To: Zhou Guanghui Cc: akpm@linux-foundation.org, rppt@kernel.org, anshuman.khandual@arm.com, darren@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, xuqiang36@huawei.com Subject: Re: [PATCH v5] memblock,arm64: Expand the static memblock memory table Message-ID: <20220628110301.GA23703@willie-the-truck> References: <20220615102742.96450-1-zhouguanghui1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615102742.96450-1-zhouguanghui1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656414189; a=rsa-sha256; cv=none; b=hYmA18mhNsDev455XOUVftacV+KcKrfvFTcHlWP+2ZwtYiIgRD6f7agnKpJOBjRoP4eNQ2 IgmoCdefR+oBnKkBO2GJGbq6JgcuMJmY0ATo8x+IEuz49rwAtBS9ODtRzOWs9z8FoMEA+P Yr8pOYmpjKFWmtcl0DbyupDLMl0h3fU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gTFnpETk; spf=pass (imf01.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656414189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9/rwYz7DvJfVFgD4lqBntXy3Fue7r2m6tObJ5OEae58=; b=GnjAxBdRR4HtuuD4PXQO2xDje4NfLFUANEeElOgevSQHhWA/h0h+AgvgAvKW/57gwJfEWY XMBizjBzek1K9t4SphsHb+lV3BpOBwfxVWYdVffFh/CiVjRBaovyML6J+rnGW3axWTz2bj w03p5uoznox++V4675BaqAGA5RjpZd0= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6573040043 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gTFnpETk; spf=pass (imf01.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Stat-Signature: qdofi8sz33wmrikfhpxobn9fscpzcwha X-HE-Tag: 1656414189-88329 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 15, 2022 at 10:27:42AM +0000, Zhou Guanghui wrote: > In a system(Huawei Ascend ARM64 SoC) using HBM, a multi-bit ECC error > occurs, and the BIOS will mark the corresponding area (for example, 2 MB) > as unusable. When the system restarts next time, these areas are not > reported or reported as EFI_UNUSABLE_MEMORY. Both cases lead to an > increase in the number of memblocks, whereas EFI_UNUSABLE_MEMORY > leads to a larger number of memblocks. > > For example, if the EFI_UNUSABLE_MEMORY type is reported: > ... > memory[0x92] [0x0000200834a00000-0x0000200835bfffff], 0x0000000001200000 bytes on node 7 flags: 0x0 > memory[0x93] [0x0000200835c00000-0x0000200835dfffff], 0x0000000000200000 bytes on node 7 flags: 0x4 > memory[0x94] [0x0000200835e00000-0x00002008367fffff], 0x0000000000a00000 bytes on node 7 flags: 0x0 > memory[0x95] [0x0000200836800000-0x00002008369fffff], 0x0000000000200000 bytes on node 7 flags: 0x4 > memory[0x96] [0x0000200836a00000-0x0000200837bfffff], 0x0000000001200000 bytes on node 7 flags: 0x0 > memory[0x97] [0x0000200837c00000-0x0000200837dfffff], 0x0000000000200000 bytes on node 7 flags: 0x4 > memory[0x98] [0x0000200837e00000-0x000020087fffffff], 0x0000000048200000 bytes on node 7 flags: 0x0 > memory[0x99] [0x0000200880000000-0x0000200bcfffffff], 0x0000000350000000 bytes on node 6 flags: 0x0 > memory[0x9a] [0x0000200bd0000000-0x0000200bd01fffff], 0x0000000000200000 bytes on node 6 flags: 0x4 > memory[0x9b] [0x0000200bd0200000-0x0000200bd07fffff], 0x0000000000600000 bytes on node 6 flags: 0x0 > memory[0x9c] [0x0000200bd0800000-0x0000200bd09fffff], 0x0000000000200000 bytes on node 6 flags: 0x4 > memory[0x9d] [0x0000200bd0a00000-0x0000200fcfffffff], 0x00000003ff600000 bytes on node 6 flags: 0x0 > memory[0x9e] [0x0000200fd0000000-0x0000200fd01fffff], 0x0000000000200000 bytes on node 6 flags: 0x4 > memory[0x9f] [0x0000200fd0200000-0x0000200fffffffff], 0x000000002fe00000 bytes on node 6 flags: 0x0 > ... > > The EFI memory map is parsed to construct the memblock arrays before > the memblock arrays can be resized. As the result, memory regions > beyond INIT_MEMBLOCK_REGIONS are lost. > > Add a new macro INIT_MEMBLOCK_MEMORY_REGTIONS to replace nit: s/REGTIONS/REGIONS/ > INIT_MEMBLOCK_REGTIONS to define the size of the static memblock.memory > array. > > Allow overriding memblock.memory array size with architecture defined > INIT_MEMBLOCK_MEMORY_REGIONS and make arm64 to set > INIT_MEMBLOCK_MEMORY_REGIONS to 1024 when CONFIG_EFI is enabled. > > Signed-off-by: Zhou Guanghui > Acked-by: Mike Rapoport > Tested-by: Darren Hart > --- > arch/arm64/include/asm/memory.h | 9 +++++++++ > mm/memblock.c | 14 +++++++++----- > 2 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index 0af70d9abede..ce8614fa376a 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -364,6 +364,15 @@ void dump_mem_limit(void); > # define INIT_MEMBLOCK_RESERVED_REGIONS (INIT_MEMBLOCK_REGIONS + NR_CPUS + 1) > #endif > > +/* > + * memory regions which marked with flag MEMBLOCK_NOMAP(for example, the memory > + * of the EFI_UNUSABLE_MEMORY type) may divide a continuous memory block into > + * multiple parts. As a result, the number of memory regions is large. > + */ > +#ifdef CONFIG_EFI > +#define INIT_MEMBLOCK_MEMORY_REGIONS (INIT_MEMBLOCK_REGIONS * 8) > +#endif > + > #include > > #endif /* __ASM_MEMORY_H */ For the arm64 bit: Acked-by: Will Deacon I'm assuming Andrew will pick this up, but please yell if you'd prefer it to go via the arm64 tree. Will