From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5205C433EF for ; Tue, 28 Jun 2022 09:16:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D28B8E0002; Tue, 28 Jun 2022 05:16:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6825F8E0001; Tue, 28 Jun 2022 05:16:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 549C98E0002; Tue, 28 Jun 2022 05:16:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4312E8E0001 for ; Tue, 28 Jun 2022 05:16:52 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1765D351C3 for ; Tue, 28 Jun 2022 09:16:52 +0000 (UTC) X-FDA: 79627089864.16.DE07619 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf09.hostedemail.com (Postfix) with ESMTP id 91CA814003A for ; Tue, 28 Jun 2022 09:16:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6B0341FD97; Tue, 28 Jun 2022 09:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656407810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=23v656EJZgZ2B3RKrxYupmYVBHtGwcHmW+F/2IUSaFE=; b=O5kYOGNEuWcGqJsOSHgLzYULiCCU0PUt++61xI0DIuCuCUtRWjJEKfxOKzyFWoxdBB0XJu 7NkDIhBZwwj1lpQ1NmhL/PBQ6RhDgr4rjeikGdfq+oJAVz76W6bNJMKoFaY6DHgUhwwfjV pANFO/pJwqXmHAQJ4E1yl2rFcInDtws= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 301DB139E9; Tue, 28 Jun 2022 09:16:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /YTtCgLHumI1RQAAMHmgww (envelope-from ); Tue, 28 Jun 2022 09:16:50 +0000 Date: Tue, 28 Jun 2022 11:16:48 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Vasily Averin Cc: Roman Gushchin , Shakeel Butt , Michal Hocko , Tejun Heo , Zefan Li , Johannes Weiner , kernel@openvz.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , Muchun Song , cgroups@vger.kernel.org Subject: Re: [PATCH cgroup] cgroup: set the correct return code if hierarchy limits are reached Message-ID: <20220628091648.GA12249@blackbody.suse.cz> References: <186d5b5b-a082-3814-9963-bf57dfe08511@openvz.org> <17916824-ba97-68ba-8166-9402d5f4440c@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17916824-ba97-68ba-8166-9402d5f4440c@openvz.org> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656407811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=23v656EJZgZ2B3RKrxYupmYVBHtGwcHmW+F/2IUSaFE=; b=al3hIOPOD7Qq+AGxkVGLTqOk0lvENkmiHp5IQCPNyaytnrMhdLyLK5MgV3MFEAjI0ufgaU r/OY15LZFltlf96R5fjKk6xEy6aij2mmnbCVclvcVhPZrHkmD6ZgI/gJMN28I3VOEexZ4v ErFquhP+Csa6OgWeY5dJKr+Zf9SE3Kw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=O5kYOGNE; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656407811; a=rsa-sha256; cv=none; b=uM/RtkbgOxRZxMZosy8wFd0vqj2WSsHL0JQzhEhsJ/QYSIposhhF/ce5mT+EzCRCP6UWUy gXiRRb2JRl5xQe1oe8v9Uoh4k3bwHS81eBtNc3lbKAZgwqE8a8pSCfvlOyUEMUbMmrQnD4 pfOao5pLloRCqdVIlg/xqIWH9koeyMU= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=O5kYOGNE; spf=pass (imf09.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: athxnp6eyir59qf797iuiadjxpczs179 X-Rspamd-Queue-Id: 91CA814003A X-HE-Tag: 1656407811-591526 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022 at 06:59:06AM +0300, Vasily Averin wrote: > I would agree with you, however in my opinion EAGAIN is used to restart an > interrupted system call. Thus, I worry its return can loop the user space without > any chance of continuation. > > However, maybe I'm confusing something? The mkdir(2) manpage doesn't list EAGAIN at all. ENOSPC makes better sense here. (And I suspect the dependency on this particular value won't be very wide spread.) 0.02€ Michal