From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CD10C433EF for ; Tue, 28 Jun 2022 02:21:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D404C8E0002; Mon, 27 Jun 2022 22:21:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEFE28E0001; Mon, 27 Jun 2022 22:21:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB7D08E0002; Mon, 27 Jun 2022 22:21:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ACEDD8E0001 for ; Mon, 27 Jun 2022 22:21:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 827C080DEA for ; Tue, 28 Jun 2022 02:21:24 +0000 (UTC) X-FDA: 79626042888.20.A49854C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 24BFDC0021 for ; Tue, 28 Jun 2022 02:21:23 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EFA9617C8; Tue, 28 Jun 2022 02:21:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAD84C36AE5; Tue, 28 Jun 2022 02:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382882; bh=Gx50wDzQU5N6gDpRHLl9R6YCgbOEWXoj1h8NlNVhINM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q9QsEiu9K9tLVz3w3UFKinE2Dh81NMrYgJirlMFCtS/RrEXHWGTqnw3e6MGSVjW24 V0+Vf774T8rdTHuM8hYi3n6YZM41jcw9TVuxH+DcAQc7YVjTSZnlK9ibQ3DLHtRNZV XmZ3lc4XjRkd2xdLlQM8r06OCGXkpD90zUOR5w4HRDQJoYS3keFdw7hpI7K5pivAwd jM5Chi+rL9+NdhgYJAE/xUmP3wLHOoZOTmCYJjcCKmDSSo8KusR6sc28DQcdcO1dqs 4PeWtJ9khHzCCqyWhizXmYXWrItQPYtc4laNweTzoR3LIOv/lkB3R3nZRz7PDHmAlV Yad2tUkSA6v6A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ding Xiang , Shuah Khan , Sasha Levin , shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 11/41] selftests: vm: Fix resource leak when return error Date: Mon, 27 Jun 2022 22:20:30 -0400 Message-Id: <20220628022100.595243-11-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628022100.595243-1-sashal@kernel.org> References: <20220628022100.595243-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q9QsEiu9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of sashal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656382884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2OxtnZVZD688H/bkqxs39jxh9OYAHY3erKv9bGRFl4k=; b=Zv1eEN0vpmzcb2juiT+79zKu1W97pIoTL//xNMJQ4Dn2Bc4F+iDAEQybolaKNTvHt18cIg fDoNV5SF9q6xx/H9iBTZ+mgZP80OWzqlDlQ3DplMc5Tb9HyAJytoEu6pf1RDU/DeMiQ577 ChlWHhG4IVI5dUnlRZhuOrI/oS91Edo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656382884; a=rsa-sha256; cv=none; b=L6E8vE29rJ55/Xye2yC4/51XJ6rQy88dZtJRNoJsXA4vaQX55Y0KGehR8Jjq757aE1RwSz fkk9toDmxmYUEKXu3Gw9q1B80wr9mFbUkGCxKP8xI3lNZiF7aZkmeqPq/7I8KgLYo2l47b GfayU0vR3hlpd+EtiEh/uNJEEMuIH98= X-Stat-Signature: f3k34akww38gjr65cg155bu9mw8zqg5o X-Rspamd-Queue-Id: 24BFDC0021 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=q9QsEiu9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of sashal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sashal@kernel.org X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1656382883-641290 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Ding Xiang [ Upstream commit 3084a4ec7f9bb1ec90036cfd01b1abadc5dd4fb2 ] When return on an error path, file handle need to be closed to prevent resource leak Signed-off-by: Ding Xiang Reviewed-by: Shuah Khan Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/vm/ksm_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c index b61dcdb44c5b..b31f7a17d92a 100644 --- a/tools/testing/selftests/vm/ksm_tests.c +++ b/tools/testing/selftests/vm/ksm_tests.c @@ -48,6 +48,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) } if (fprintf(f, "%lu", val) < 0) { perror("fprintf"); + fclose(f); return 1; } fclose(f); @@ -66,6 +67,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) } if (fscanf(f, "%lu", val) != 1) { perror("fscanf"); + fclose(f); return 1; } fclose(f); -- 2.35.1