From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F18CCA480 for ; Tue, 28 Jun 2022 02:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDF928E0002; Mon, 27 Jun 2022 22:19:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8F8A8E0001; Mon, 27 Jun 2022 22:19:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A57108E0002; Mon, 27 Jun 2022 22:19:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 942678E0001 for ; Mon, 27 Jun 2022 22:19:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6708A32761 for ; Tue, 28 Jun 2022 02:19:09 +0000 (UTC) X-FDA: 79626037218.22.7F643A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 98760A001C for ; Tue, 28 Jun 2022 02:19:08 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7BB61617BB; Tue, 28 Jun 2022 02:19:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47AFDC341CF; Tue, 28 Jun 2022 02:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656382747; bh=ClquhrNOT4VD6E7tPI7YKsNFbFxfSRjNr71ch5jvgDY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z6EhzRkLJhZ81Wc9WJa7qPK0+7GYBTCNSU+Y5OAABiDPdErGwtiuAV5PwhLiPDBn7 ESleJ0/8pkT11ezTuKB+R7xofefR3c/l+UYqwoevBeRsxWRP37fEZXe4o9aelnlaox U0EWRXnUDs2fz2Qk43BATKPO642g+t6o8nupnFyRKT5TQyuvv/lpTOINWCw7lKCVyo rFy4O38Lrm5rK+bVQ9uYKu/7QQzztHPB+s+TGTX3YNdAIw1u3bRvDE6Rrz6WPnnueU 8/90WC03Kc9VpxV5kIGnYLv8pD7hrp1u1dqIxWvKu7PgWZJnmUlG7rftbK/hIebiv9 06aBxruP3JK3w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ding Xiang , Shuah Khan , Sasha Levin , shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: [PATCH AUTOSEL 5.18 13/53] selftests: vm: Fix resource leak when return error Date: Mon, 27 Jun 2022 22:17:59 -0400 Message-Id: <20220628021839.594423-13-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220628021839.594423-1-sashal@kernel.org> References: <20220628021839.594423-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6EhzRkL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sashal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sashal@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656382748; a=rsa-sha256; cv=none; b=ecGAu4hraibd+vo/WqdHN6HbKK9+g9Ch4uyBsj3KqZaLJ5a6U4lsb0qE7AslM6Cw7THLlj kbzI45Wzn5RY+V9jQiziGPQr5kBGsqYBYtVxys/hRDuQALc7jfti69WaJrFti1zHlpt0Gd BEWVc2A3MF1Gg2f1IEY+Vl57Yrkumvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656382748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fHVTvmveTjq0vf+7Iu+fuWLbpFght/mq/es9fF2sHCY=; b=CLOjuohoVJiO7NdUbBGJfh24MRKwVTreEYEh6qTQNVRataqE0lkLYRim6V1IBlBNUJHKrZ XPZMAM3bqnhHRdUyI9BAhjhJxoixus5/ohfhsLGKrdMRQiFfFsBD5ybBSzdLCUizSGgSHE mAs4JLkqloyi5GfBs786DW7nF8O7klg= X-Stat-Signature: x1zcqth3cfzh333e4yebqouyuxgbson8 X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: 98760A001C Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6EhzRkL; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sashal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sashal@kernel.org X-HE-Tag: 1656382748-469373 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Ding Xiang [ Upstream commit 3084a4ec7f9bb1ec90036cfd01b1abadc5dd4fb2 ] When return on an error path, file handle need to be closed to prevent resource leak Signed-off-by: Ding Xiang Reviewed-by: Shuah Khan Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/testing/selftests/vm/ksm_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c index fd85f15869d1..aa834b04daa8 100644 --- a/tools/testing/selftests/vm/ksm_tests.c +++ b/tools/testing/selftests/vm/ksm_tests.c @@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) } if (fprintf(f, "%lu", val) < 0) { perror("fprintf"); + fclose(f); return 1; } fclose(f); @@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) } if (fscanf(f, "%lu", val) != 1) { perror("fscanf"); + fclose(f); return 1; } fclose(f); -- 2.35.1