From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C005C43334 for ; Mon, 27 Jun 2022 16:39:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED24C8E0002; Mon, 27 Jun 2022 12:39:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E82F88E0001; Mon, 27 Jun 2022 12:39:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4AD58E0002; Mon, 27 Jun 2022 12:39:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C51FF8E0001 for ; Mon, 27 Jun 2022 12:39:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99C50200C3 for ; Mon, 27 Jun 2022 16:39:21 +0000 (UTC) X-FDA: 79624576122.20.10E1012 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf26.hostedemail.com (Postfix) with ESMTP id 0BB3F140017 for ; Mon, 27 Jun 2022 16:39:20 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id cf14so13872303edb.8 for ; Mon, 27 Jun 2022 09:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wowsignal-io.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qvYy5kSvtMUASfdN6tyiYW8Jcz0s26WAUdNV7HTHO+U=; b=rqejbbjhpCoPOfMGsmAP5hpc076dSfg68dbwGwMAHOmVxI6rx5MKTx7PLieltxuWhV AlNUaCiYvcWCzCnsEdd4SvSxIZP5nkSBLQW1R1OBBbVUqTGgCma+esrpyu+8GO/IO7iz 2qdiGMt568+hmAYX9wkIXRwN7y5CmjR8aQnzNWc87c3M+6lRGeRQFDRpWtUvjcp0qwdz wvejUwxUpkg4cvPV5uS22A2jOLlzgHVqKQSbqzq6H4Adox59vv05dGotxc3Ob5JAA4NI /q1f7pyXPLCH0iBLm6F3qhpKFl2hygyEHXGaNwblfMjF6ZXbFEgDaOiGUJH4c6La6Mg0 RGbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qvYy5kSvtMUASfdN6tyiYW8Jcz0s26WAUdNV7HTHO+U=; b=zRFU0vYWA+PBZM8Lu9/1tMHBqtHE0j1f5+6s0z+s7NDnreCjw8bg+Kiv85uAEJoGHI wv2TSDrL4j5eG2VUGatT0jmgbyK5O8nC9OcjsIbdIvDU+VcgxJvJMiNxOElr/LmByAET b4y9omLvPOm4kgJAecprMIFbF9ry00ICIq9LeFyJwNVaY4XHm+V8/HxyaQUQ4XhZmqqw ckaG/ckcy3eliDVAUr/vl6rwJUsmjvRIZaoKq47nWuDGgQ6vmLh+Wj/7/qEkmv6WQNI0 i9rR/DpWh6jUpRokq8+JnjnKzAqyllOC5FLYNY1jq57mFf+e7ulUPgSGrrdVRaWJpM0K L0eA== X-Gm-Message-State: AJIora/im5uJXo1IoYvHHLZ8DFxnShRm9+OAkKKdPF+Gzdzv/pwX72Rp Ht2lsnZEBIdWiev+9wq7ZVnTVA== X-Google-Smtp-Source: AGRyM1uCEf0DpJIXzvhQAG1lhzzjohfIXRt1SRoXzzrdNfN7+VQk1OcrrwVPmEc154jO7HV2U+jLJQ== X-Received: by 2002:aa7:c6d9:0:b0:435:706a:4578 with SMTP id b25-20020aa7c6d9000000b00435706a4578mr18033305eds.24.1656347959822; Mon, 27 Jun 2022 09:39:19 -0700 (PDT) Received: from localhost (212-51-140-210.fiber7.init7.net. [212.51.140.210]) by smtp.gmail.com with ESMTPSA id u17-20020a1709063b9100b006f3ef214e13sm5248555ejf.121.2022.06.27.09.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:39:19 -0700 (PDT) From: Adam Sindelar To: Andrew Morton Cc: linux-mm@kvack.org, Adam Sindelar , Adam Sindelar , David Vernet , kernel-team@fb.com Subject: [PATCH v3] selftests/vm: Only run 128TBswitch with 5-level paging Date: Mon, 27 Jun 2022 18:39:12 +0200 Message-Id: <20220627163912.5581-1-adam@wowsignal.io> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656347961; a=rsa-sha256; cv=none; b=q4YJ4qVc7R5j59oiCHPTTeQCBoUF+t9f8Bg8LNsv1uZ7QM1Eulj6d7HXr0/coD0xHDaaHp Yk9qEhYvXCcMvgqP1FG7VZUcnRzu7XcouDER8CpPpvIbcpqohEz6Skk5wIGaYjiSs3FCo+ WyNSwnQ3i3Bzzv4j1lzWfUxe7T7d7Eg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=rqejbbjh; dmarc=none; spf=none (imf26.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.208.46) smtp.mailfrom=adam@wowsignal.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656347961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=qvYy5kSvtMUASfdN6tyiYW8Jcz0s26WAUdNV7HTHO+U=; b=CN3h8dkbQTp8aEr6r8Q4D2q8uhq96qdBSl1QX001L59kUVD6OY+m3MvbLuvq/9trX3yqyf ZJfKhEp99btVOt8yh/U+CH3o/pqgNgDj+nbPl270YcR46xand09kfNsYfJ+uDU28S8m/VD d/7t4UtPTT4cisiUk8Ru1Sx6lq9AubQ= X-Rspam-User: X-Stat-Signature: 14jss7cqo6jckpfx4rpgnc6c7wha84jm X-Rspamd-Queue-Id: 0BB3F140017 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=wowsignal-io.20210112.gappssmtp.com header.s=20210112 header.b=rqejbbjh; dmarc=none; spf=none (imf26.hostedemail.com: domain of adam@wowsignal.io has no SPF policy when checking 209.85.208.46) smtp.mailfrom=adam@wowsignal.io X-Rspamd-Server: rspam03 X-HE-Tag: 1656347960-961183 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The test va_128TBswitch.c expects to be able to pass mmap an address hint and length that cross the address 1<<47. This is not possible without 5-level page tables, so the test fails. The test is already only run on 64-bit powerpc and x86 archs, but this patch adds an additional check that skips the test if PG_TABLE_LEVELS < 5. There is precedent for checking /proc/config.gz in selftests, e.g. in selftests/firmware. Running the tests produces the desired output: sudo make -C tools/testing/selftests TARGETS=vm run_tests --------------------------- running ./va_128TBswitch.sh --------------------------- ./va_128TBswitch.sh: PG_TABLE_LEVELS=4, must be >= 5 to run this test [SKIP] ------------------------------- Signed-off-by: Adam Sindelar --- V2 -> V3: Clean up the commit message V1 -> V2: Variables local, fixed Makefile typo, comment on gzip usage tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/run_vmtests.sh | 2 +- tools/testing/selftests/vm/va_128TBswitch.sh | 39 ++++++++++++++++++++ 3 files changed, 41 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests/vm/va_128TBswitch.sh diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index c45e535ff4b8..7860d0969888 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -91,6 +91,7 @@ endif TEST_PROGS := run_vmtests.sh TEST_FILES := test_vmalloc.sh +TEST_FILES += va_128TBswitch.sh KSFT_KHDR_INSTALL := 1 include ../lib.mk diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh index a2302b5faaf2..edda7350ccca 100755 --- a/tools/testing/selftests/vm/run_vmtests.sh +++ b/tools/testing/selftests/vm/run_vmtests.sh @@ -149,7 +149,7 @@ if [ $VADDR64 -ne 0 ]; then run_test ./virtual_address_range # virtual address 128TB switch test - run_test ./va_128TBswitch + run_test ./va_128TBswitch.sh fi # VADDR64 # vmalloc stability smoke test diff --git a/tools/testing/selftests/vm/va_128TBswitch.sh b/tools/testing/selftests/vm/va_128TBswitch.sh new file mode 100755 index 000000000000..767a6465b5d2 --- /dev/null +++ b/tools/testing/selftests/vm/va_128TBswitch.sh @@ -0,0 +1,39 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) 2022 Adam Sindelar (Meta) +# +# This is a test for mmap behavior with 5-level paging. This script wraps the +# real test to check that the kernel is configured to support at least 5 +# pagetable levels. + +# 1 means the test failed +exitcode=1 + +# Kselftest framework requirement - SKIP code is 4. +ksft_skip=4 + +die() +{ + echo "$1" + exit $exitcode +} + +check_test_requirements() +{ + local config="/proc/config.gz" + [[ -f "${config}" ]] || config="/boot/config-$(uname -r)" + [[ -f "${config}" ]] || die "Cannot find kernel config in /proc or /boot" + + # gzip -dcfq automatically handles both compressed and plaintext input. + # See man 1 gzip under '-f'. + local pg_table_levels=$(gzip -dcfq "${config}" | grep PGTABLE_LEVELS | cut -d'=' -f 2) + + if [[ "${pg_table_levels}" -lt 5 ]]; then + echo "$0: PG_TABLE_LEVELS=${pg_table_levels}, must be >= 5 to run this test" + exit $ksft_skip + fi +} + +check_test_requirements +./va_128TBswitch -- 2.35.1