From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09867C43334 for ; Sun, 26 Jun 2022 20:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65F548E0002; Sun, 26 Jun 2022 16:06:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E6B78E0001; Sun, 26 Jun 2022 16:06:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461098E0002; Sun, 26 Jun 2022 16:06:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 30C308E0001 for ; Sun, 26 Jun 2022 16:06:26 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 06B1034373 for ; Sun, 26 Jun 2022 20:06:26 +0000 (UTC) X-FDA: 79621469172.02.FE32BD3 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf22.hostedemail.com (Postfix) with ESMTP id A50E2C002E for ; Sun, 26 Jun 2022 20:06:21 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id k10so5632007qke.9 for ; Sun, 26 Jun 2022 13:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZgLetThySYV51Aytz6mh0N038I4xXTGk9aBFCM9zRec=; b=a2Yt5gzzM3yzj5vSUuIuvXaPNDCciwPVd7rzWq4cowkgBqcx+0pxMCgMZCVbN+25eN Ony8G9mj9cbyeEOSU5Me4xp2a17SHxR5i1r5/mmdtI6HyBXGax89T3xQf7UNNHdJRpfc J6YqrilbDb8wGPvT7Hb6VNr0P0ByVQgFF+OLRvsF4c2C/c6TEnY2IAPnFPnrPH5ly5fN MuXffAihwZOCAxMzFwCNm1snokHyBLhzOoGZCJABPNud0Cju1PpHaHNMXEe2iCiiIDgA pjh2RNHChebcQ6ZmAF+5zNHcKVVkpYI9/dVr7PnKms80UqujZdm0vmBr03b9x1qVLnKA nnrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZgLetThySYV51Aytz6mh0N038I4xXTGk9aBFCM9zRec=; b=sxJKRnHukT4ow2njsT/uSUs3ZnaFKeucZkmBXz7irMoujuoecwhcGwE68iquflPa0g EfdB6NmnEtSn+cdkjNYrUsMLCwSn27d5+1re9HCbKY7DXpVuMNkYm6ZTBDyMWdP+zOrk 9d4eId3OpzVs+0qah1zVR4qpsj4lFHj3kGxCkLLVYujLxiSlKgzZ5ulY2l+znIkSbTPS Ohv1DQinBeWxLFhXCgQ0NPq9t8dVDNnj/raNxaHlbVqeRYD4sn3XxxswgxZBbxBLcpsE FVvtTNNpOapB+X+QtXDlhgrYD+qDjb/a4XKhSSezokUyLfsgvBra21wfLEW58D79TUYn vnBA== X-Gm-Message-State: AJIora8nic8j3u79Y0KjJR/mjqrA/2JTsJM5Vtvu3nqSn4BKBoK4qFhG KCwbkqdT9snLJI37HPk+VQ== X-Google-Smtp-Source: AGRyM1sAJAR5/R/iEM96/kcnjIvfe6WWzgqnDoiUADllWujM4vzLfnQXAoshQW44CQdMxAIiWW0sxA== X-Received: by 2002:a05:620a:12f8:b0:6af:25af:f169 with SMTP id f24-20020a05620a12f800b006af25aff169mr1733612qkl.541.1656273980907; Sun, 26 Jun 2022 13:06:20 -0700 (PDT) Received: from localhost (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id f1-20020a05620a280100b006a71c420460sm7540956qkp.22.2022.06.26.13.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 13:06:19 -0700 (PDT) Date: Sun, 26 Jun 2022 16:06:18 -0400 From: Kent Overstreet To: Joe Perches Cc: Andrew Morton , Linus Torvalds , David Laight , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Matthew Wilcox , Miguel Ojeda , Andy Shevchenko , LKML , linux-mm Subject: Re: [RFC[ Alloc in vsprintf Message-ID: <20220626200618.jhxu5lg4w7o2irhr@moria.home.lan> References: <20220620004233.3805-1-kent.overstreet@gmail.com> <0a5901f8460f452a89c9b0cda32fb833@AcuMS.aculab.com> <20220620150514.3tjy5dv7pv5frcwd@moria.home.lan> <53d77ae6101a0f24cfb694174d4c7699424c57e8.camel@perches.com> <20220621005752.ohiq5besmy3r5rjo@moria.home.lan> <355e912490dbaef8fe4e12df0201c3f5b439565d.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <355e912490dbaef8fe4e12df0201c3f5b439565d.camel@perches.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656273981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZgLetThySYV51Aytz6mh0N038I4xXTGk9aBFCM9zRec=; b=ChBzCSR/1FtFRznoylvKnr5JXMzx6Z86I22ulpyapT6cWhig/vPkCHf4Y/ChwtDEnKf42t HsSM+NkfkxNRNir0jm7Ey7RddZU5P/scaM1VsFwf7opwALnXp5+FzANl1ErL7tZOgq7PJt EHpPLoPWOhEmzd5vrRdxQLzQBJ8IHmc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=a2Yt5gzz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656273981; a=rsa-sha256; cv=none; b=gVSzC3Gf5tu48r00Ez2cAQzRgf/CWOPjoaczFxcgTuxGD5zuz+sDoQpGBrghR921pD6v1y O7SSeZxbL5XMgCxHx9iuFIkQUiKOmFNNAGXx7kwQvNqeV0jRH+Z8HaB3ITkM/jrB9yxd1k vvCuxATrdkyiJSgTRZXGsBJQwx2w1fE= X-Rspamd-Queue-Id: A50E2C002E Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=a2Yt5gzz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.177 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: km1wicru1kqjkgjiyr4cj5x6q7hcufjh X-HE-Tag: 1656273981-114281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 26, 2022 at 12:53:26PM -0700, Joe Perches wrote: > In a reply to the printbufs thread, I wrote a proposal to use an > alloc to reduce stack in vsprintf when CONFIG_KALLSYMS is enabled. > > No one has replied to this but I think it's somewhat sensible. > > Thoughts? As functions get converted to printbufs the separate stack allocated buffers become unnecessary, because printbufs have helpers that do bounds checking and make outputting to the vsprintf buffer painless. So it's not necessary - I haven't fully converted symbol_string() yet but I'll do so by the time I mail out the next round of patches.