From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54C3C43334 for ; Sat, 25 Jun 2022 18:55:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0B196B0071; Sat, 25 Jun 2022 14:55:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBB136B0072; Sat, 25 Jun 2022 14:55:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A82596B0073; Sat, 25 Jun 2022 14:55:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 95F9F6B0071 for ; Sat, 25 Jun 2022 14:55:08 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CB12204D4 for ; Sat, 25 Jun 2022 18:55:08 +0000 (UTC) X-FDA: 79617660696.16.304FD17 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 98A884001C for ; Sat, 25 Jun 2022 18:55:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D00AB80CAF; Sat, 25 Jun 2022 18:55:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92CD1C3411C; Sat, 25 Jun 2022 18:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656183304; bh=A3qyjjsryOa7J2ItedKhH4Huf5P8CnU7F9RxA8YtExY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bE4wbfvrEbUAIra0inC54hOjX2MLei7fmRLTWkzI0bjriYQ8tC4aplpduwqYQ9WeU S7vZxu9v0AoP6N97ZU44DvFgmpdue7Ia40a6QihNi4Zfy50QQHKQ2mBrE6sxq0bQi2 MHEVLY0oMatkOeVtpOTHui74lmHRXw6crxRjUPL3tjCCjld/ZU81u6jawZzLZL94fM Cb1IsPi5MuPEr5CJ6qm8aeL8tbmV4DTStAZ2EvwGBWAzAQsKlDxQHMz1Thpupg52ff FHjVUEB2J5dW1c2AZ6xJIVQBqjCx0rBhn4SN2lYRd0qY65lMOus51IfM8AzIcDlyEZ J3Cp623rZCoPA== From: SeongJae Park To: Gautam Cc: sj@kernel.org, shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] kselftests/damon: add support for cases where debugfs cannot be read Date: Sat, 25 Jun 2022 18:55:01 +0000 Message-Id: <20220625185501.85168-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220625083513.19761-1-gautammenghani201@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656183307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=juUkpVjerUoPxqmZjXOb/GXL70JpW9IKl0Wd9SKkOrg=; b=DbtqZ3yr2i1R+JU1KSlEFXNKWyAdDL6bDzsKxIb9BdHm86zxVE8WinqD2Oi2IWPzaTp2G9 b56VS1Ot4aVZxGpVzD1wHIxcWiyHgrZcEXlLkhrgcoDjl1Z35fCBHrJ12CKQDHmSeo6WRW t8uq8YSPjmrl8H7+FUM9JjVgMpixEC8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bE4wbfvr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656183307; a=rsa-sha256; cv=none; b=RGInO9JqiU/cUpQ360vNNw21XuueqOtA+Qb2OT0R9m5dvXLLiOcNCmAZAwgwzn0TiXgJys BEwjO+npIWua4b31Rxx1J5wsLscBUZn/nGvqfpiOs/jth+ns8UCvQRHm4dAH4kwDz1d5sY OvHRcWp3gBgR4acF4Waw67sd4X8QBa8= X-Rspamd-Queue-Id: 98A884001C Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bE4wbfvr; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wcpiprz6e34ryojrj1ommhtuipfgc3xb X-HE-Tag: 1656183307-241908 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Gautam, On Sat, 25 Jun 2022 14:05:13 +0530 Gautam wrote: > The kernel is in lockdown mode when secureboot is enabled and hence > debugfs cannot be used. Add support for this and other general cases > where debugfs cannot be read and communicate the same to the user before > running tests. > > Signed-off-by: Gautam All looks good, thank you! I left one comment below, though. After fixing it, you may have Reviewed-by: SeongJae Park > --- > Changes in v2: > 1. Modify the error message to account for general cases. > 2. Change the return code so that the test is skipped. > > Changes in v3: > 1. Change the name of variable holding the error message. > > tools/testing/selftests/damon/_chk_dependency.sh | 10 ++++++++++ > 1 file changed, 10 insertions(+) > mode change 100644 => 100755 tools/testing/selftests/damon/_chk_dependency.sh I think this permission change is unnecessary? Thanks, SJ > > diff --git a/tools/testing/selftests/damon/_chk_dependency.sh b/tools/testing/selftests/damon/_chk_dependency.sh > old mode 100644 > new mode 100755 > index 0189db81550b..0328ac0b5a5e > --- a/tools/testing/selftests/damon/_chk_dependency.sh > +++ b/tools/testing/selftests/damon/_chk_dependency.sh > @@ -26,3 +26,13 @@ do > exit 1 > fi > done > + > +permission_error="Operation not permitted" > +for f in attrs target_ids monitor_on > +do > + status=$( cat "$DBGFS/$f" 2>&1 ) > + if [ "${status#*$permission_error}" != "$status" ]; then > + echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?" > + exit $ksft_skip > + fi > +done > -- > 2.36.1