From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA65C433EF for ; Fri, 24 Jun 2022 20:42:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B78318E0274; Fri, 24 Jun 2022 16:42:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFE6A8E0244; Fri, 24 Jun 2022 16:42:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99FC98E0274; Fri, 24 Jun 2022 16:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 83A248E0244 for ; Fri, 24 Jun 2022 16:42:23 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5AF1A34473 for ; Fri, 24 Jun 2022 20:42:23 +0000 (UTC) X-FDA: 79614302166.06.9736924 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 229A8A009B for ; Fri, 24 Jun 2022 20:42:22 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2810B82B70; Fri, 24 Jun 2022 20:42:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AFA2C34114; Fri, 24 Jun 2022 20:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656103339; bh=HJF52zgRYn3/Rr4hsGWd7q73e7ioepvI0/ZbX6ud59g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MOscdG7jNT0hJ8pcoO/fjEE6wMz0TeH3jhzRhWLjQEBVFuiQSPZ1wgMduEPAetn5y nZ/SvOpdgyxs4So1NnbOWV7VHpUBipR7OTCzCo29xSnRfh3Ne+COeiUNHzkblbZlE/ kTCrSofb4+3lrJm5n2qONe9fWoiRRf8WqnqQ7N74= Date: Fri, 24 Jun 2022 13:42:18 -0700 From: Andrew Morton To: zhouchuyi Cc: linux-mm@kvack.org, Michal Hocko , Roman Gushchin , Johannes Weiner , Shakeel Butt , Muchun Song Subject: Re: [PATCH] mm/vmscan: add pgstall to memcg Message-Id: <20220624134218.e25104d902f7fde209728a23@linux-foundation.org> In-Reply-To: <20220623080103.156628-1-zhouchuyi@bytedance.com> References: <20220623080103.156628-1-zhouchuyi@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656103342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8GRJgIroo0vOEW14hMoMyiR+qlrEYAKBXd6BXuQwNq8=; b=vTGHUSkfO9Z2UFsuV4AUGog5UCnIcTb8K80mhSP8D2u31LQBKZhitBjeAOlcw8mD52V4FW 52iVC6vcZMJkSzlrO9uoDEVxOF2jDY8vq07muKNBidTRfuiUOas/iEVA1AqxdlTJICSIAV EUrTL3fO5hldqJ9a1O8I1hrTQ+JGD4k= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MOscdG7j; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656103342; a=rsa-sha256; cv=none; b=KPGHqN1QnT64okGUNwa8xRYE9GQXEAk50l8fpTV2HR+tRdcdyhgR3HIELZrP0pLV7Kcw9E kNYRj4Ykyxr0mi11T85XfyWg4+p6vd2hDoOkRSVOVbXoJxzQtzS26eBdmZccqDnPEDWWwQ mdlsrVCg94ijgvZQU6J5Av85sClp+KA= Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MOscdG7j; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: f4tojn8bfc8s8yo7pbajykxd8r791ke9 X-Rspamd-Queue-Id: 229A8A009B X-HE-Tag: 1656103342-626919 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (cc memcg developers) On Thu, 23 Jun 2022 16:01:03 +0800 zhouchuyi wrote: > Add pgstall to indicate the times of entering direct reclaim of memcg, use > the item of ALLOCSTALL_NORMAL in vmevents to save the data. > > Signed-off-by: zhouchuyi > --- > > > Hi， > > I notice memcg uses some items to indicate the situation of direct reclaim in memory.stat，such as pgsteal and pgscan. > I think there is no harm in adding another item to show the times of entering direct reclaim. > Why do you consider this useful? Do you have a use case? If so, please describe it in detail. > > ... > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 176298f2f..44c5b15bd 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -1447,8 +1447,11 @@ PAGE_SIZE multiple when read back. > > pgsteal (npn) > Amount of reclaimed pages > - > - pgactivate (npn) > + > + pgstall (npn) > + Number of entering direct reclaim > + > + pgactivate (npn) > Amount of pages moved to the active LRU list > > pgdeactivate (npn) > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index abec50f31..f407084b2 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1505,6 +1505,8 @@ static char *memory_stat_format(struct mem_cgroup *memcg) > seq_buf_printf(&s, "pgscan %lu\n", > memcg_events(memcg, PGSCAN_KSWAPD) + > memcg_events(memcg, PGSCAN_DIRECT)); > + seq_buf_printf(&s, "pgstall %lu\n", > + memcg_events(memcg, ALLOCSTALL_NORMAL)); > seq_buf_printf(&s, "pgsteal %lu\n", > memcg_events(memcg, PGSTEAL_KSWAPD) + > memcg_events(memcg, PGSTEAL_DIRECT)); > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f7d9a683e..107cec59a 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3532,7 +3532,10 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, > > if (!cgroup_reclaim(sc)) > __count_zid_vm_events(ALLOCSTALL, sc->reclaim_idx, 1); > - > + else { > + count_memcg_events(sc->target_mem_cgroup, > + ALLOCSTALL_NORMAL, 1); > + } > do { > vmpressure_prio(sc->gfp_mask, sc->target_mem_cgroup, > sc->priority); > -- > 2.20.1