From: <yee.lee@mediatek.com>
To: <linux-kernel@vger.kernel.org>
Cc: Yee Lee <yee.lee@mediatek.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:KFENCE" <kasan-dev@googlegroups.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: [PATCH 1/1] mm: kfence: skip kmemleak alloc in kfence_pool
Date: Thu, 23 Jun 2022 19:19:35 +0800 [thread overview]
Message-ID: <20220623111937.6491-2-yee.lee@mediatek.com> (raw)
In-Reply-To: <20220623111937.6491-1-yee.lee@mediatek.com>
From: Yee Lee <yee.lee@mediatek.com>
Use MEMBLOCK_ALLOC_NOLEAKTRACE to skip kmemleak registration when
the kfence pool is allocated from memblock. And the kmemleak_free
later can be removed too.
Signed-off-by: Yee Lee <yee.lee@mediatek.com>
---
mm/kfence/core.c | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/mm/kfence/core.c b/mm/kfence/core.c
index 4e7cd4c8e687..0d33d83f5244 100644
--- a/mm/kfence/core.c
+++ b/mm/kfence/core.c
@@ -600,14 +600,6 @@ static unsigned long kfence_init_pool(void)
addr += 2 * PAGE_SIZE;
}
- /*
- * The pool is live and will never be deallocated from this point on.
- * Remove the pool object from the kmemleak object tree, as it would
- * otherwise overlap with allocations returned by kfence_alloc(), which
- * are registered with kmemleak through the slab post-alloc hook.
- */
- kmemleak_free(__kfence_pool);
-
return 0;
}
@@ -831,8 +823,14 @@ void __init kfence_alloc_pool(void)
{
if (!kfence_sample_interval)
return;
-
- __kfence_pool = memblock_alloc(KFENCE_POOL_SIZE, PAGE_SIZE);
+ /*
+ * The pool is live and will never be deallocated from this point on.
+ * Skip the pool object from the kmemleak object allocation, as it would
+ * otherwise overlap with allocations returned by kfence_alloc(), which
+ * are registered with kmemleak through the slab post-alloc hook.
+ */
+ __kfence_pool = memblock_alloc_try_nid(KFENCE_POOL_SIZE, PAGE_SIZE,
+ MEMBLOCK_LOW_LIMIT, MEMBLOCK_ALLOC_NOLEAKTRACE, NUMA_NO_NODE);
if (!__kfence_pool)
pr_err("failed to allocate pool\n");
--
2.18.0
next parent reply other threads:[~2022-06-23 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220623111937.6491-1-yee.lee@mediatek.com>
2022-06-23 11:19 ` yee.lee [this message]
2022-06-23 11:59 ` Marco Elver
2022-06-24 8:20 ` Yee Lee
2022-06-24 8:28 ` Marco Elver
2022-06-28 6:40 ` Yee Lee
2022-06-28 7:25 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623111937.6491-2-yee.lee@mediatek.com \
--to=yee.lee@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox