From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB4CC43334 for ; Thu, 23 Jun 2022 03:20:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D521C8E0116; Wed, 22 Jun 2022 23:20:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD95D8E0115; Wed, 22 Jun 2022 23:20:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52508E0116; Wed, 22 Jun 2022 23:20:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9F3518E0115 for ; Wed, 22 Jun 2022 23:20:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 71A08214AD for ; Thu, 23 Jun 2022 03:20:01 +0000 (UTC) X-FDA: 79608046602.08.D4A79B5 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 2289218001F for ; Thu, 23 Jun 2022 03:20:00 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id a2so31082242lfg.5 for ; Wed, 22 Jun 2022 20:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=79v4g22d06dNQZx4XHZ3GsOIEc9zd0ggEjlq0srZKG4=; b=yrsZPHDCD9chqAOlK2aqkVDJbj4YlJK6Y1EmWC+AJelEirjFWQUhgxYZMRsapycCqT d9/sLvLnS2eOJcmjMAuTeVD27TGKvpamgOwFcYRj+mGYSFBLSmmSZXaBDE3SUZrHdL4+ FNKvpXkRR1rlHo31238gF7oFTd6tugL+1j7VQ+5hZp3rK1Cgd3ZlEW1LGNL2qd2hO57J f/U0Jm7N2a2hUqpnKo8G4S1bfKfvBcNMD5a0B4I3FxQhigqDWQC/ibhSOKDneB2pXxZy tsvE9GxQXcHN3mCLB7R+5Pyv0PcHex0LGIVYsDNyVT5tKveqtjo8SRBsf4cRYjPoTNFQ Gh6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=79v4g22d06dNQZx4XHZ3GsOIEc9zd0ggEjlq0srZKG4=; b=JWwsSY4EArkinSe3E7KXQW7lZgFjMQimr5DrGqiYkgdks8SiodXsXZbW+erz0PPJWJ WdcJ1CY8xnY7h+NQ/t1M7aC2NeCZWjuIt/x89zroDOlMu7mc9BcQecMpraMDH0xnLW/Q CPQKlN49z1S3PVASVe1EmkHnbToq4V3NcXNaNWPrqMd/gGKWBBOf7XYdNFbffwI6FSVN Hi68/1UeV/oy1fn8coFFM0CYJOyyrWPhUI2PobBiNn3E/5y4WdOpZdPRkkFaP/Vmeea4 VUwhcfHaxjY5jSnq1WbLFi+ni8SwOIJX5F6DJS0dScK+WTW5MxTeEdt/ws/TZWlS0FdZ T23w== X-Gm-Message-State: AJIora+3b2pOoNqCIG7ClqHfV/B6o1MLsXErP0VjVfRovhzSdRTswylO UKqiRvp/Ms9GN2gUy5+dcn5Ixw== X-Google-Smtp-Source: AGRyM1sjcA+kIxAhm99wkWCmSIHuz3qmOx9TGh1uQ8/3JNaPFYlfZzhiTm1Jt9n2Mty+3YUw6m9sLw== X-Received: by 2002:ac2:598b:0:b0:47f:9bf4:975a with SMTP id w11-20020ac2598b000000b0047f9bf4975amr3371926lfn.216.1655954399548; Wed, 22 Jun 2022 20:19:59 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s9-20020a056512214900b004790b5a0b22sm2799796lfr.239.2022.06.22.20.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 20:19:58 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 8F928104A32; Thu, 23 Jun 2022 06:22:11 +0300 (+03) Date: Thu, 23 Jun 2022 06:22:11 +0300 From: "Kirill A. Shutemov" To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/16] mm/huge_memory: minor cleanup for split_huge_pages_pid Message-ID: <20220623032211.rvrtlas25u7nddpt@box.shutemov.name> References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-8-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622170627.19786-8-linmiaohe@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655954401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79v4g22d06dNQZx4XHZ3GsOIEc9zd0ggEjlq0srZKG4=; b=W/TyKGN2la9FwKn7mC2vek6ZiWkEilVvOmjOfNMJXg5zV5WVd1XjwRfeOJnSmgGoS5W/NL rHYHF1mFB/TysbTvTP7stBGiCZ4U6QA+ma1sZTN41Io/Ns0aWPw6qvhdYT6jy2INUwktPy qD7yBs/pglbKbRFeo4v70Z0f2yiw0KU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655954401; a=rsa-sha256; cv=none; b=fpzOAc1tBZaTZ8PM8Efe178/P1Dm1S9sKPNITHGZw3jrWa8UuZm0TZoyCRYwBSzBgQUmHQ mVFlUKI3+cA8S9vFVu5tHFIH+7urklUpLnNghjlISKMUgwzBPzVxJwdQYZTTPXlf8vpyFH a5D+drPivmr3TkKXctfyDh+f5dAaq0I= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=yrsZPHDC; dmarc=none; spf=none (imf16.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.43) smtp.mailfrom=kirill@shutemov.name X-Stat-Signature: 19a8apanynrmt7sbtgirzi7arwiiuf13 X-Rspamd-Queue-Id: 2289218001F Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=yrsZPHDC; dmarc=none; spf=none (imf16.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.43) smtp.mailfrom=kirill@shutemov.name X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1655954400-407273 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 23, 2022 at 01:06:18AM +0800, Miaohe Lin wrote: > Use helper function vma_lookup to lookup the needed vma and use help macro > IS_ERR_OR_NULL to check the validity of page to simplify the code. Minor > readability improvement. Grouping of changing seems random, but okay. -- Kirill A. Shutemov