From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFAB1C433EF for ; Wed, 22 Jun 2022 12:52:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE0D36B0152; Wed, 22 Jun 2022 08:52:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D90AB6B0153; Wed, 22 Jun 2022 08:52:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE2AA8E00AB; Wed, 22 Jun 2022 08:52:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B03C86B0152 for ; Wed, 22 Jun 2022 08:52:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id F28D9120FDF for ; Wed, 22 Jun 2022 12:52:45 +0000 (UTC) X-FDA: 79605861090.13.C6DCB42 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf27.hostedemail.com (Postfix) with ESMTP id 633DA400A9 for ; Wed, 22 Jun 2022 12:52:40 +0000 (UTC) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25MCXq08021387 for ; Wed, 22 Jun 2022 12:52:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=b9WZnR8D3ZoECoQvReXmfgMunanenBgX2uBSRbXCfd4=; b=RSuo21782mpRMk1XC27VIK8ue1W0iOTUs0ieBknLh35evP4+YqMyMEq8X5pyKGslo8ct /59xO6XA7iaIXQOM+EgiwKbbsTi2jfRIAkhokMsNy9vfkJ4rKn4WToe4bOjx/cWubjvC OM6lLPh5/AcvGxzHxH6/HuC9kA0ZWpthFB3Mac/REqtxfzVy5pk1nZU6bgIaCtctNjaE R4uXY26BkVrLqTfQ107x8MMMmJEbcRR3g+UPO1wuiN8GsEkoJiGxpO7W+QCNbYDTknH+ 7EFU4hna6bK1rJUGdz7ijetLlS3Oxsc1QiBidY8K5iR95/49fGVZ5iWhxZ0fESrOqWQy ig== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3gs6at0daa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 22 Jun 2022 12:52:24 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 25MCkpNs009080 for ; Wed, 22 Jun 2022 12:52:23 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3gtg5vf1aq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 22 Jun 2022 12:52:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DlZs77dAiP6oV4QOphYBcFLvn1p6Vx4R+wZ+21O6sLgZxpDUEIgWiXDLgJ13Bp3vU7P3fo26Dn41BiumpUZzXMTM8kBiefDn4dCKjWm4niaI2k2hCrTzmYW/i/9MvryrvyrLE6IVCL6Sarwp6PP7G/1G5z0T6T04Cy1dl0xghw2uabBGnGmwGqVbA5+DRCkElElFmFEdTAiwb7id/6LBoBsBxfI/syiX0H5jmYtAWmnT3pVYKxtQNjLSsxA6q4mfCDuBsgrxPkDgidwU0k9Mt6kY9Xvth88Mis+K0XkRitTlTt/mfPq9ShzEuS9fWJD4laiGg64s9xc8Zf4yerv/uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b9WZnR8D3ZoECoQvReXmfgMunanenBgX2uBSRbXCfd4=; b=lKNaiu8CHgk4fUYZhSctDwnTNvr9o2Ix5/F0HjjbQA3eNoay59bCDJJvtz2KCXCE+Jw2tv8NfdHLQSXqIdlRO7xy4W4P5uEXA8NE15BtGjh1f6qadepunbsEJoV/B4fd3tQ+5mtVSh9D8fisCKOZY73kQvT6s00+4zLnsJD39cvQCllNxt/itCOB5mLpsf8YiatQ8FgBH7rFkZpQfvg9/0V1qD8kL9k5V4jisNr3+LleYddixPk4vuWBjetZZiqOntfcF7XEZ4UIB2qN1oIe2Be2b+g/FVwC7P1ACrdxgeFOV/3oX/khvnH0QVKtXTsZ2OOwhBkEppwj6/c0S5/VCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b9WZnR8D3ZoECoQvReXmfgMunanenBgX2uBSRbXCfd4=; b=ZpxeNpfhsbIIaw/T5grqZTHMda/CPyX6B2M0zYVSzUhLgvHj4u5hNQYnaKX16F3ujSs6k8N9XbL1A8ZgnIHpR5VVIpI7vA9Zy9ek03p3vNklz4bn+sAStzvbXEj0hYl/5TS3SXivmQZX47fgbmveg4dXat6u/XJB97n0d/HcFzM= Received: from BL0PR10MB3011.namprd10.prod.outlook.com (2603:10b6:208:7e::29) by MN2PR10MB4080.namprd10.prod.outlook.com (2603:10b6:208:185::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Wed, 22 Jun 2022 12:52:22 +0000 Received: from BL0PR10MB3011.namprd10.prod.outlook.com ([fe80::93b:a436:97d7:4697]) by BL0PR10MB3011.namprd10.prod.outlook.com ([fe80::93b:a436:97d7:4697%6]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 12:52:21 +0000 From: Liam Howlett To: Dan Carpenter CC: "linux-mm@kvack.org" Subject: Re: [bug report] mm/mmap: change do_mas_align_munmap() to avoid preallocations for sidetree Thread-Topic: [bug report] mm/mmap: change do_mas_align_munmap() to avoid preallocations for sidetree Thread-Index: AQHYhgWb0a+ZlMKZ1E2dt0irx4K/yK1bYcCA Date: Wed, 22 Jun 2022 12:52:21 +0000 Message-ID: <20220622125215.3opkqcfbdcziuo5r@revolver> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0637f2d2-f132-4e66-c26e-08da544e0c47 x-ms-traffictypediagnostic: MN2PR10MB4080:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /N/TskgTkMgTG/VSyljK1TBv9fjfp59Fv6a7P70zSfKeARSg4dt9R2fOadAHKVQk48SPNgl+sNa7zy9IJb4/T6ZZ2cx/NlS9ZFVA8XWVUyT+v2qEb5n7OTtROCli73DBZbmD72max7s6xYo/5VPd9fsfjBGNd8g/9xAuHspo36k/1EK9Wy+y5CTZsz65rJmg/moyE576IVBqsT0hgZSiDoXWIEXnkSw0j83rUDw2omJvrcQG9UGbvfdCHb+FbzovoIMaYbaY9lkVAfGdvOEqxoH9qmHjqeyvZzFRWLJ8rhepw2zAe0PiZr3xpGbrYPvdrnVM7R8Iy8DqYYSvuFKsiV34wveCi99D2Ro7KtVVJ8HXIkXmhZfnBcfHPO8copR38jPXFs7iMmLSrJfNCXVR+FN0qxeUuTG4IhQbmugeSFbjwIVWzGnJDt8/+pHZJJ8asHXa2kAQp5aoyVheUvCSU79K9WHgKHapuMmWMggnyBV29k/vd69TrXkbS2Ya+CUmyoNOg+xNkwSr5lAhnFxxOFJKexhAIjU/qKhgHT3gWEA0g0VfBQDEPel2hfqtQgrekSeKW1nV+VP74lFKCpIaJxapya+HWA6oTraPO7Hbr/dGtlGfjnhCjDOcRu8pCbDeV3NcIk3h2144ipMzZRVXLU0m1EBDNmtsP2CVr708usdJhCJO48p59+noHozrKbQJc8EHvDd71YhmxfHjCl6gm/J+k7h6pJLxHA2B4zc1FNPiBxfoXZWNlWuxfpGThYzR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR10MB3011.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(366004)(39860400002)(346002)(136003)(396003)(376002)(26005)(6512007)(478600001)(6506007)(2906002)(9686003)(6486002)(41300700001)(83380400001)(5660300002)(4744005)(33716001)(186003)(1076003)(44832011)(64756008)(38070700005)(91956017)(8936002)(8676002)(66476007)(4326008)(6862004)(66946007)(316002)(71200400001)(6636002)(122000001)(76116006)(66556008)(86362001)(38100700002)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ED9Vujx84Gi8ot6M7mtc6hbj0bMZnini8d0+AtveBkQmkfFnYdTSecNqr3ez?= =?us-ascii?Q?b2bec6M/zSaLjYaz3Az7IKV/FRWB1Npp7Ka5INyUaP9wWEen6lmr7IZcIndO?= =?us-ascii?Q?Mliqdo81bEfnYlLOFxuDhahYJ6qszlXsiLQceWxK3Byyk5RlI+T5m6O4YTXy?= =?us-ascii?Q?FxISm9RVvy7W2vdEOeFO3P7XGo7MZypEjk8RHc8ZDovbk6QasjSrazPVMuxJ?= =?us-ascii?Q?sl7wDJdDZV7qO1INm19BIBappH1EQ61tAnKE4FLcWnwlLk/d+N8pv+b7Eq/H?= =?us-ascii?Q?oVDrmKsROh+wsd444Z9LJy8r+Wgwb9BGRj2DMgJj6h7yo39QGhfTG4E01eBr?= =?us-ascii?Q?KdW0mspZxUrUAcHtja+VXekO+A2rJRAp4pJx9oYfsKOxFNTKxYNur3NKgBMr?= =?us-ascii?Q?9L5DBDTMJ/9YWUtPHYbZJB6H2enUbro/pgqwej3Sf9PW0YEAy/UuB+dZqUY4?= =?us-ascii?Q?udgJzIP8UbenQplKU2eoXtdY6RmB7RAQ+oSC9/RaA7VX7axedxJ70LowyiQ5?= =?us-ascii?Q?aTvk+/nhSvvM2Wr4u/zg2kt2G8/PcJe+LviBbCizcnmUz6ZmgsmLLFYCs8Ty?= =?us-ascii?Q?70qmPMJO3sdENRBdhEfJhS3CV1b81hkqOEUEs6mUKX8VesPgmCu6K6XbrN9i?= =?us-ascii?Q?P9hLtU4WX08EFgjJoq6/2HYdW4uyrQ1cSVhPa7pKcuOPFfYyrV85BkllLPAX?= =?us-ascii?Q?N2hrkq9oDbex5WAhuIzRLa1nmhgjQLLROCrZNmMoRjShin5B8Fs9bNAAPfYj?= =?us-ascii?Q?Yi2sUX84DIsX5ywoNSvnbGeMT6Mw9NJQWS1hPxuyb8jteypfu5/r7r+WphcH?= =?us-ascii?Q?ySYgxFnML/0FJqJprG9y2CSxQ6c72rN/M4A2sYUXviZ1S16qcthWWs1gbtY5?= =?us-ascii?Q?zFMaUiUKNXI/LUbh14f7OdAwJAGvo7zpeLyVTLa4FY1tCiohScKa/rZ3+H53?= =?us-ascii?Q?LLaCQLiTG1LuyTSSMiWTd32/7JwZBPOALlZfjC7eHZxfdoeJAbGeyfb3UzKV?= =?us-ascii?Q?3ZuDR/CHqY8sLWvA+VmkjNJY2n+PYresKH5QVkYXIPQ3Df/EuJBWsKa3uMpF?= =?us-ascii?Q?LWQCGFaCJA30tkK6a2bA8l2tpVFUNqc25FRUc73UXT0DE4dQHrNdL7SqXkKv?= =?us-ascii?Q?osNKDShAO5vshLSoYDpQ8Zl6eg5zyW7MxOz2aOvNcttzoB/tx54V4hnScYKZ?= =?us-ascii?Q?JwgRAFMo/xV1m+7VP0sNxT04myPCZ56wdJHpbLrUlB19LExEfyZx0bUTL1Mc?= =?us-ascii?Q?OqkJew5fvXyKWLRuSF985yzoamr/yz3cwV8GP7Ti0OfaGG8LJ/D+sl3eFIkN?= =?us-ascii?Q?S3Z9KxHZv3SH+aC+UzsHwR29+ASkZgDTzK4Ec2nLOKeDKVzqzeKer26zfx5y?= =?us-ascii?Q?tUN7inEGH456Qm2tB53Q8obHlplMCgiiPHszd587wcMBQGgwe5GUHy1N+8S3?= =?us-ascii?Q?ZEISzK4or8xKGtx/tyJYlu50mS9Z/Y2V0jjC8Oo4u9D9hg0x+x2eikC1Vvf7?= =?us-ascii?Q?ic7B7+6AGOkVhwUSph9i9d001639nswWo9Dv258ABmlc8SJtvHd13kh1uw6w?= =?us-ascii?Q?YZWyCUqLz/9EU8rRB8CEv/iNeCXSb+b9f/TPEg2+KuW31DIv+iBdtu0D+8kn?= =?us-ascii?Q?eIBelyBX+i9iTHvl7GLA9z84zQyn4CAHgXft/NhPwoP7ovqt+ml9sDtUbH7R?= =?us-ascii?Q?nSzEOLtGzb/oC7AhW0OZ2kOwOPD0OCZXG6UZDCkzADbz8tPtAJ8/WClqDOlf?= =?us-ascii?Q?miY7yjM7eFIs5uaMRKYaA2ghAHWGApU=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR10MB3011.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0637f2d2-f132-4e66-c26e-08da544e0c47 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2022 12:52:21.6089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zno2Yjuvt2JZSef3H6FWDNuOgf3I1qiFjhf3pH+4ix5ICowMnLi4hQN7VQynbvG1Gc7RthprvyW0HlFGoVYNRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4080 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-06-22_04:2022-06-22,2022-06-22 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxlogscore=922 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206220065 X-Proofpoint-ORIG-GUID: u4nc-wvZXhQ0jRT3QEfNMKj8HBzIBovk X-Proofpoint-GUID: u4nc-wvZXhQ0jRT3QEfNMKj8HBzIBovk ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=RSuo2178; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZpxeNpfh; spf=none (imf27.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655902360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b9WZnR8D3ZoECoQvReXmfgMunanenBgX2uBSRbXCfd4=; b=NGuH9guPpFBMmsTZdiQs8aLInVDRkKIJqd9mt5UjOJIJag0TqBeb0SceXthrcBRO24HeYC ISl4LJLbfKrxkbAun0VZOaBsBzityBdOviUDVNuMFZd9Y7SMq2rbWAf+2m/42wJEDzX/to pF1VVdB1KLPHysAHq7QxedNW2ou4GUM= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1655902360; a=rsa-sha256; cv=pass; b=ddULeTu/cTdI03l+GXP1F6fSoS8C/zdU7D8OEOxJdNp05CG8we8Y4/tidLksYotKeAvuZf hA4KWMBRKW9cf33iN2CRrwvX+0b7q4+CEK6omx6bWKrzT+fSQMsLCdChpZA6s4vAXbCX8P GRT1+UcgMamSnWeXSPPhKkH6ZpB54FI= X-Stat-Signature: 6xrjhci91mbccggtuft9bbftr3j65733 X-Rspam-User: X-Rspamd-Server: rspam07 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=RSuo2178; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=ZpxeNpfh; spf=none (imf27.hostedemail.com: domain of liam.howlett@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") X-Rspamd-Queue-Id: 633DA400A9 X-HE-Tag: 1655902360-944157 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Dan Carpenter [220622 02:59]: > Hello Liam Howlett, >=20 > The patch fecd1f7f7502: "mm/mmap: change do_mas_align_munmap() to > avoid preallocations for sidetree" from Jun 17, 2022, leads to the > following Smatch static checker warning: >=20 > mm/mmap.c:2431 do_mas_align_munmap() > warn: missing error code here? 'munmap_sidetree()' failed. 'error' =3D '= 0' >=20 ... > 2423=20 > 2424 error =3D __split_vma(mm, next, end, 1); > 2425 if (error) > 2426 goto end_split_failed; > 2427=20 > 2428 mas_set(mas, end); > 2429 split =3D mas_prev(mas, 0); > 2430 if (munmap_sidetree(split, &mas_detach)) > --> 2431 goto munmap_sidetree_failed; >=20 > Need "error =3D -ENOMEM;" >=20 > 2432=20 > 2433 count++; > 2434 if (vma =3D=3D next) > 2435 vma =3D split; > 2436 break; > 2437 } > 2438 if (munmap_sidetree(next, &mas_detach)) > 2439 goto munmap_sidetree_failed; >=20 > Here too. Yes, you are correct. Thanks, Liam=