Re: [bug report] mm/mmap: change do_mas_align_munmap() to avoid preallocations for sidetree

[Liam Howlett <liam.howlett@oracle.com>]

* Dan Carpenter <dan.carpenter@oracle.com> [220622 02:59]:
> Hello Liam Howlett,
> 
> The patch fecd1f7f7502: "mm/mmap: change do_mas_align_munmap() to
> avoid preallocations for sidetree" from Jun 17, 2022, leads to the
> following Smatch static checker warning:
> 
> 	mm/mmap.c:2431 do_mas_align_munmap()
> 	warn: missing error code here? 'munmap_sidetree()' failed. 'error' = '0'
> 
...

>     2423 
>     2424                         error = __split_vma(mm, next, end, 1);
>     2425                         if (error)
>     2426                                 goto end_split_failed;
>     2427 
>     2428                         mas_set(mas, end);
>     2429                         split = mas_prev(mas, 0);
>     2430                         if (munmap_sidetree(split, &mas_detach))
> --> 2431                                 goto munmap_sidetree_failed;
> 
> Need "error = -ENOMEM;"
> 
>     2432 
>     2433                         count++;
>     2434                         if (vma == next)
>     2435                                 vma = split;
>     2436                         break;
>     2437                 }
>     2438                 if (munmap_sidetree(next, &mas_detach))
>     2439                         goto munmap_sidetree_failed;
> 
> Here too.

Yes, you are correct.

Thanks,
Liam