linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Zhipeng Shi <zhipeng.shi0@gmail.com>
To: linux-mm@kvack.org, linux-rt-users@vger.kernel.org
Cc: tglx@linutronix.de, shengjian.xu@horizon.ai, schspa@gmail.com
Subject: [Question] vmalloc latency in RT-Linux
Date: Tue, 21 Jun 2022 20:15:47 +0800	[thread overview]
Message-ID: <20220621121547.GB37196@ubuntu20> (raw)

I noticed in rt-linux, vmalloc has a large latency. This is because the 
free_vmap_area_lock is held for a long time in the function  
__purge_vmap_area_lazy. 

In non-RT-Linux, because the function spin_is_contended is well 
implemented, so there will be no such problem.

But in RT-Linux, spin_is_contended simply returns 0. I don't understand 
why this function was implemented like this before, but in order to
solve this problem, I thought of two ways.

The first is to modify the spin_is_contended definition in spinlock_rt.h 
as shown below, but I'm not sure if the change has side-effects:

-#define spin_is_contended(lock)    (((void)(lock), 0))
+static inline int spin_is_contended(spinlock_t *lock)
+{
+ unsigned long *p = (unsigned long *) &lock->lock.owner;
+
+ return (READ_ONCE(*p) & RT_MUTEX_HAS_WAITERS);
+}

The second is by reducing the number of lazy_max_pages, but it will lead 
to lower performance of vmalloc.

Guys, Do you have any good ideas?

Best regards,
Zhipeng


             reply	other threads:[~2022-06-21 12:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21 12:15 Zhipeng Shi [this message]
2022-06-23 10:51 ` Baoquan He
2022-06-23 18:04   ` Waiman Long
2022-06-24  2:39     ` Baoquan He
2022-06-24  5:56       ` Zhipeng Shi
2022-06-24  6:46       ` Sebastian Andrzej Siewior
2022-06-25  2:27         ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621121547.GB37196@ubuntu20 \
    --to=zhipeng.shi0@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=schspa@gmail.com \
    --cc=shengjian.xu@horizon.ai \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox