From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE72C433EF for ; Tue, 21 Jun 2022 07:52:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C6CD6B0072; Tue, 21 Jun 2022 03:52:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 276636B007B; Tue, 21 Jun 2022 03:52:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13E736B007D; Tue, 21 Jun 2022 03:52:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0325B6B0072 for ; Tue, 21 Jun 2022 03:52:26 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CCBEA61123 for ; Tue, 21 Jun 2022 07:52:25 +0000 (UTC) X-FDA: 79601475450.21.1F8CF40 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf15.hostedemail.com (Postfix) with ESMTP id 845CDA0012 for ; Tue, 21 Jun 2022 07:52:25 +0000 (UTC) Received: by mail-qv1-f41.google.com with SMTP id y14so13897918qvs.10 for ; Tue, 21 Jun 2022 00:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g9k1mThYScIf9A8X5kP43MLMYKCbH4t5dz1jSbySjwE=; b=l5HiTUmI2JUEzJjhrUuq9RgwOOdemlWj2crpupJB8TUxFRp//h5bJDRus8P+fXp/yK N3Euxma5PIExGPbNR8xbsQMDbigXcRNK6Fjv1vIDlvZEZyQ2Ex3EJ5JX3DezkUhjIG42 KT+z6Xn5dmORbcgX0/3QL6tPBzQKddiImkKnmV47+2gLy7/bP3IazmYyNIunej4Rugvb oEmhFkBzHXcphWon9RykZMATfy0qtCxRZ5i+bskVddoHBr5VwLYDBJK03LbbceK46P11 49tJQgM5o5bkfzANgtgjFCeb4dWxDrNNXynKRg0z+n8u1k4XTpIFHRsH77WOHXMVQFmI Yg7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g9k1mThYScIf9A8X5kP43MLMYKCbH4t5dz1jSbySjwE=; b=AX5y2kmkErjBkjERMBsbPDk6HMC6JOGLWd7AN+iyi0c4vZXjaX9XnhyanQUjTGq/E2 89qrY2OJUaGAIJ3F0HB5DejT/2hMBNszc+gsB4+GDgkjORIucm4TGhgYfZoTRfepK/Jw W8X7onkW7hQow8sAaXqBhvHCNYF85m4EGHGt7lVLQFFNc4MRgBMI4jvibSGAsxwzu7x2 6s+kEQ/mpWH0v+VDDQyvFc0hIr8At33n/L5SQydTFT8wtZBBMovCcHPF9QDZtGvnPLxh iE8mFqBnN4BqNjzl0M35CUl1Lnft3keiDKlezlZj2+I0G0bbc6YrPvu+AxJHhf1klm37 4QIA== X-Gm-Message-State: AJIora+Q5e3X72SD8cXDkCNvNnKZzjIVdr+Kxd7R0M2wXnU4JTqsDcZq MVS04NKUxGkfsmSyJe7PhtUmbtqBLrTUcWvqCg== X-Google-Smtp-Source: AGRyM1u23QhEKWlxDri4U4bL6I/zAwKZbFgPfNf8rArvK8DElQyjUq4DyhWWlWvGazGD2PkS+RFFQQ== X-Received: by 2002:a05:6214:21e6:b0:46e:4f35:b07c with SMTP id p6-20020a05621421e600b0046e4f35b07cmr22241046qvj.12.1655797944888; Tue, 21 Jun 2022 00:52:24 -0700 (PDT) Received: from localhost (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id j6-20020a05620a410600b006a6d3a6d597sm14563997qko.71.2022.06.21.00.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 00:52:24 -0700 (PDT) Date: Tue, 21 Jun 2022 03:52:23 -0400 From: Kent Overstreet To: Rasmus Villemoes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com, rostedt@goodmis.org, enozhatsky@chromium.org, willy@infradead.org Subject: Re: [PATCH v4 13/34] test_printf: Drop requirement that sprintf not write past nul Message-ID: <20220621075223.qpiatsusjbu6zj7a@moria.home.lan> References: <20220620004233.3805-1-kent.overstreet@gmail.com> <20220620004233.3805-14-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l5HiTUmI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655797945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g9k1mThYScIf9A8X5kP43MLMYKCbH4t5dz1jSbySjwE=; b=q1ANJe7OvIY9a8xm5F8WyeIVVFufqTLtajkwy1HKN7LSFy8gmVXbZLx6Bw1+hIqTCIVIJ3 96GQEKEjoYch4JP1DcsOdauXxle4kk9xp6sEbMaJXgsQ7oKdQjkgONamBjx3a71FMbRZsM wqB3xv3NZrOvs2UOWnVc3OtZOpOeL6g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655797945; a=rsa-sha256; cv=none; b=WUvzfLiD08g3d1nPPKCtqW7BSk9BuJDR0v7lB8gC1zF5aODyXeFbA/Hfw5+wTeBK7uVEq2 l6zTcreK8x3HEpFF0Jrz53/rea14L0whWr3cZ/SgEL8tTxOnsvmiLLt37dHG70lq8jQ7IU OzfiG0+4hmOEsmJgUq3BxVNKd9R8fY0= X-Rspamd-Queue-Id: 845CDA0012 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l5HiTUmI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 66dfx6ykzzndu6ct4kze7e9tbnaqaxyk X-HE-Tag: 1655797945-437966 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 21, 2022 at 09:19:55AM +0200, Rasmus Villemoes wrote: > On 20/06/2022 02.42, Kent Overstreet wrote: > > The current test code checks that sprintf never writes past the > > terminating nul. This is a rather strange requirement, completely > > separate from writing past the end of the buffer, which of course we > > can't do > > And which of course you don't check anymore. So any statement about "all > tests passing after these patches" is not worth much. > > So NAK in this form, but perhaps if/when my year-old patch gets picked > up (or you could include it in the series) we can talk about eliminating > the check for past-nul-before-end-of-buffer writes. I'm more than happy to pick up your patch, please send it to me.