From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D69C43334 for ; Mon, 20 Jun 2022 17:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C80DF6B0071; Mon, 20 Jun 2022 13:27:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F936B0073; Mon, 20 Jun 2022 13:27:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF6F96B0074; Mon, 20 Jun 2022 13:27:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9DEE86B0071 for ; Mon, 20 Jun 2022 13:27:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 60AD120FB0 for ; Mon, 20 Jun 2022 17:27:52 +0000 (UTC) X-FDA: 79599296784.02.5190147 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id F242418001B for ; Mon, 20 Jun 2022 17:27:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D0296614FF; Mon, 20 Jun 2022 17:27:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48CB1C3411B; Mon, 20 Jun 2022 17:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655746070; bh=G5GtmLDra6Mj3BFy+b9Vvm7SvXbbbJSxaIQXBk1cDAA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L+EiA5KkFCe1Sr4egatDOyVsNe3RL7c+F91ZXFwhvRjmLyif12dAtV8wozFeolfw6 pdvqIMIhuN3NQaLBGskji+x9/JP9kTFmCJgFm1NovISDvUlpnMJVO0e8hRiS56CG95 fv3kgo8fmdjlWLNJlHwdQRWE2YZG1emH0kCvivButPjGoxTslZk8azvrOfkbZrLvEC iL/NiILWy0zfSNJhhRUNQ9sSocCTbADvJVC4tIEUoweGOe5LEyPOC9efCqg4G93cWk hMNhuJojWmMvN8QObiUlkGM9WGtr+NHfPLi/m1G2GrwrVnlNMdjqrLu3vcLHTgEjLK 5ITAO/4gGhkbw== From: SeongJae Park To: Baolin Wang Cc: sj@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, songmuchun@bytedance.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old Date: Mon, 20 Jun 2022 17:27:42 +0000 Message-Id: <20220620172742.48766-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <1655692482-28797-1-git-send-email-baolin.wang@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=L+EiA5Kk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655746072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u97Va89s8wJIWqJZYsZWtFZO98byKWrG4djcp/KHNHQ=; b=2oY5DTtqIkNf7HB7CskaYgkgO/TMcq3HFsDcEN51neKndCtVAnd+WAMiJQmFb6B/8EeZtm kf0ZoQo1ZqvfIN8fG3PE2IfolC2/VlK6JPbrjf6l3oMJWs2uCLptNHRx0Yw8R0Kh8rncX9 wXUHmdlp/IkiVIcvk+cg88roFeY97V4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655746072; a=rsa-sha256; cv=none; b=17oFyXBOWbs/bXx+7dN9Ov7z2YMrXtS4jSifHtTT6CBY0hdvj0QDWBgmP44gfVGN11SF4J uyDETxdbHkgX3kyN73y3dLLVLmKQVLVEXoL15WgJlQRigowDZXCt4iXBe8sXrghXUIoe3L Q2Q54YxL/Ak68p5O/chpuQECMCnvm38= X-Stat-Signature: y1q9zbxc9d9dz43zra1wrz36cfbhyjfy X-Rspamd-Queue-Id: F242418001B X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=L+EiA5Kk; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org X-Rspamd-Server: rspam10 X-HE-Tag: 1655746071-221837 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Baolin, On Mon, 20 Jun 2022 10:34:42 +0800 Baolin Wang wrote: > The huge_ptep_set_access_flags() can not make the huge pte old according > to the discussion [1], that means we will always mornitor the young state > of the hugetlb though we stopped accessing the hugetlb, as a result DAMON > will get inaccurate accessing statistics. > > So changing to use set_huge_pte_at() to make the huge pte old to fix this > issue. > > [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@arm.com/ > > Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages") As the commit has merged in from v5.17, I guess it would be better to do below? Cc: > Signed-off-by: Baolin Wang Other than that, Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/vaddr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 5767be72c181..d24148a8149f 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -337,8 +337,7 @@ static void damon_hugetlb_mkold(pte_t *pte, struct mm_struct *mm, > if (pte_young(entry)) { > referenced = true; > entry = pte_mkold(entry); > - huge_ptep_set_access_flags(vma, addr, pte, entry, > - vma->vm_flags & VM_WRITE); > + set_huge_pte_at(mm, addr, pte, entry); > } > > #ifdef CONFIG_MMU_NOTIFIER > -- > 2.27.0