From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15FB7C433EF for ; Mon, 20 Jun 2022 07:15:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D93F6B0071; Mon, 20 Jun 2022 03:15:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 889928E0001; Mon, 20 Jun 2022 03:15:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752936B0074; Mon, 20 Jun 2022 03:15:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64C756B0071 for ; Mon, 20 Jun 2022 03:15:34 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 4382A80583 for ; Mon, 20 Jun 2022 07:15:34 +0000 (UTC) X-FDA: 79597753788.08.DBB481B Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 4494F18000F for ; Mon, 20 Jun 2022 07:15:32 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id i15so8959626plr.1 for ; Mon, 20 Jun 2022 00:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gs-ncku-edu-tw.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0mOlgPiY8NctsBbPdtFtolqRiB7asIJTPtqqPiH8p+8=; b=NGhtV6oC7UGeJmGoCzKkFK166pwQEvMLVC/dCGikhg6ACgcA/WW/z4uqE1RfxWK9xl GXVg/NlBjL6gdKDROMZrmkw+GzhA8RwfeT4tzRtIlYU0qnHWVTVjdOceiOlo9Kvxbcyy p1HH7GCjnwl6ON0TaZCY9mWXn4f5NAa4U8t+BZCTrocYTba1B+gOaccMIjKRe4ZqNPdc aFdD19PlV9YmQnxyBP0ZTxZkV5QmBwfWaFM/PPLayRp87xmGuGzpGZRcNrOHjWQeKDqL Yh3r6EziufF6Q/gGFYSp3jXSdpTD9jrUjc+bBjs9ys8zgDGsDv2reGhK7yE9LqDG7MRn +zGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0mOlgPiY8NctsBbPdtFtolqRiB7asIJTPtqqPiH8p+8=; b=uCbHGIHUg95ZYs12+sd19Exmzg8AlooCVEklj3078I5FL+oM6HGv5bAw4WIq1BZMRC czKF6lsovKsXUJJgiEnWupz8N02fHCA7JPPTUQEMv2aZVffQ3Y35848i3rptN+OmnLyf hFXTAtuK6KyvdmaPPS7Pd4iR99IH7hQdYgeVN0eDEK+tbibYAjlIjNR7k/JvKQlnAmXM YeC3A9P+qI8dEJEWD0FtBSdxSIm408LLV+ow+fkbNIlGs9K5rvytql3E2soaSNBUJmLI M18WGC8ydu70LAxXy4uO/qg3Jg4wbn9o6PhwYKsAbj1TLHFW+I3jLnsaU9bDgzorOUDM qNOA== X-Gm-Message-State: AJIora/4HPKe9ony0Zurs0RwD3rHmXi7fi/KUvSfnR4bqW1ECNY1Svd1 AVq9HmFG+6jpSEW5GaVnMgij4A== X-Google-Smtp-Source: AGRyM1s3VSa9NaclVivzLgd4xlgsfqOrZGqTr+nFoV4u9Jf+n7sK3ZiPLBzLkiGfZL1yRMOJhzZTTw== X-Received: by 2002:a17:90a:df91:b0:1e3:4dc8:46e7 with SMTP id p17-20020a17090adf9100b001e34dc846e7mr36092979pjv.106.1655709330826; Mon, 20 Jun 2022 00:15:30 -0700 (PDT) Received: from localhost.localdomain ([2001:288:7001:2724:a6bf:1ff:fe8c:70bc]) by smtp.gmail.com with ESMTPSA id 9-20020aa79149000000b00518424f8922sm8232210pfi.77.2022.06.20.00.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 00:15:30 -0700 (PDT) From: Yun-Ze Li To: akpm@linux-foundation.org Cc: jrdr.linux@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yun-Ze Li Subject: [PATCH v2] mm, docs: fix comments that mention mem_hotplug_end() Date: Mon, 20 Jun 2022 07:15:16 +0000 Message-Id: <20220620071516.1286101-1-p76091292@gs.ncku.edu.tw> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655709333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0mOlgPiY8NctsBbPdtFtolqRiB7asIJTPtqqPiH8p+8=; b=lYUq7fxCyWHN8N5bGwbi6iwg3uguSsXKg6wH5kGqAKnMtJudjWqeLgocILOY+0iqjK5sy2 wzcPIHP54qmKmFt2vPYN48zMnyyZua9dqg5y4dtNGkDsUqFBkikZszF5aLjjYpFgpwwqJy u4zoCNW8ykmXkvhPsKySwIZkmB6cIB4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gs-ncku-edu-tw.20210112.gappssmtp.com header.s=20210112 header.b=NGhtV6oC; spf=none (imf24.hostedemail.com: domain of p76091292@gs.ncku.edu.tw has no SPF policy when checking 209.85.214.173) smtp.mailfrom=p76091292@gs.ncku.edu.tw; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655709333; a=rsa-sha256; cv=none; b=mjRVyOEl4HCZVfTXPUj1ht7raGA201wu9Y+cWDf5/qH2Zu61bVOgBA/k2sKb8RfyFv760Z L9bZmlTwft8otu712a0CiKDZeIrwsm+olzRw7sYq5iOOa/PvMVornhprZChCOqzfg8NZlu Nz24wxfqvI0gPnflkrTEKjcSR+OLA4I= X-Stat-Signature: kr67by88uf9uz4mxzmqexx3fuy4994p7 X-Rspamd-Queue-Id: 4494F18000F X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gs-ncku-edu-tw.20210112.gappssmtp.com header.s=20210112 header.b=NGhtV6oC; spf=none (imf24.hostedemail.com: domain of p76091292@gs.ncku.edu.tw has no SPF policy when checking 209.85.214.173) smtp.mailfrom=p76091292@gs.ncku.edu.tw; dmarc=none X-HE-Tag: 1655709332-246322 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Comments that mention mem_hotplug_end() are confusing as there is no function called mem_hotplug_end(). Fix them by replacing all the occurences of mem_hotplug_end() in the comments with mem_hotplug_done(). Signed-off-by: Yun-Ze Li --- V1 -> V2: Addressed review comments include/linux/mmzone.h | 4 ++-- mm/compaction.c | 2 +- mm/vmscan.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index aab70355d64f..7c7947109986 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -591,7 +591,7 @@ struct zone { * give them a chance of being in the same cacheline. * * Write access to present_pages at runtime should be protected by - * mem_hotplug_begin/end(). Any reader who can't tolerant drift of + * mem_hotplug_begin/done(). Any reader who can't tolerant drift of * present_pages should get_online_mems() to get a stable value. */ atomic_long_t managed_pages; @@ -870,7 +870,7 @@ typedef struct pglist_data { unsigned long nr_reclaim_start; /* nr pages written while throttled * when throttling started. */ struct task_struct *kswapd; /* Protected by - mem_hotplug_begin/end() */ + mem_hotplug_begin/done() */ int kswapd_order; enum zone_type kswapd_highest_zoneidx; diff --git a/mm/compaction.c b/mm/compaction.c index 65970107b789..d18b07368755 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -3009,7 +3009,7 @@ void kcompactd_run(int nid) /* * Called by memory hotplug when all memory in a node is offlined. Caller must - * hold mem_hotplug_begin/end(). + * be hold mem_hotplug_begin/done(). */ void kcompactd_stop(int nid) { diff --git a/mm/vmscan.c b/mm/vmscan.c index c6918fff06e1..e53195a0c019 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4586,7 +4586,7 @@ void kswapd_run(int nid) /* * Called by memory hotplug when all memory in a node is offlined. Caller must - * hold mem_hotplug_begin/end(). + * be hold mem_hotplug_begin/done(). */ void kswapd_stop(int nid) { -- 2.25.1