linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yun-Ze Li <p76091292@gs.ncku.edu.tw>
To: akpm@linux-foundation.org
Cc: jrdr.linux@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Yun-Ze Li <p76091292@gs.ncku.edu.tw>
Subject: [PATCH v2] mm, docs: fix comments that mention mem_hotplug_end()
Date: Mon, 20 Jun 2022 07:15:16 +0000	[thread overview]
Message-ID: <20220620071516.1286101-1-p76091292@gs.ncku.edu.tw> (raw)
In-Reply-To: <CAFqt6zYF3wRRpmhGzK_r9436JbWfVyjnKKp0oWpSZ+3zad=bxw@mail.gmail.com>

Comments that mention mem_hotplug_end() are confusing as there is no
function called mem_hotplug_end(). Fix them by replacing all the
occurences of mem_hotplug_end() in the comments with mem_hotplug_done().

Signed-off-by: Yun-Ze Li <p76091292@gs.ncku.edu.tw>
---
V1 -> V2: Addressed review comments

 include/linux/mmzone.h | 4 ++--
 mm/compaction.c        | 2 +-
 mm/vmscan.c            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index aab70355d64f..7c7947109986 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -591,7 +591,7 @@ struct zone {
 	 * give them a chance of being in the same cacheline.
 	 *
 	 * Write access to present_pages at runtime should be protected by
-	 * mem_hotplug_begin/end(). Any reader who can't tolerant drift of
+	 * mem_hotplug_begin/done(). Any reader who can't tolerant drift of
 	 * present_pages should get_online_mems() to get a stable value.
 	 */
 	atomic_long_t		managed_pages;
@@ -870,7 +870,7 @@ typedef struct pglist_data {
 	unsigned long nr_reclaim_start;	/* nr pages written while throttled
 					 * when throttling started. */
 	struct task_struct *kswapd;	/* Protected by
-					   mem_hotplug_begin/end() */
+					   mem_hotplug_begin/done() */
 	int kswapd_order;
 	enum zone_type kswapd_highest_zoneidx;
 
diff --git a/mm/compaction.c b/mm/compaction.c
index 65970107b789..d18b07368755 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -3009,7 +3009,7 @@ void kcompactd_run(int nid)
 
 /*
  * Called by memory hotplug when all memory in a node is offlined. Caller must
- * hold mem_hotplug_begin/end().
+ * be hold mem_hotplug_begin/done().
  */
 void kcompactd_stop(int nid)
 {
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c6918fff06e1..e53195a0c019 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -4586,7 +4586,7 @@ void kswapd_run(int nid)
 
 /*
  * Called by memory hotplug when all memory in a node is offlined.  Caller must
- * hold mem_hotplug_begin/end().
+ * be hold mem_hotplug_begin/done().
  */
 void kswapd_stop(int nid)
 {
-- 
2.25.1



      reply	other threads:[~2022-06-20  7:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-19 18:36 [PATCH] " Yun-Ze Li
2022-06-20  1:56 ` Souptick Joarder
2022-06-20  7:15   ` Yun-Ze Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220620071516.1286101-1-p76091292@gs.ncku.edu.tw \
    --to=p76091292@gs.ncku.edu.tw \
    --cc=akpm@linux-foundation.org \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox