From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E05F0C433EF for ; Fri, 17 Jun 2022 22:39:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C9E66B0074; Fri, 17 Jun 2022 18:39:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 679136B0075; Fri, 17 Jun 2022 18:39:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 541AD6B0078; Fri, 17 Jun 2022 18:39:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 42AF86B0074 for ; Fri, 17 Jun 2022 18:39:45 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 161F53560E for ; Fri, 17 Jun 2022 22:39:45 +0000 (UTC) X-FDA: 79589196330.30.17A942B Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf21.hostedemail.com (Postfix) with ESMTP id 5EDA41C00A8 for ; Fri, 17 Jun 2022 22:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655505584; x=1687041584; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wG47mPH2ny+DfuBj61UmcLRLOVow6f7xHscwu0hdrEU=; b=kvLeez67XkYQ8dki53eTfNGD8vCS4xSkZEkeHE7IAH2nMMRB+82Gaohh RC0jZN0H/11au7jNw4H44Vu/lD8OF/YGt862bHJ522vA/C+w4K3SseMEl ushRjZ+m1vK5sKFMDEG3BYZk5I6e8euAwTXxGqGdGbXW0ClE9smRn4eUB sDW68q1xl+ZKUq5e9MT2KGMor2MYLwM8WZ3cjuF/THPePHi3h3gRh9JVE PdOgyGDL2/6/EzduXU/Uf4ojQU4H+KivRXYiEWFTGK+eHlvSe2cMD2PDo NcEXB522jzN1qYbmuOcw2bzy97lQXzy9a4llNJHkquC4b0hLraZETLK0V g==; X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="343591050" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="343591050" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 15:39:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="688494714" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 17 Jun 2022 15:39:34 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id E6ACB132; Sat, 18 Jun 2022 01:39:38 +0300 (EEST) Date: Sat, 18 Jun 2022 01:39:38 +0300 From: "Kirill A. Shutemov" To: Alexander Potapenko Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , the arch/x86 maintainers , Kostya Serebryany , Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , "H . J . Lu" , Andi Kleen , Rick Edgecombe , Linux Memory Management List , LKML Subject: Re: [PATCHv3 4/8] x86/mm: Handle LAM on context switch Message-ID: <20220617223938.3qeb7tjr7wdjas27@black.fi.intel.com> References: <20220610143527.22974-1-kirill.shutemov@linux.intel.com> <20220610143527.22974-5-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655505584; a=rsa-sha256; cv=none; b=47DlIrUmdsCVtp0q8Df3emaoG17hxhhbEc+QBnT1+zhkFV3nQGInxeOWhfp30S/0TixS8p YMeHscjCYOFndNM1+FC6q7fbi1JUabDiYG3w9Xy/3GHDRkX526z92UxSJxs513M4gSBYq1 GNqKrZVDJkaPOZLxPMIXAIJVlc0RHss= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kvLeez67; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf21.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655505584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nkaQPEqmqQeqRIAL9Fd9z0jMEi6iTqpaDnkdgcQ0Pqg=; b=HVPKSqlxZpnT4nhndMn2mecQFQeGVcvfuYCLsNfzphr0OgRiADoE0L6xiRSrejoAanKGOC +JFfayTSJ5bKS45cfYVzUTggg8KeMu9ymswx3bWa4uAktepCdbw8hH8naZXAUNaXUY+QaL SDt5FQRImkDN+JPcFacPl+K5cq8gzmg= Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kvLeez67; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf21.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=kirill.shutemov@linux.intel.com X-Rspam-User: X-Stat-Signature: zfj9znmfsok18znnprnfow5n3hh83xab X-Rspamd-Queue-Id: 5EDA41C00A8 X-Rspamd-Server: rspam08 X-HE-Tag: 1655505584-967082 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 17, 2022 at 05:35:05PM +0200, Alexander Potapenko wrote: > On Fri, Jun 10, 2022 at 4:35 PM Kirill A. Shutemov > wrote: > > > > Linear Address Masking mode for userspace pointers encoded in CR3 bits. > > The mode is selected per-thread. Add new thread features indicate that the > > thread has Linear Address Masking enabled. > > > > switch_mm_irqs_off() now respects these flags and constructs CR3 > > accordingly. > > > > The active LAM mode gets recorded in the tlb_state. > > > > Signed-off-by: Kirill A. Shutemov > > > > +#ifdef CONFIG_X86_64 > > +static inline u64 mm_cr3_lam_mask(struct mm_struct *mm) > > +{ > > + return mm->context.lam_cr3_mask; > > +} > > Nit: can we have either "cr3_lam_mask" or "lam_cr3_mask" in both places? With changes sugessted by Peter, the field in the mmu_context will be called 'lam' as it is not CR3 mask anymore. -- Kirill A. Shutemov