From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BF9C433EF for ; Thu, 16 Jun 2022 16:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30E496B0081; Thu, 16 Jun 2022 12:17:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BE8F6B0080; Thu, 16 Jun 2022 12:17:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04BA46B0082; Thu, 16 Jun 2022 12:17:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EB5C76B0080 for ; Thu, 16 Jun 2022 12:17:57 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5E1D21516 for ; Thu, 16 Jun 2022 16:17:57 +0000 (UTC) X-FDA: 79584605394.30.91236EC Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 9D95520098 for ; Thu, 16 Jun 2022 16:17:55 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R491e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VGamLNn_1655396269; Received: from localhost(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0VGamLNn_1655396269) by smtp.aliyun-inc.com; Fri, 17 Jun 2022 00:17:49 +0800 From: Xianting Tian To: akpm@linux-foundation.org, ziy@nvidia.com, gregkh@linuxfoundation.org, stable@vger.kernel.org, guoren@kernel.org Cc: huanyi.xj@alibaba-inc.com, guohanjun@huawei.com, zjb194813@alibaba-inc.com, tianhu.hh@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xianting Tian Subject: [PATCH 4.14] mm: page_alloc: validate buddy page before using Date: Fri, 17 Jun 2022 00:17:41 +0800 Message-Id: <20220616161746.3565225-2-xianting.tian@linux.alibaba.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220616161746.3565225-1-xianting.tian@linux.alibaba.com> References: <20220616161746.3565225-1-xianting.tian@linux.alibaba.com> ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf13.hostedemail.com: domain of xianting.tian@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xianting.tian@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655396276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=T5Y6Ro30n1VKwVjMde8IB4g3PV9NbMy2YZvxSnBV4Dw=; b=UxAOJLM9EnkIF+fKYDqtGGQE6c/bNxa8n7DiwFIPzOndCumqW7XLxb5LezIzdC2g9p2WMI qHInfyuQfATGv7KqHeKXws2EPudM1TmhHS7YouFpkVjgEHKkg4n5OJlkun4gKJKmG0ZvXl HDymPX6VsZxFf7eIz1w8KagF5933tBk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655396276; a=rsa-sha256; cv=none; b=7zfKiGQA5FVIFEgFprM7E4kzwIJ1lg46ECO+AozKLgfRpNtUqyChM++cyRPDpGHH/XHPJH 18zQZWle2hjCCbu2TnPVIkpMe2Jp0/j2GsO+ajGsDSzp81Pszp8h9Wvf5LjUW454dBMVsc 2cOv7+krfX3oso5JpsYxMbquvHuAdsw= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9D95520098 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf13.hostedemail.com: domain of xianting.tian@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xianting.tian@linux.alibaba.com X-Stat-Signature: i9ptq1fm1bn7a5bz5cx9wpd3f1uxbono X-HE-Tag: 1655396275-265462 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 787af64d05cd ("mm: page_alloc: validate buddy before check its migratetype.") fixes a bug in 1dd214b8f21c and there is a similar bug in d9dddbf55667 that can be fixed in a similar way too. In addition, for RISC-V arch the first 2MB RAM could be reserved for opensbi, so it would have pfn_base=512 and mem_map began with 512th PFN when CONFIG_FLATMEM=y. But __find_buddy_pfn algorithm thinks the start pfn 0, it could get 0 pfn or less than the pfn_base value. We need page_is_buddy() to verify the buddy to prevent accessing an invalid buddy. Fixes: d9dddbf55667 ("mm/page_alloc: prevent merging between isolated and other pageblocks") Cc: stable@vger.kernel.org Reported-by: zjb194813@alibaba-inc.com Reported-by: tianhu.hh@alibaba-inc.com Signed-off-by: Xianting Tian --- mm/page_alloc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bfbccc739332..6e994a2013aa 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -866,6 +866,9 @@ static inline void __free_one_page(struct page *page, buddy_pfn = __find_buddy_pfn(pfn, order); buddy = page + (buddy_pfn - pfn); + + if (!page_is_buddy(page, buddy, order)) + goto done_merging; buddy_mt = get_pageblock_migratetype(buddy); if (migratetype != buddy_mt -- 2.17.1