From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 808D8C433EF for ; Thu, 16 Jun 2022 15:02:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC40C6B0071; Thu, 16 Jun 2022 11:02:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D74106B0072; Thu, 16 Jun 2022 11:02:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3CEA6B0074; Thu, 16 Jun 2022 11:02:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B2C6E6B0071 for ; Thu, 16 Jun 2022 11:02:04 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6F15634B99 for ; Thu, 16 Jun 2022 15:02:04 +0000 (UTC) X-FDA: 79584414168.08.7C53EC5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id 841E310009E for ; Thu, 16 Jun 2022 15:02:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D04FA21D3C; Thu, 16 Jun 2022 15:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655391721; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LG13+PzXyKkJJ354mhg9xbVpFu1cjtccEn2WqANniac=; b=mbh8tz7rXmsWOg5e2UVivIlGK7FzI5U7F3c56jFPvl6mXdCGlc9iLdZtow9p9dRUmJ1KWr m9y7qQ4aM9HJCLzPqk1BAjTCqynFZzLZUeUP0QUOkcWwlNQNMG7AHAtiGbmlbuRqQuTsYw l2AIB/zgWvmncuK5HsM5Q3HBVdXzQK0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655391721; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LG13+PzXyKkJJ354mhg9xbVpFu1cjtccEn2WqANniac=; b=/APgIUcaHjm7RI2mc8s+qU5gLnvZ/D0ZLdsUEFQN5wluO7t9WWzjyrkRxlomCfEGWu29YP 4X/Ufg+xwF6F9PCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 73BD41344E; Thu, 16 Jun 2022 15:02:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y8Y4G+lFq2IcOgAAMHmgww (envelope-from ); Thu, 16 Jun 2022 15:02:01 +0000 Date: Thu, 16 Jun 2022 16:57:27 +0200 From: David Sterba To: Christoph Hellwig Cc: dsterba@suse.cz, syzbot , akpm@linux-foundation.org, clm@fb.com, dsterba@suse.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, willy@infradead.org Subject: Re: [syzbot] KASAN: use-after-free Read in copy_page_from_iter_atomic (2) Message-ID: <20220616145727.GB20633@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Christoph Hellwig , syzbot , akpm@linux-foundation.org, clm@fb.com, dsterba@suse.com, josef@toxicpanda.com, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, willy@infradead.org References: <0000000000003ce9d105e0db53c8@google.com> <00000000000085068105e112a117@google.com> <20220613193912.GI20633@twin.jikos.cz> <20220614071757.GA1207@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614071757.GA1207@lst.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mbh8tz7r; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/APgIUca"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655391723; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LG13+PzXyKkJJ354mhg9xbVpFu1cjtccEn2WqANniac=; b=gVs2B5ST1YpKoADcJVEiwNV3N9t+zd8FtscNZc21ERvk3vzWoPNnZ8VpOY7iHvcdPozWvq 6zKogSE/dXrLLMoSb7KHNrFrakPl+MHcmcYFWXsAP9UlgGEmJcQaX7LLZt4xYYeIgWVSEK VBlLt4V1UTHxjuesdsGAQwzwnGSO6as= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655391723; a=rsa-sha256; cv=none; b=i2y9rB0H0OLWARtVX7aUZHJX8KpuEpzfsYUVlDQ/QinrrU8Ie3o5t+kHRXaldrbtZNuhqr D6gumMIu3D9vaycdwdFEIbt+zwnkHdmT7vS8sQ184j/JtJ3BBRpA8p9p1pTftlD3bCc5zB KtNt0Pc6uve+xS9pSi10nX7qHWm2v5c= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 841E310009E X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mbh8tz7r; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/APgIUca"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=dsterba@suse.cz X-Stat-Signature: 7q6w9pbk6ehrkjnz7r6f3k5rbietuzx7 X-HE-Tag: 1655391723-241334 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 14, 2022 at 09:17:57AM +0200, Christoph Hellwig wrote: > On Mon, Jun 13, 2022 at 09:39:12PM +0200, David Sterba wrote: > > On Fri, Jun 10, 2022 at 12:10:19AM -0700, syzbot wrote: > > > syzbot has bisected this issue to: > > > > > > commit 4cd4aed63125ccd4efc35162627827491c2a7be7 > > > Author: Christoph Hellwig > > > Date: Fri May 27 08:43:20 2022 +0000 > > > > > > btrfs: fold repair_io_failure into btrfs_repair_eb_io_failure > > > > Josef also reported a crash and found a bug in the patch, now added as > > fixup that'll be in for-next: > > The patch looks correct to me. Two things to note here: > > - I hadn't realized you had queued up the series. I did a review and as it looked ok I added it to the for-next for testing coverage, but I don't think I've sent any notice about that. > I've actually > started to merge some of my bio work with the bio split at > submission time work from Qu and after a few iterations I think > I would do the repair code a bit differently based on that. > Can you just drop the series for now? Yeah, we consistently hit 2 crashes, one of them has a fix but the other not, so I removed the topic branch from for-next. I'll wait for the reworked version you mention.