From: David Sterba <dsterba@suse.cz>
To: kernel test robot <lkp@intel.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
David Sterba <dsterba@suse.com>
Subject: Re: [linux-next:master 3345/4062] include/linux/highmem-internal.h:203:31: error: passing argument 1 of 'kunmap_flush_on_unmap' discards 'const' qualifier from pointer target type
Date: Thu, 16 Jun 2022 15:12:43 +0200 [thread overview]
Message-ID: <20220616131243.GA20633@suse.cz> (raw)
In-Reply-To: <202206161652.aEEuklTk-lkp@intel.com>
On Thu, Jun 16, 2022 at 04:58:08PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: c6d7e3b385f19869ab96e9404c92ff1abc34f2c8
> commit: 20adc3e8f39ad4ce68795b6d3f9847f45ccd931a [3345/4062] highmem: Make kunmap_{local,atomic}() take pointers to const void
> config: parisc-randconfig-r012-20220616 (https://download.01.org/0day-ci/archive/20220616/202206161652.aEEuklTk-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=20adc3e8f39ad4ce68795b6d3f9847f45ccd931a
> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> git fetch --no-tags linux-next master
> git checkout 20adc3e8f39ad4ce68795b6d3f9847f45ccd931a
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash drivers/iio/light/ drivers/net/wwan/t7xx/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All error/warnings (new ones prefixed by >>):
>
> In file included from include/linux/highmem.h:13,
> from include/linux/bvec.h:10,
> from include/linux/blk_types.h:10,
> from include/linux/writeback.h:13,
> from include/linux/memcontrol.h:22,
> from include/linux/swap.h:9,
> from include/linux/suspend.h:5,
> from include/linux/regulator/consumer.h:35,
> from include/linux/i2c.h:19,
> from drivers/iio/light/adjd_s311.c:15:
> include/linux/highmem-internal.h: In function '__kunmap_local':
> >> include/linux/highmem-internal.h:203:31: warning: passing argument 1 of 'kunmap_flush_on_unmap' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> 203 | kunmap_flush_on_unmap(addr);
I think you missed adding const to kunmap_flush_on_unmap, in some
configs it could be hidden behind an ifdef. The warning is on
ARCH=parisc,
https://elixir.bootlin.com/linux/latest/source/arch/parisc/include/asm/cacheflush.h#L78
#define ARCH_HAS_FLUSH_ON_KUNMAP
static inline void kunmap_flush_on_unmap(void *addr)
{
flush_kernel_dcache_page_addr(addr);
}
next prev parent reply other threads:[~2022-06-16 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 8:58 kernel test robot
2022-06-16 13:12 ` David Sterba [this message]
2022-06-16 14:10 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220616131243.GA20633@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=fmdefrancesco@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox