From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D9E8C433EF for ; Thu, 16 Jun 2022 09:00:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B9206B0072; Thu, 16 Jun 2022 05:00:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 069876B0073; Thu, 16 Jun 2022 05:00:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E73256B0074; Thu, 16 Jun 2022 05:00:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D44E76B0072 for ; Thu, 16 Jun 2022 05:00:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 990D815C9 for ; Thu, 16 Jun 2022 09:00:58 +0000 (UTC) X-FDA: 79583504196.18.77365EB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id 8EC7D20004 for ; Thu, 16 Jun 2022 09:00:57 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 72545210E4; Thu, 16 Jun 2022 09:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655370056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w0BHHsJPE8qgzh048aqdSMb/zWa2mtlhdMk8ow+kQSw=; b=JfzZQsy+X5n7J6iAAUyP6jooN90j7njJxN/Obtwg2jNsr3jNCpoRyOF93Z5Vsng4TJo5oB Mh0HUkf2I6WqSPBAafwZVZE4YOMNN/3ttAFtqtc8Hr8TsYFJf6VJNtuedsyehfyLBXVNwN emTTr4zg7Qd3nZuUmMCpQ8zWIWGcZGk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655370056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w0BHHsJPE8qgzh048aqdSMb/zWa2mtlhdMk8ow+kQSw=; b=aIvvRzucvxzVgOoa6kS+Z2qx0UD0mDzAlpLoRBod03NWoX7CHfBBPP3LV1Oc9IEY0CZuzI CCub8yJBqTEte2Aw== Received: from quack3.suse.cz (unknown [10.163.28.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 3E3622C141; Thu, 16 Jun 2022 09:00:56 +0000 (UTC) Received: by quack3.suse.cz (Postfix, from userid 1000) id C0CC9A062E; Thu, 16 Jun 2022 11:00:52 +0200 (CEST) Date: Thu, 16 Jun 2022 11:00:52 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , LKML , Greg Kroah-Hartman , linux-mm@kvack.org, Suzuki K Poulose , Guenter Roeck , Alexandru Elisei Subject: Re: [PATCH] init: Initialize noop_backing_dev_info early Message-ID: <20220616090052.6xhfljxcis7ymqlb@quack3.lan> References: <20220615214815.6901-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655370058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w0BHHsJPE8qgzh048aqdSMb/zWa2mtlhdMk8ow+kQSw=; b=q+NNNbsJv+dl/DzwCLgbNx4xmy00bRGRZJ1h56GlrytZU4xUZ38TK4cDluXAh5QLeo6AOs ygqRnn9cAOEWFfr/stE2ogI+WX6XHDi5njB8S4WLdoqyFMvwDs/btPfL17S9BImA+SJrc4 qraKKaqD9SkK8m4VFJBXqjBzhL7UDTM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655370058; a=rsa-sha256; cv=none; b=yThDILvHWUlnftvV4stJMiwBv1XiMWTAIW9O2Ug9e5PeNhWmHw5CA2wSIttZfalhyHGL2P HEwPrTKGa42fWSAj91wxr/lRw0f/J1l9Ia4BA2L2AUdGY6cKnOMvv21NU+aEdc34oHz6QB gsbWctTlOaUxYJ3H7B6p8+lXr+tocd0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JfzZQsy+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aIvvRzuc; dmarc=none; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JfzZQsy+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=aIvvRzuc; dmarc=none; spf=pass (imf03.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: ymxoztqbju4weis6ysuz1ocy6notwns7 X-Rspamd-Queue-Id: 8EC7D20004 X-HE-Tag: 1655370057-762696 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 15-06-22 23:08:22, Christoph Hellwig wrote: > On Wed, Jun 15, 2022 at 11:48:15PM +0200, Jan Kara wrote: > > +extern int bdi_init(struct backing_dev_info *bdi); > > No need for the extern. Yes, fixed up. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig Thanks for review! > And this remind me that I really want to kill noop_backing_dev_info > and just use a NULL bdi for this case eventually.. Yes, I'm just not sure whether the checks for bdi / wb being NULL in lots of places will not be too annoying... But maybe you'll be able to come up with some wrappers that will make things bearable. Honza -- Jan Kara SUSE Labs, CR