From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D471CC43334 for ; Wed, 15 Jun 2022 08:55:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32D686B0071; Wed, 15 Jun 2022 04:55:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DD626B0072; Wed, 15 Jun 2022 04:55:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A52B6B0073; Wed, 15 Jun 2022 04:55:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0AAAB6B0071 for ; Wed, 15 Jun 2022 04:55:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D3D54613EA for ; Wed, 15 Jun 2022 08:55:12 +0000 (UTC) X-FDA: 79579860864.21.822B131 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by imf31.hostedemail.com (Postfix) with ESMTP id F2CE62009F for ; Wed, 15 Jun 2022 08:55:11 +0000 (UTC) Received: from mse-fl2.zte.com.cn (unknown [10.30.14.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4LNJzJ618wz4xVnK; Wed, 15 Jun 2022 16:55:08 +0800 (CST) Received: from szxlzmapp05.zte.com.cn ([10.5.230.85]) by mse-fl2.zte.com.cn with SMTP id 25F8sl4a001444; Wed, 15 Jun 2022 16:54:47 +0800 (GMT-8) (envelope-from wang.yi59@zte.com.cn) Received: from mapi (szxlzmapp05[null]) by mapi (Zmail) with MAPI id mid14; Wed, 15 Jun 2022 16:54:47 +0800 (CST) Date: Wed, 15 Jun 2022 16:54:47 +0800 (CST) X-Zmail-TransId: 2b0762a99e57ffffffffef800a0c X-Mailer: Zmail v1.0 Message-ID: <202206151654471905256@zte.com.cn> In-Reply-To: References: CAAH8bW8wD_hsOqtWa-g_1SNWNi7GHzsu9RvL8feY069JPKFWBA@mail.gmail.com,202206141145339651323@zte.com.cn,CAAH8bW_GCviYSadmf5CUxgJixkXbq+SfL63ZJt7Lsm9OAmPjVQ@mail.gmail.com Mime-Version: 1.0 From: To: Cc: , , , , , , , , Subject: =?UTF-8?B?UmU6W1BBVENIXSBiaXRtYXA6IGZpeCBhIHVucHJvcGVyIHJlbWFwIHdoZW4gbXBvbF9yZWJpbmRfbm9kZW1hc2soKQ==?= Content-Type: text/plain; charset="UTF-8" X-MAIL:mse-fl2.zte.com.cn 25F8sl4a001444 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 62A99E6C.000 by FangMail milter! X-FangMail-Envelope: 1655283308/4LNJzJ618wz4xVnK/62A99E6C.000/10.30.14.239/[10.30.14.239]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 62A99E6C.000/4LNJzJ618wz4xVnK ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=zte.com.cn; spf=pass (imf31.hostedemail.com: domain of wang.yi59@zte.com.cn designates 63.216.63.35 as permitted sender) smtp.mailfrom=wang.yi59@zte.com.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655283312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JcNI2sovxe3WpKRsZaCB67dvRpqaU1O+qU53UXNKZM=; b=TdRUqzqeIhzYukGU0a5FF1GIoRxPZWlGWFXBUGdTLS/QdrT0qBKTw88qSEGrB8+QQJOBe8 I7+hmGbDXAKi+URUdkh+FABG+aUv5vtB1HSXn3b1Fqwm85lRXkWwuz4ny2q2rMfUrPcMU/ 1d77fZYfoyhd//myGLvq3lCW1ZLFa+0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655283312; a=rsa-sha256; cv=none; b=rEJ8KxIY+Ofh6vKjMZVZwpMS9YqJm8kujYfsaTfXoAMWuS11gozlgOVVR75mdeA/rEBkNy ClBStgsbklP9h/0mTcQ1UjfGf3p0zJ/5etd6NU+zMLcMBAejO+VXr3DZ/YpRUoaGDBlZ3P G0ENKngxcjJt7rnbC/du3RkfixDJLmk= X-Stat-Signature: 3h6rafix4dcysfz8f4ep5zgsha8xhmw5 X-Rspamd-Queue-Id: F2CE62009F X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=zte.com.cn; spf=pass (imf31.hostedemail.com: domain of wang.yi59@zte.com.cn designates 63.216.63.35 as permitted sender) smtp.mailfrom=wang.yi59@zte.com.cn X-Rspamd-Server: rspam10 X-HE-Tag: 1655283311-348868 X-Bogosity: Ham, tests=bogofilter, spamicity=0.010644, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Mon, Jun 13, 2022 at 8:45 PM wrote: > > > > > > - change the bitmap_remap() as this patch did, but this changed the > > behavior of this routine which looks does the right thing. One good > > news is this function is only called by mpol_rebind_nodemask(). > > There are users of bitmap_remap() in drivers/gpio/gpio-xilinx.c > > > - don't change the bitmap_remap(), to be honest, I didn't figure out > > a way. Any suggestions? > > I haven't had a chance to play with it (because of my dayjob), but I > have a strong feeling that the proper solution should come from > existing functionality. > > Did you experiment with MPOL_F_{STATIC,RELATIVE}_NODES? > Those flags enable nodes_and() and mpol_relative_nodemask() > paths correspondingly. > You are right, adding MPOL_F_STATIC_NODES can fix this situation. So it seems that we don't need to do anything in kernel now. Many thanks for your time :) > What I suggested is: > > 328 node_clear(1, pol->w.cpuset_mems_allowed); > 329 node_clear(3, pol->w.cpuset_mems_allowed); > 330 nodes_remap(tmp, pol->nodes, pol->w.cpuset_mems_allowed, > 331 *nodes); > 332 pol->w.cpuset_mems_allowed = *nodes; > > > In the example above, if set cpuset.mems to 0,2 firstly, the nodes > > binds will change from 1 to 2. And then set cpuset.mems to 1,3, it will > > change from 2 to 3 again. --- Best wishes Yi Wang