From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E74CCA473 for ; Wed, 15 Jun 2022 20:49:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F7DC6B0071; Wed, 15 Jun 2022 16:49:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A94E6B0072; Wed, 15 Jun 2022 16:49:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F406B0074; Wed, 15 Jun 2022 16:49:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6795C6B0071 for ; Wed, 15 Jun 2022 16:49:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2F08620272 for ; Wed, 15 Jun 2022 20:49:36 +0000 (UTC) X-FDA: 79581661152.18.F76EC83 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id BC7B84008D for ; Wed, 15 Jun 2022 20:49:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCC0361727; Wed, 15 Jun 2022 20:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EEBFEC3411A; Wed, 15 Jun 2022 20:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1655326174; bh=KSQ9c1G5/sgy0ACm7XqfABcNHNsUc0e55Tg89/Z10ww=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rgg8tyuaX3XDBxsfzFICcJc/ltR0sB9XY0QDTk1xYmwTplADHt5KxPaKRsqeuaK9w WdFgLoZcEocE19N3O1L9bUNhjUKHwFte7KULkh3geehZARxBpWz+I9aTcUSYAmL+5L Wf1jQA4/QaIxGQx6v/ZBYPVLzpL6va1kQwWlGv/U= Date: Wed, 15 Jun 2022 13:49:33 -0700 From: Andrew Morton To: HORIGUCHI =?UTF-8?B?TkFPWUE=?=(=?UTF-8?B?5aCA5Y+j44CA55u05Lmf?=) Cc: zhenwei pi , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "david@redhat.com" , "linmiaohe@huawei.com" , "gregkh@linuxfoundation.org" , Oscar Salvador Subject: Re: [PATCH v6 1/1] mm/memory-failure: disable unpoison once hw error happens Message-Id: <20220615134933.66f3ba7f3b169b936b2128de@linux-foundation.org> In-Reply-To: <20220615103406.GA1669251@hori.linux.bs1.fc.nec.co.jp> References: <20220615093209.259374-1-pizhenwei@bytedance.com> <20220615093209.259374-2-pizhenwei@bytedance.com> <20220615103406.GA1669251@hori.linux.bs1.fc.nec.co.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655326175; a=rsa-sha256; cv=none; b=PW6cfnwsuPxm9YFJyMYjYpE+pgopGX1E0PFidGUi11jGgrfDhHRdTMICNmSYaERMI2sdxt X/lgzGIllvg1o1V1CO4Bo3o4jWBJXngXyBwRiW68RfjOY2La0d84Q7yMPeR2g2bt5Vzw0O 0iyk1fpOYiaC0GWfuAmKK7PyJjLqLjk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rgg8tyua; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655326175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oZs7B91LcjleVLg2vGEeQhVKfMPF88TQcA3MFe6xI8I=; b=rwa3okM2XuLIr3RGNdfvmpR42umegIScf1eZtb0xDL8Ar+DySA6IWINrJtWiRnrSi0cZhW qDeKkKESZTWzrfy8UAsuwhMBfzCWPTstrrWT1wexUtPz8vmQkdecd6qnZkJ8K+D1QD7dS7 3hEW4920Niyd4opcxov+uF+rOfaX5es= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rgg8tyua; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Stat-Signature: f4y3gergfwifdgqu8rxjik1djskgjcwm X-Rspamd-Queue-Id: BC7B84008D X-Rspamd-Server: rspam08 X-HE-Tag: 1655326175-99649 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Jun 2022 10:34:06 +0000 HORIGUCHI NAOYA(堀口　直也) wrote: > On Wed, Jun 15, 2022 at 05:32:09PM +0800, zhenwei pi wrote: > > Currently unpoison_memory(unsigned long pfn) is designed for soft > > poison(hwpoison-inject) only. Since 17fae1294ad9d, the KPTE gets > > cleared on a x86 platform once hardware memory corrupts. > > > > Unpoisoning a hardware corrupted page puts page back buddy only, > > the kernel has a chance to access the page with *NOT PRESENT* KPTE. > > This leads BUG during accessing on the corrupted KPTE. > > > > Suggested by David&Naoya, disable unpoison mechanism when a real HW error > > happens to avoid BUG like this: > > > > ... > > > > > Fixes: 847ce401df392 ("HWPOISON: Add unpoisoning support") > > Fixes: 17fae1294ad9d ("x86/{mce,mm}: Unmap the entire page if the whole page is affected and poisoned") > > Cc: Naoya Horiguchi > > Cc: David Hildenbrand > > Cc: Oscar Salvador > > Cc: Greg Kroah-Hartman > > Acked-by: David Hildenbrand > > Signed-off-by: zhenwei pi > > Thank you very much. > > Acked-by: Naoya Horiguchi I added cc:stable to this. But the dual Fixes: are going to confuse people regarding which kernel versions need the fix. Can we be more specific?