From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28DA6C43334 for ; Wed, 15 Jun 2022 09:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CE156B0071; Wed, 15 Jun 2022 05:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97CF56B0072; Wed, 15 Jun 2022 05:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CC16B0073; Wed, 15 Jun 2022 05:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 77AE26B0071 for ; Wed, 15 Jun 2022 05:36:35 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 31B2B2EC6D for ; Wed, 15 Jun 2022 09:36:35 +0000 (UTC) X-FDA: 79579965150.09.5F9AD81 Received: from cmccmta2.chinamobile.com (cmccmta2.chinamobile.com [221.176.66.80]) by imf15.hostedemail.com (Postfix) with ESMTP id 1D269A0077 for ; Wed, 15 Jun 2022 09:36:32 +0000 (UTC) X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG:00000000 Received:from spf.mail.chinamobile.com (unknown[172.16.121.87]) by rmmx-syy-dmz-app05-12005 (RichMail) with SMTP id 2ee562a9a81d1cf-4139f; Wed, 15 Jun 2022 17:36:30 +0800 (CST) X-RM-TRANSID:2ee562a9a81d1cf-4139f X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG:00000000 Received:from localhost.localdomain (unknown[223.108.79.97]) by rmsmtp-syy-appsvrnew04-12029 (RichMail) with SMTP id 2efd62a9a81d15b-c5d4a; Wed, 15 Jun 2022 17:36:30 +0800 (CST) X-RM-TRANSID:2efd62a9a81d15b-c5d4a From: Ding Xiang To: akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests: vm: Fix resource leak when return error Date: Wed, 15 Jun 2022 17:36:29 +0800 Message-Id: <20220615093629.1330809-1-dingxiang@cmss.chinamobile.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655285794; a=rsa-sha256; cv=none; b=8HkzfxVfbp9FEF53qzz1k7ItsTjc4KJpLYBzV8lHj8KxJnoSxW+3p6evtow7bAPwMOXP2U 2BrtuiBj4jkvPDUy5k/xqRwym2bKEZqyryynb9/FtOwRnGyZypL0t2WVbU8jGPq2cUFgD2 /ps2TfhHbW6AIRE9sXdYQGiQdLiUAn0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of dingxiang@cmss.chinamobile.com designates 221.176.66.80 as permitted sender) smtp.mailfrom=dingxiang@cmss.chinamobile.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655285794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=5qpt6UhaKqcqJ9/hR+6meHWgsAp9a1S5V1/wUVRkC2M=; b=a418T2/4yEIHnw5w7N+jqj2TDODLKCFihKNQ9X3M5T1kP/MaifFrKFUj6pp0bYKbPTDKZ6 scnJpVeKg2jKxyvQWteZG0JTQd6LoiTIfYqZsu2L8xHhecjrVxUpBYr+z7GFvQimZMM5WY xFVpbPH2wLE++qCi5sm1hkl2PeLINRM= X-Rspamd-Queue-Id: 1D269A0077 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of dingxiang@cmss.chinamobile.com designates 221.176.66.80 as permitted sender) smtp.mailfrom=dingxiang@cmss.chinamobile.com X-Rspamd-Server: rspam06 X-Stat-Signature: zr8jnthrbwccnsywngp8e4o5m5aod9ii X-HE-Tag: 1655285792-656786 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When return on an error path, file handle need to be closed to prevent resource leak Signed-off-by: Ding Xiang --- tools/testing/selftests/vm/ksm_tests.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c index 2fcf24312da8..f5e4e0bbd081 100644 --- a/tools/testing/selftests/vm/ksm_tests.c +++ b/tools/testing/selftests/vm/ksm_tests.c @@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val) } if (fprintf(f, "%lu", val) < 0) { perror("fprintf"); + fclose(f); return 1; } fclose(f); @@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val) } if (fscanf(f, "%lu", val) != 1) { perror("fscanf"); + fclose(f); return 1; } fclose(f); -- 2.31.1