From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDBC8C433EF for ; Tue, 14 Jun 2022 09:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C929F6B0208; Tue, 14 Jun 2022 05:24:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C41886B0209; Tue, 14 Jun 2022 05:24:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B08FE6B020A; Tue, 14 Jun 2022 05:24:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9ECB86B0208 for ; Tue, 14 Jun 2022 05:24:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 66B2835D83 for ; Tue, 14 Jun 2022 09:24:10 +0000 (UTC) X-FDA: 79576305060.06.1E32B99 Received: from mail.nfschina.com (mail.nfschina.com [124.16.136.209]) by imf16.hostedemail.com (Postfix) with ESMTP id 52E50180091 for ; Tue, 14 Jun 2022 09:24:09 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 94B911E80D8F; Tue, 14 Jun 2022 17:22:46 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iIj6q3QRWcQD; Tue, 14 Jun 2022 17:22:43 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: renyu@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id 185C01E80D5E; Tue, 14 Jun 2022 17:22:43 +0800 (CST) From: Ren Yu To: cl@linux.com Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liqiong@nfschina.com, qixu@nfschina.com, hukun@nfschina.com, yuzhe@nfschina.com, Ren Yu Subject: [PATCH v2] mm, slab: check the function kmalloc_slab return value Date: Tue, 14 Jun 2022 17:23:12 +0800 Message-Id: <20220614092312.14006-1-renyu@nfschina.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220613102438.27723-1-renyu@nfschina.com> References: <20220613102438.27723-1-renyu@nfschina.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655198650; a=rsa-sha256; cv=none; b=KoWx0RL0ICYGfcfZn/o4YjnBfLtKSS6zQ2qpbZaPhieL+XgxjkWRsUfx3W3jvuVPy8xuzJ OqUjXHBUxq+Wj9Xl+FINxvkdforGSGVEHNAxVOAwCeGdwY7zpgJ4RWK/8AD17eRNgq8gvE saWetU03lZYqsD7vsouBFDnceBebW8Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of renyu@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=renyu@nfschina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655198650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Oik/GrJtXBX79BmEZq6a4uLxFf6dMjCvvg61OqSiQik=; b=Z1YuZbfUDt67TBu4n5vQnuc5I/uoDmOlxwyEe7QEtZHQUgI89DTCN18NwqpoFrJ3uodCXq 1M7GqypUU6yA7ZcmESoKVdgPciLWLbhjxo2ipGrbS/WZuziRRW2INDN5/DrfjUsS7KImyW Sxfkty+s4u512Ojl2CT8VvsCgwKFUTQ= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 52E50180091 X-Stat-Signature: zc6zqajrsefd53m7bcgpg7cxq6cs5zm4 Authentication-Results: imf16.hostedemail.com; dkim=none; spf=none (imf16.hostedemail.com: domain of renyu@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=renyu@nfschina.com; dmarc=none X-HE-Tag: 1655198649-754281 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As the possible failure of the kmalloc_slab, it should be better to check it. Signed-off-by: Ren Yu Reported-by: kernel test robot --- v2: - change return value of error path to '-ENOMEM' - not check for zero --- mm/slab.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/slab.c b/mm/slab.c index f8cd00f4ba13..eb3fb042f4f4 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2064,6 +2064,8 @@ int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags) if (OFF_SLAB(cachep)) { cachep->freelist_cache = kmalloc_slab(cachep->freelist_size, 0u); + if (!cachep->freelist_cache) + return -ENOMEM; } err = setup_cpu_cache(cachep, gfp); -- 2.11.0