linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ren Yu <renyu@nfschina.com>
To: cl@linux.com
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	akpm@linux-foundation.org, vbabka@suse.cz,
	roman.gushchin@linux.dev, 42.hyeyoo@gmail.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	liqiong@nfschina.com, qixu@nfschina.com, hukun@nfschina.com,
	yuzhe@nfschina.com, Ren Yu <renyu@nfschina.com>
Subject: [PATCH v2] mm, slab: check the function kmalloc_slab return value
Date: Tue, 14 Jun 2022 17:23:12 +0800	[thread overview]
Message-ID: <20220614092312.14006-1-renyu@nfschina.com> (raw)
In-Reply-To: <20220613102438.27723-1-renyu@nfschina.com>

As the possible failure of the kmalloc_slab,
it should be better to check it.

Signed-off-by: Ren Yu <renyu@nfschina.com>
Reported-by: kernel test robot <lkp@intel.com>
---
v2:
- change return value of error path to '-ENOMEM'
- not check for zero
---
 mm/slab.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/slab.c b/mm/slab.c
index f8cd00f4ba13..eb3fb042f4f4 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -2064,6 +2064,8 @@ int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags)
 	if (OFF_SLAB(cachep)) {
 		cachep->freelist_cache =
 			kmalloc_slab(cachep->freelist_size, 0u);
+		if (!cachep->freelist_cache)
+			return -ENOMEM;
 	}
 
 	err = setup_cpu_cache(cachep, gfp);
-- 
2.11.0



      parent reply	other threads:[~2022-06-14  9:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 10:24 [PATCH] mm: " Ren Yu
2022-06-13 13:37 ` kernel test robot
2022-06-14  8:39 ` Ren Yu
2022-06-14  8:48   ` Vlastimil Babka
2022-06-14  9:26     ` tury
2022-06-14 11:47       ` Vlastimil Babka
2022-06-14  9:23 ` Ren Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614092312.14006-1-renyu@nfschina.com \
    --to=renyu@nfschina.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=hukun@nfschina.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liqiong@nfschina.com \
    --cc=penberg@kernel.org \
    --cc=qixu@nfschina.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    --cc=yuzhe@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox