From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA94CC433EF for ; Mon, 13 Jun 2022 18:57:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B3906B025E; Mon, 13 Jun 2022 14:57:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13B366B0260; Mon, 13 Jun 2022 14:57:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1C928D01A1; Mon, 13 Jun 2022 14:57:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DBBB66B025E for ; Mon, 13 Jun 2022 14:57:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AB07C20CD6 for ; Mon, 13 Jun 2022 18:57:35 +0000 (UTC) X-FDA: 79574121270.28.89B44C8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 2C69E1C009F for ; Mon, 13 Jun 2022 18:57:35 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E945F6139D; Mon, 13 Jun 2022 18:57:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05A33C34114; Mon, 13 Jun 2022 18:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1655146653; bh=RtZIBWe+05gHsYyngX/4j7BVWoIboX+tQ3jXoAWIZrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IOK463q+lGp4saZIQb0kwtsiwK+7afH/PAaPe7nrq0o+/Fsq1sTxZS3kdc4vQbr+h TzA/P0FnfjZzZwOgbSk4X2RLr+aCJXbFXNznZmXhpeYpF0MBnuP0t2UkoAvCpp0PoY uoaQPPvOd1TTdBnuiYqwVkoeofrFXRyrzJ8yiUMc= Date: Mon, 13 Jun 2022 11:57:32 -0700 From: Andrew Morton To: Mike kravetz Cc: Matthew Wilcox , linux-man@vger.kernel.org, linux-mm@kvack.org, David Hildenbrand , Muchun Song , Naoya Horiguchi , Axel Rasmussen , Dave Hansen , Michal Hocko Subject: Re: [PATCH] hugetlbfs: zero partial pages during fallocate hole punch Message-Id: <20220613115732.3bf59ca4b31512153e27c548@linux-foundation.org> In-Reply-To: References: <20220613180858.15933-1-mike.kravetz@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655146655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BLmG+0vEWgJPFTWO3Y3oreOnbGY8jj0IR6ZSGN5op0U=; b=wQZOQ7V4HsuX208+bP+cmR7ofim+RgmBWOSeoGTfLOOwZQrO7qGuCjhLUppQTB+/XeOAWy U/ZLcDC3R48spKBaqo0jTO7+Ok/wv7uZnAW8wlpmSwmTtortARttakpt7LFe02S0A2PeF+ bya1IhYr+4XgAoWHWdnx1G7OodxSfgk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IOK463q+; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655146655; a=rsa-sha256; cv=none; b=qtzTaj/hwwupN9KzPgnNquFcll9/EDlgAt0yVuqhD3iCZ2FX8FUs2m+s7X4WMDTXJcGwSL jnwaUzSPeSPD9xBhXTEOxjHVDGS8nEhKvq1PcFK7ZzDFB+h6zjb9BQ60iKdS7JutSEbv4T 4tGBWVgVR5cyMTadLTqdtnMhEAp7m7M= X-Rspamd-Queue-Id: 2C69E1C009F X-Rspam-User: X-Stat-Signature: ewwccnb5b9eqiqjanwq3c5wpb7ybx9r1 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=IOK463q+; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam04 X-HE-Tag: 1655146655-402995 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 13 Jun 2022 11:36:30 -0700 Mike kravetz wrote: > On Mon, Jun 13, 2022 at 07:30:22PM +0100”, Matthew Wilcox wrote: > > On Mon, Jun 13, 2022 at 11:08:58AM -0700, Mike Kravetz wrote: > > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > > > index eca1d0fabd7e..b0d0947a7e9b 100644 > > > --- a/fs/hugetlbfs/inode.c > > > +++ b/fs/hugetlbfs/inode.c > > > @@ -584,41 +584,79 @@ static void hugetlb_vmtruncate(struct inode *inode, loff_t offset) > > > remove_inode_hugepages(inode, offset, LLONG_MAX); > > > } > > > > > > +static void hugetlbfs_zero_partial_page(struct hstate *h, > > > + struct address_space *mapping, > > > + unsigned long start, > > > > This should be loff_t. Otherwise we can truncate on 32-bit machines. > > > > Thanks! I missed that. I did this: --- a/fs/hugetlbfs/inode.c~hugetlbfs-zero-partial-pages-during-fallocate-hole-punch-fix +++ a/fs/hugetlbfs/inode.c @@ -602,8 +602,7 @@ static void hugetlb_vmtruncate(struct in static void hugetlbfs_zero_partial_page(struct hstate *h, struct address_space *mapping, - unsigned long start, - unsigned long end) + loff_t start, loff_t end) { pgoff_t idx = start >> huge_page_shift(h); struct page *page; _