From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD809CCA47B for ; Mon, 13 Jun 2022 10:25:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 118856B00A0; Mon, 13 Jun 2022 06:25:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 079E38D0171; Mon, 13 Jun 2022 06:25:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E35466B00AF; Mon, 13 Jun 2022 06:25:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D0F6A6B00A0 for ; Mon, 13 Jun 2022 06:25:33 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id A651C80C98 for ; Mon, 13 Jun 2022 10:25:33 +0000 (UTC) X-FDA: 79572830946.25.B859E91 Received: from mail.nfschina.com (mail.nfschina.com [124.16.136.209]) by imf08.hostedemail.com (Postfix) with ESMTP id 934FF16008F for ; Mon, 13 Jun 2022 10:25:32 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id EF01F1E80D8F; Mon, 13 Jun 2022 18:24:17 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5ehSxzKs3qQo; Mon, 13 Jun 2022 18:24:15 +0800 (CST) Received: from localhost.localdomain (unknown [180.167.10.98]) (Authenticated sender: renyu@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id A5A361E80D89; Mon, 13 Jun 2022 18:24:14 +0800 (CST) From: Ren Yu To: cl@linux.com Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liqiong@nfschina.com, qixu@nfschina.com, hukun@nfschina.com, yuzhe@nfschina.com, Ren Yu Subject: [PATCH] mm: check the function kmalloc_slab return value Date: Mon, 13 Jun 2022 18:24:38 +0800 Message-Id: <20220613102438.27723-1-renyu@nfschina.com> X-Mailer: git-send-email 2.11.0 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655115933; a=rsa-sha256; cv=none; b=S6DWtJ6gswEbNgdsPUOJtFC7ZC+DwAFr5+l22MITA1/gh1DzmSm3CfVhuoUTS0CmD6fUwX iLR7GWcDAFL1bZroXXAI+7I0eBDIdtGmiPoajHkw12jvYQKmHfYHatInthA28WM0Etba6V SyDU83CxGB4HxoFW0fleftrQmp5w0Qo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=none (imf08.hostedemail.com: domain of renyu@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=renyu@nfschina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655115933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=y1DiZQmSTSfTgHgtjERpU1UmlyhdxPDPiw5SM48D3bo=; b=W3p/MgK8Pb+V36ScE5mO12DNaQ+KdgEGriFQFikA9il6mB/yoXOXmwBBnWN3QB8QAS0i8k +MpXZ+hJib2u2/Dr1aIvMv6bcKz2S7VHq/1Vo0hww98mnojbRViwhTF0B12u6EJ5WPUWQO oabrl5gf6fub1jyVlTWO/rKR87mcSd4= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 934FF16008F X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=none; spf=none (imf08.hostedemail.com: domain of renyu@nfschina.com has no SPF policy when checking 124.16.136.209) smtp.mailfrom=renyu@nfschina.com; dmarc=none X-Stat-Signature: r6nmfjz5rxm1wrowqu6ejs6s589s3853 X-HE-Tag: 1655115932-872899 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As the possible failure of the kmalloc_slab, it should be better to check it. Signed-off-by: Ren Yu --- mm/slab.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/slab.c b/mm/slab.c index f8cd00f4ba13..72135e555827 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2064,6 +2064,8 @@ int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags) if (OFF_SLAB(cachep)) { cachep->freelist_cache = kmalloc_slab(cachep->freelist_size, 0u); + if (unlikely(ZERO_OR_NULL_PTR(cachep->freelist_cache))) + return cachep->freelist_cache; } err = setup_cpu_cache(cachep, gfp); -- 2.11.0