From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BD4CCA47B for ; Mon, 13 Jun 2022 16:23:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 177ED8D01A5; Mon, 13 Jun 2022 12:23:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15C248D01A1; Mon, 13 Jun 2022 12:23:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03F0E8D01A5; Mon, 13 Jun 2022 12:23:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EB49A8D01A1 for ; Mon, 13 Jun 2022 12:23:17 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C382220C6B for ; Mon, 13 Jun 2022 16:23:17 +0000 (UTC) X-FDA: 79573732434.29.9A0A0A8 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf03.hostedemail.com (Postfix) with ESMTP id 4C4CB2009B for ; Mon, 13 Jun 2022 16:23:17 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id e9so6066816pju.5 for ; Mon, 13 Jun 2022 09:23:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vSNccuYh4we1yOZG+w2VAnrJv46RwvtWv8Xi0I7VYb0=; b=hsvCkORtVgR41TYiOOf4gC1iZVI35VK2BvKJXKprg4/aAOmsmzGh7MmU1Yjzuh2Y0c XB9OsDGe3tsFn3sOPkYwpDi0nZOF+K6WXfk997VTmOoZnc+TD2dY/Dj3dThEl0ADESNy 3WMyta6qO45pNCqVz5kPzq/jVNMIsZxMAvm/Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vSNccuYh4we1yOZG+w2VAnrJv46RwvtWv8Xi0I7VYb0=; b=FxdKr6h7/NYoNXvq6GhiM7mdUwM4DMmo/+1zZ9ExoetgqhAbNK3CrM7nNPfvZknaaG qSC7uDA583GqB9w+LHICF3cgEBHHBRtjE+tkl7aMvM8ZP7EAMeUc+GreGCvxV/oW3AOI bC+n6ufx+A2wkTNyHQrRz4VXhUWCagh6G2R6GcVVUAy8jgOBkBGo4s8EUG8Ov5I0QoQR ojCuD7w3ymeiWYrPsIzKy9LAYEqMoOfiTB5iAUngxKXtw1dALl4/No1G48HuclxPkeKU SnSZ5srFe6YCuF5AN2tnUiFLZTAHqL9n3SW79DeiF4jlVdi5ttQvsiBIqCg4cVDWsBTr y/LA== X-Gm-Message-State: AJIora8g8q1amvH7sDBeuVJobVDqJXR3bcWgMd00J6XMV7BZ+KksD0FS vuCc3whpIzRLEpgiVG1AGuu3ZA== X-Google-Smtp-Source: AGRyM1spwIqiyw4Fe0nc/aqfToyDFsVpou2Aqr7S4QqIAWEyupmF0bz7MpA6EN2kR7R7y1cM2El+MQ== X-Received: by 2002:a17:90b:615:b0:1e6:9c25:81ce with SMTP id gb21-20020a17090b061500b001e69c2581cemr601928pjb.148.1655137396268; Mon, 13 Jun 2022 09:23:16 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x8-20020a637c08000000b003fe2062e49esm5677678pgc.73.2022.06.13.09.23.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jun 2022 09:23:15 -0700 (PDT) Date: Mon, 13 Jun 2022 09:23:15 -0700 From: Kees Cook To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Uladzislau Rezki , Zorro Lang , linux-xfs@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/3] usercopy: Handle vm_map_ram() areas Message-ID: <202206130922.A218C4E3E8@keescook> References: <20220612213227.3881769-1-willy@infradead.org> <20220612213227.3881769-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220612213227.3881769-2-willy@infradead.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655137397; a=rsa-sha256; cv=none; b=zCTCAfMWuOGeoHfiR0FMvbk5oi7UTuD+FR/jw6XXL3s61qAoArr+Yz7D/HC8Yhta0vpuKx TWkxfQwmiSBH4aiKhp2zveNclilvGVR5vKGr2F+dUgqG0pf7mliYtonM8hH8zoaUtYjYpl 6pvUveEgYlzqynR4yNppCUlP9EV6QRg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hsvCkORt; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655137397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vSNccuYh4we1yOZG+w2VAnrJv46RwvtWv8Xi0I7VYb0=; b=HmbxgtsaogFJZjZi4GT80QNJLKzeXkr8CrGiYECoqvixLGieqUsHOKd6b8wg9pkR8Y33ZH xK2oHInnifVXogeKBUdyvG9taKtmQg+51vuUsjX/3XZaunxFKFoQmUv5KsGcJnUO8zqHvI fc4xYD8QZA9YAXlOs1pBse+2FK1mu5c= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4C4CB2009B X-Stat-Signature: 9p5uzez9kez7pkokzbje9ewymam67e5e Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hsvCkORt; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspam-User: X-HE-Tag: 1655137397-957167 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000572, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 12, 2022 at 10:32:25PM +0100, Matthew Wilcox (Oracle) wrote: > vmalloc does not allocate a vm_struct for vm_map_ram() areas. That causes > us to deny usercopies from those areas. This affects XFS which uses > vm_map_ram() for its directories. > > Fix this by calling find_vmap_area() instead of find_vm_area(). Thanks for the fixes! > [...] > + /* XXX: We should also abort for free vmap_areas */ What's needed to detect this? -- Kees Cook