From: Muchun Song <songmuchun@bytedance.com>
To: mike.kravetz@oracle.com, david@redhat.com,
akpm@linux-foundation.org, corbet@lwn.net
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH 5/6] mm: hugetlb_vmemmap: replace early_param() with core_param()
Date: Mon, 13 Jun 2022 14:35:11 +0800 [thread overview]
Message-ID: <20220613063512.17540-6-songmuchun@bytedance.com> (raw)
In-Reply-To: <20220613063512.17540-1-songmuchun@bytedance.com>
After the following commit and previous commit applied.
78f39084b41d ("mm: hugetlb_vmemmap: add hugetlb_optimize_vmemmap sysctl")
There is no order requirement between the parameter of "hugetlb_free_vmemmap"
and "hugepages" since we have removed the check of whether HVO is enabled
from hugetlb_vmemmap_init(). Therefore we can safely replace early_param()
with core_param() to simplify the code.
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
---
mm/hugetlb_vmemmap.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
index abdf441215bb..9808d32cdb9e 100644
--- a/mm/hugetlb_vmemmap.c
+++ b/mm/hugetlb_vmemmap.c
@@ -415,14 +415,8 @@ static int vmemmap_remap_alloc(unsigned long start, unsigned long end,
DEFINE_STATIC_KEY_FALSE(hugetlb_optimize_vmemmap_key);
EXPORT_SYMBOL(hugetlb_optimize_vmemmap_key);
-static bool vmemmap_optimize_enabled =
- IS_ENABLED(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON);
-
-static int __init hugetlb_vmemmap_early_param(char *buf)
-{
- return kstrtobool(buf, &vmemmap_optimize_enabled);
-}
-early_param("hugetlb_free_vmemmap", hugetlb_vmemmap_early_param);
+static bool vmemmap_optimize_enabled = IS_ENABLED(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON);
+core_param(hugetlb_free_vmemmap, vmemmap_optimize_enabled, bool, 0);
/*
* Previously discarded vmemmap pages will be allocated and remapping
--
2.11.0
next prev parent reply other threads:[~2022-06-13 6:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 6:35 [PATCH 0/6] Simplify hugetlb vmemmap and improve its readability Muchun Song
2022-06-13 6:35 ` [PATCH 1/6] mm: hugetlb_vmemmap: delete hugetlb_optimize_vmemmap_enabled() Muchun Song
2022-06-13 8:04 ` Oscar Salvador
2022-06-13 18:15 ` Mike kravetz
2022-06-20 16:57 ` Catalin Marinas
2022-06-13 6:35 ` [PATCH 2/6] mm: hugetlb_vmemmap: optimize vmemmap_optimize_mode handling Muchun Song
2022-06-13 8:10 ` Oscar Salvador
2022-06-13 8:24 ` Muchun Song
2022-06-13 18:28 ` Mike kravetz
2022-06-13 6:35 ` [PATCH 3/6] mm: hugetlb_vmemmap: introduce the name HVO Muchun Song
2022-06-13 8:13 ` Oscar Salvador
2022-06-13 15:39 ` David Hildenbrand
2022-06-14 3:15 ` Muchun Song
2022-06-13 21:19 ` Mike Kravetz
2022-06-14 3:17 ` Muchun Song
2022-06-15 14:51 ` Joao Martins
2022-06-16 3:28 ` Muchun Song
2022-06-16 22:27 ` Mike Kravetz
2022-06-17 7:49 ` Muchun Song
2022-06-13 6:35 ` [PATCH 4/6] mm: hugetlb_vmemmap: move vmemmap code related to HugeTLB to hugetlb_vmemmap.c Muchun Song
2022-06-13 8:15 ` Oscar Salvador
2022-06-13 21:34 ` Mike Kravetz
2022-06-13 6:35 ` Muchun Song [this message]
2022-06-13 21:43 ` [PATCH 5/6] mm: hugetlb_vmemmap: replace early_param() with core_param() Mike Kravetz
2022-06-13 6:35 ` [PATCH 6/6] mm: hugetlb_vmemmap: improve hugetlb_vmemmap code readability Muchun Song
2022-06-13 8:33 ` Oscar Salvador
2022-06-13 9:01 ` Muchun Song
2022-06-14 0:22 ` Mike Kravetz
2022-06-14 4:17 ` Muchun Song
2022-06-14 16:57 ` Mike Kravetz
2022-06-15 12:33 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613063512.17540-6-songmuchun@bytedance.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox