From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3474FC43334 for ; Sun, 12 Jun 2022 11:58:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A5948D012B; Sun, 12 Jun 2022 07:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 955518D011D; Sun, 12 Jun 2022 07:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D0B8D012B; Sun, 12 Jun 2022 07:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6FD288D011D for ; Sun, 12 Jun 2022 07:58:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1824C34DF8 for ; Sun, 12 Jun 2022 11:58:15 +0000 (UTC) X-FDA: 79569435750.21.17E4A6A Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf04.hostedemail.com (Postfix) with ESMTP id 298BE4007E for ; Sun, 12 Jun 2022 11:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655035092; x=1686571092; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zc2fQ1DQs6hOo+7bC7Stci3yT/NodzkSleYAFJQhRFo=; b=bjjJ1PVq3jrs/jpHIpqCRomF9f+v70UvzxZ403CbDAH5RyzMztLWJw60 p0nyb+4Foq+owoaL1qNg5hDCAomig7w2MfjuJQXtZb2yg6AhtByxaIjjs z02SXZVBYo05vUAlddMEl7fthr7lsfq5f7iAYmbpGHwGohqYeLH/nABkh JZT5LfLSnyS5O9IHO4XOQ4u9JtYgegQA6UeW830XjU5BYeGqmCW8/dEv2 OxUKKvxfmP0p3hIA/Z3Q77co+H9U36XNZFl2n7hfgM7MXKmUlqI1tgeBZ SH4pdwlvUY1AdpOGAfATdrvIUemxh5lK+Z4CKSZSF1eAnaPvTceBrRku8 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10375"; a="266749156" X-IronPort-AV: E=Sophos;i="5.91,294,1647327600"; d="scan'208";a="266749156" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2022 04:58:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,294,1647327600"; d="scan'208";a="672764530" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jun 2022 04:58:06 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1o0MEI-000Jto-6e; Sun, 12 Jun 2022 11:58:06 +0000 Date: Sun, 12 Jun 2022 19:57:32 +0800 From: kernel test robot To: Huanpeng Xin , akpm@linux-foundation.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xinhuanpeng Subject: Re: [PATCH] mm: add a new emergency page migratetype. Message-ID: <202206121954.0XdxzVrV-lkp@intel.com> References: <20220606032709.11800-1-xinhuanpeng9@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606032709.11800-1-xinhuanpeng9@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655035094; a=rsa-sha256; cv=none; b=BSAKrbIevv1GltgZu1P2hNiqk+O1zJMlEHXWcz1M8mx0yRPW0Qs6citcKw1xNZv3BI+fCv euOZ7OZ4L8ilVD/JQ67mvldy4bTnGHFEhRzGWdgbPzowH+pLl3xCwbJJ3q5uIxeEXpZDe/ FGE9/zqZrdtXSeyyp7etERKxiGdmpc8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bjjJ1PVq; spf=none (imf04.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655035094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4OLO7gcKXHmBG5ZA1GFjzJ2MZiACMQRzANWumLQSKEg=; b=BIs0Og4DF9lQ74mF6qv6HlTGrui8BvNUBVNZ8WrSNsh0ABrBgH2mUlHDDqM8Kh3ryjtykU zW8XrVeNKQ/13CeFl6cMET6EDW77NVfz1RQmYMR84rY8MX4BSP4FRkZOTkpv4Act/z6Ntt X6YVFo/TTzl0LfsjuSnk8sSutAa8pRw= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 298BE4007E X-Stat-Signature: gays3jstfyataqip6oadqohwxnxiooge X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bjjJ1PVq; spf=none (imf04.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1655035091-23991 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huanpeng, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Huanpeng-Xin/mm-add-a-new-emergency-page-migratetype/20220606-113050 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: hexagon-randconfig-r026-20220612 (https://download.01.org/0day-ci/archive/20220612/202206121954.0XdxzVrV-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project ff4abe755279a3a47cc416ef80dbc900d9a98a19) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/c3dbdae8f54c1335f2cb92b379a6eab1253500c8 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Huanpeng-Xin/mm-add-a-new-emergency-page-migratetype/20220606-113050 git checkout c3dbdae8f54c1335f2cb92b379a6eab1253500c8 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): >> mm/page_alloc.c:2940:12: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] nid, zone->nr_reserved_emergency); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/printk.h:528:37: note: expanded from macro 'pr_warn' printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/printk.h:475:60: note: expanded from macro 'printk' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/printk.h:447:19: note: expanded from macro 'printk_index_wrap' _p_func(_fmt, ##__VA_ARGS__); \ ~~~~ ^~~~~~~~~~~ mm/page_alloc.c:2948:10: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] nid, zone->nr_reserved_emergency); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/printk.h:548:34: note: expanded from macro 'pr_info' printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/printk.h:475:60: note: expanded from macro 'printk' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ~~~ ^~~~~~~~~~~ include/linux/printk.h:447:19: note: expanded from macro 'printk_index_wrap' _p_func(_fmt, ##__VA_ARGS__); \ ~~~~ ^~~~~~~~~~~ >> mm/page_alloc.c:4215:10: error: no member named 'high_zoneidx' in 'struct alloc_context'; did you mean 'highest_zoneidx'? if (ac->high_zoneidx >= ZONE_NORMAL) { ^~~~~~~~~~~~ highest_zoneidx mm/internal.h:226:17: note: 'highest_zoneidx' declared here enum zone_type highest_zoneidx; ^ >> mm/page_alloc.c:4238:33: error: too few arguments to function call, expected 3, have 2 zone_statistics(z->zone, zone); ~~~~~~~~~~~~~~~ ^ mm/page_alloc.c:3697:20: note: 'zone_statistics' declared here static inline void zone_statistics(struct zone *preferred_zone, struct zone *z, ^ 2 warnings and 2 errors generated. vim +4215 mm/page_alloc.c 4204 4205 #ifdef CONFIG_EMERGENCY_MEMORY 4206 /* 4207 * get_emergency_page_from_freelist allocates pages in reserved memory 4208 * in the migration type MIGRATE_EMERGENCY. 4209 */ 4210 static struct page *get_emergency_page_from_freelist(gfp_t gfp_mask, unsigned int order, 4211 int alloc_flags, const struct alloc_context *ac, int migratetype) 4212 { 4213 struct page *page = NULL; 4214 > 4215 if (ac->high_zoneidx >= ZONE_NORMAL) { 4216 struct zoneref *z = ac->preferred_zoneref; 4217 struct pglist_data *pgdat = NODE_DATA(zonelist_node_idx(z)); 4218 struct zone *zone = &pgdat->node_zones[ZONE_NORMAL]; 4219 unsigned long flags; 4220 4221 if (cpusets_enabled() && 4222 (alloc_flags & ALLOC_CPUSET) && 4223 !__cpuset_zone_allowed(zone, gfp_mask)) 4224 return NULL; 4225 4226 spin_lock_irqsave(&zone->lock, flags); 4227 do { 4228 page = __rmqueue_smallest(zone, order, migratetype); 4229 } while (page && check_new_pages(page, order)); 4230 4231 spin_unlock(&zone->lock); 4232 4233 if (page) { 4234 __mod_zone_freepage_state(zone, -(1 << order), 4235 get_pcppage_migratetype(page)); 4236 4237 __count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order); > 4238 zone_statistics(z->zone, zone); 4239 prep_new_page(page, order, gfp_mask, alloc_flags); 4240 } 4241 local_irq_restore(flags); 4242 } 4243 4244 return page; 4245 -- 0-DAY CI Kernel Test Service https://01.org/lkp