From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF8CC433EF for ; Sat, 11 Jun 2022 13:35:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B9B38D0117; Sat, 11 Jun 2022 09:35:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16A218D0115; Sat, 11 Jun 2022 09:35:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 009E68D0117; Sat, 11 Jun 2022 09:35:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E31628D0115 for ; Sat, 11 Jun 2022 09:35:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BE04A2055D for ; Sat, 11 Jun 2022 13:35:08 +0000 (UTC) X-FDA: 79566051096.15.3D557A8 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 56FEB1A007B for ; Sat, 11 Jun 2022 13:35:08 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id d13so1436150plh.13 for ; Sat, 11 Jun 2022 06:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PbAl4kI4EWPjlfr5EPy02/EZq5DBezEwz9F8zcvz1MI=; b=dnfYy1ggDd7wo8E0EUz0ooEKa3e3RIH+cyYmrSJawMdt2/497OMEZjpHXu2EmIJTgb nJuCZZWuy9ecGkTWmAmamFLUUpVfx/rMK71INj3ws/FrC2wyib3+r3mk1abd6siXr4Ny 79GBsLHCjeKjjzLArt7zM1+w3GHmojGfWiVQdz3pL+TZZIjjVwece4GzFn1orUzG1za8 qaF2XaDOZr6oMomXKRoeKkJF5JK3rnkgg/8jylaoYg2JmxP4/w+PPfheNOibLgzNOrKw Q9hXMgF2gvN/sPVuJStrLvqsIJo3/LIAEgUuaySw3ik8ZmSyfBjy7pU7ZDePAM6zh/Xz N6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PbAl4kI4EWPjlfr5EPy02/EZq5DBezEwz9F8zcvz1MI=; b=t/HZybiwz8Upo4vvBGgwDrufP5igTQ7OeZdEAVoAyLLX85Y4kVCm4k11jl84nhjpqs eBhbOEq1yGEU/WsxuosD+cqogWDauZ1x689T3dGQ6KSmn+AJtdV7ojO1mWLK4jM/MtHK NteD4JfZWX4hiUAhuAcQ2yCc+SO0QHjxiGeY2vLYjWKp/XkT7h8jowz7bLOMrzLOqHox Hq7SkJnXx+6O+VJxBA/bfTKMTTa2VY99fJF0VU70TqYhRVKxaRM5DpXqayhJQqA2KSqf b7HCSM2hX+hTQIDmkI4Rq+7Ryxl024aklxzz48s1smivllJd5yh/XIpD69vZVqwRLmCY gIlw== X-Gm-Message-State: AOAM530CjscyjdIgxdM8ULINqUh9+90HLSf2+SBiZ3rEYBLGgc4Gfs7e 3muCUJpv8UFWVfvXSQiCQfX7+g== X-Google-Smtp-Source: ABdhPJxPfKKpT6yvYdnNGtyRN9bmpn9b67+pEOt5QIhh/nyJ4aCG49+7zcDi2vtatboK70bLeFEssA== X-Received: by 2002:a17:90a:974b:b0:1ea:2bd3:b6f5 with SMTP id i11-20020a17090a974b00b001ea2bd3b6f5mr5254156pjw.196.1654954507141; Sat, 11 Jun 2022 06:35:07 -0700 (PDT) Received: from localhost.localdomain ([199.101.192.70]) by smtp.gmail.com with ESMTPSA id y190-20020a6264c7000000b00517c84fd24asm1587267pfb.172.2022.06.11.06.35.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Jun 2022 06:35:06 -0700 (PDT) From: Zhangfei Gao To: Minchan Kim , John Hubbard , "Paul E . McKenney" , Andrew Morton , shameerali.kolothum.thodi@huawei.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhangfei Gao Subject: [PATCH] mm: fix is_pinnable_page return value Date: Sat, 11 Jun 2022 21:34:42 +0800 Message-Id: <20220611133442.15290-1-zhangfei.gao@linaro.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654954508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=PbAl4kI4EWPjlfr5EPy02/EZq5DBezEwz9F8zcvz1MI=; b=ZYtT0jo8rpmRFunpvDF6BWL5B+n9CVEdE0MdjXwubIcIJzQDw9CUDNr+hX9oBvpwdo7yeV EN8uVU4zcYnkXQNc0+Eau/Gak8+9jI8xQd3mKkw6qgmiXP3FVQpnQ7XpLapXgTiZvIqpWW Q7WBVL4Fd70f0K4pIbdXDt/mHnFyqvg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654954508; a=rsa-sha256; cv=none; b=ixwN5MZGKDdJfHBVuEjsjd99jxrO4lEQEkiew/MNAn/zah8K5+SVCpPO6AAfh8beQttXtv 69BLnbaaks0tCA7RGwxOrVCvTq7rEk+ciEpA2lwFJNBtNasgecg7H8CNdQixGfMzMfpzJN KVuIsigYgDV+1+yNfJL3XgNA3zztqwU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dnfYy1gg; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf19.hostedemail.com: domain of zhangfei.gao@linaro.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhangfei.gao@linaro.org X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dnfYy1gg; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf19.hostedemail.com: domain of zhangfei.gao@linaro.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhangfei.gao@linaro.org X-Rspamd-Server: rspam03 X-Stat-Signature: 7gwafuxjtt8poahesmn5zw9ygthksqpo X-Rspamd-Queue-Id: 56FEB1A007B X-HE-Tag: 1654954508-648060 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 1c563432588d ("mm: fix is_pinnable_page against a cma page") Changes from return !(is_zone_movable_page(page) || is_migrate_cma_page(page)) || is_zero_pfn(page_to_pfn(page)); to return !(is_zone_movable_page(page) || is_zero_pfn(page_to_pfn(page))); Unfortunately, this changes the return value since the ! area is error. It should be: return !(is_zone_movable_page(page)) || is_zero_pfn(page_to_pfn(page)); This causes qemu to be hung with a passthrough device. Fixes: 1c563432588d ("mm: fix is_pinnable_page against a cma page") Signed-off-by: Zhangfei Gao --- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index bc8f326be0ce..bbbcdde6c4dc 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1600,7 +1600,7 @@ static inline bool is_pinnable_page(struct page *page) if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) return false; #endif - return !(is_zone_movable_page(page) || is_zero_pfn(page_to_pfn(page))); + return !(is_zone_movable_page(page)) || is_zero_pfn(page_to_pfn(page)); } #else static inline bool is_pinnable_page(struct page *page) -- 2.36.1