From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F36C43334 for ; Fri, 10 Jun 2022 21:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D653E8D00DC; Fri, 10 Jun 2022 17:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CED196B008A; Fri, 10 Jun 2022 17:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B67748D00DC; Fri, 10 Jun 2022 17:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A15F16B0083 for ; Fri, 10 Jun 2022 17:03:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9823420560 for ; Fri, 10 Jun 2022 21:03:01 +0000 (UTC) X-FDA: 79563550962.05.455651E Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf11.hostedemail.com (Postfix) with ESMTP id 10FB74007D for ; Fri, 10 Jun 2022 21:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654894979; x=1686430979; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ITqyNN6aMfLgWrZqGcYWjoDoxlzkxWNBkOIz9CdtswQ=; b=QM8Fj7+WHXZxR4xPqN64bVZpaCUaqKB/95D/vR/xNN6MonIYtK+3ARvT 6vCuMmdo2L9gG2lQEqCEfe63cstMT3nvmaqssH0YSrmbliRtEchvjCKCT sxbhF02fSHp+4EdsglHSetqTOEvqUwcsgbn9VPAHo9B5CYA+vDPT/MTun Suv2G1LgsU0zS0PBHYzNWC+11jyzyHjpIoODfkbNV1IGTLp/bFEVfT4HH b33QPVQ0UXL4gAvmLwlZ0Yx3Pv10EBSNFZ/0Kp0ch64MC3VMR+iObtc6a V8umMyEAR0+VokihIOgsb+JoPgSYpqI5MgxPVTniKToge8YemizlKLZxT A==; X-IronPort-AV: E=McAfee;i="6400,9594,10374"; a="277784131" X-IronPort-AV: E=Sophos;i="5.91,291,1647327600"; d="scan'208";a="277784131" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 14:02:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,291,1647327600"; d="scan'208";a="725144484" Received: from lkp-server01.sh.intel.com (HELO 60dabacc1df6) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 10 Jun 2022 14:02:52 -0700 Received: from kbuild by 60dabacc1df6 with local (Exim 4.95) (envelope-from ) id 1nzlmN-000IHB-VP; Fri, 10 Jun 2022 21:02:51 +0000 Date: Sat, 11 Jun 2022 05:02:21 +0800 From: kernel test robot To: Pavel Tikhomirov , linux-kernel@vger.kernel.org Cc: kbuild-all@lists.01.org, Pavel Tikhomirov , Eric Biederman , Kees Cook , Alexander Viro , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrew Morton , Linux Memory Management List , linux-ia64@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] Add CABA tree to task_struct Message-ID: <202206110409.b8UJYnuq-lkp@intel.com> References: <20220610163214.49974-2-ptikhomirov@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220610163214.49974-2-ptikhomirov@virtuozzo.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654894981; a=rsa-sha256; cv=none; b=mTQFraENiurVobZkExT/IdSlLsHQjJbfGe3MRrJrMZS7DEAUg6EicjuQEi5NLH7V+FF0iF 0nvx8qEGY5HCWXDO9zljBTMxmTP8EQlheXJzNxq2pO7UiqzaeJClVeHTIwE9/Oqg4gRuhR 9yq+uVDeDeuJeKt2CgpvGyNN2YPKDfM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QM8Fj7+W; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf11.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654894981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EqeCpw1ql6szYog+auGG1nHkqnPcN7C4xRScO9Hfep4=; b=yQJKFsz26UkSipWVEj+pef5SNlf2JkvtomrSfufoCj37CNmrOgpFeLSBtP0NwVpFaj03cM HTgGhQ8G/gGSaPBuN8Nn8vrpMAsaiyz76glPKWVwSWAKEGAPYqc1d8yNhoRPXQPSl+O+N2 6s/D21O+p43oDU4lup/LWSZJJswSfCU= X-Stat-Signature: cojg5k6oj3sqgspgy5wzyfhmskw3nrf6 X-Rspam-User: X-Rspamd-Queue-Id: 10FB74007D X-Rspamd-Server: rspam07 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=QM8Fj7+W; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf11.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=lkp@intel.com X-HE-Tag: 1654894978-754480 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Pavel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on shuah-kselftest/next] [also build test WARNING on kees/for-next/execve tip/sched/core linus/master v5.19-rc1 next-20220610] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Pavel-Tikhomirov/Introduce-CABA-helper-process-tree/20220611-003433 base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220611/202206110409.b8UJYnuq-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/0875a2bed5ff95643c487dfcc28a550db06ea418 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Pavel-Tikhomirov/Introduce-CABA-helper-process-tree/20220611-003433 git checkout 0875a2bed5ff95643c487dfcc28a550db06ea418 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/proc/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/proc/array.c: In function 'task_state': >> fs/proc/array.c:157:15: warning: unused variable 'caba_pids' [-Wunused-variable] 157 | pid_t caba_pids[MAX_PID_NS_LEVEL] = {}; | ^~~~~~~~~ >> fs/proc/array.c:156:13: warning: unused variable 'caba_level' [-Wunused-variable] 156 | int caba_level = 0; | ^~~~~~~~~~ >> fs/proc/array.c:155:21: warning: unused variable 'caba_pid' [-Wunused-variable] 155 | struct pid *caba_pid; | ^~~~~~~~ >> fs/proc/array.c:154:29: warning: unused variable 'caba' [-Wunused-variable] 154 | struct task_struct *caba; | ^~~~ vim +/caba_pids +157 fs/proc/array.c 143 144 static inline void task_state(struct seq_file *m, struct pid_namespace *ns, 145 struct pid *pid, struct task_struct *p) 146 { 147 struct user_namespace *user_ns = seq_user_ns(m); 148 struct group_info *group_info; 149 int g, umask = -1; 150 struct task_struct *tracer; 151 const struct cred *cred; 152 pid_t ppid, tpid = 0, tgid, ngid; 153 unsigned int max_fds = 0; > 154 struct task_struct *caba; > 155 struct pid *caba_pid; > 156 int caba_level = 0; > 157 pid_t caba_pids[MAX_PID_NS_LEVEL] = {}; 158 159 rcu_read_lock(); 160 ppid = pid_alive(p) ? 161 task_tgid_nr_ns(rcu_dereference(p->real_parent), ns) : 0; 162 -- 0-DAY CI Kernel Test Service https://01.org/lkp