From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853C5CCA473 for ; Thu, 9 Jun 2022 22:20:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEBA98D0059; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E72F08D0057; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CED298D0059; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BBFAD8D0057 for ; Thu, 9 Jun 2022 18:20:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 931D135C55 for ; Thu, 9 Jun 2022 22:20:19 +0000 (UTC) X-FDA: 79560116958.23.144731D Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf16.hostedemail.com (Postfix) with ESMTP id 42FBD180057 for ; Thu, 9 Jun 2022 22:20:19 +0000 (UTC) Received: by mail-pg1-f202.google.com with SMTP id f9-20020a636a09000000b00401b6bc63beso542760pgc.23 for ; Thu, 09 Jun 2022 15:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=dB/VRnBqrla/uo3hQxagOMwn8rw3rKKNrg8KvvIMmrs=; b=NA8rGIzS2Lo/FSyJFJSopJzo3vj2qG+W/JBu2Td+wh8lNm3aGHNFbCPALJTDiKY3VZ BXYoT+Ww8rgiNjDcWDo8JWEIvIa789ch4uJ/akkx61GHrCbS4UYTLU+WBzXi0U6zqFg6 WETSd0zF9UD0yrUhECgMgO4+3B7vaNDE5q4OxsAILit4vZz26MEF5lP7eGpObNUfQYZP qWyriCnElNMS5dBnlp4ECfJw4cwUWsda0JPVGIsCkMRh996FjTM9tl6X5Bjcl49Ex3bX 056kN/4A+KMGFsvjat6Zhxnibo6NVJe0KQfbbqHffKzcdpAaOGAQ/5H1gcLRSIgsdnQd eZOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=dB/VRnBqrla/uo3hQxagOMwn8rw3rKKNrg8KvvIMmrs=; b=Z0322xQbZHmQem05WHdgrJ0pqZDd7f8wjmxmBe4bmU9wzd5SFxvBFWOZH3AthqlQiY uXhFjThHXd5kOPWC0JR4DjR82hWN35NNPcLJ1jKC2yeM9toRMUfuBJxQwwLxdDbRFjBC ajySds9d5GVOyP0o1Vz7dZiUrB+ZinRcEFwhmaqApima+dd5CyDxZgW4E8eQNFLWuF0S g6210Lbh0TQTnoTbxbE6KoKxVDSLlgi9C/WpjsJ16QXcNZ2cagohkFNddtf4gz8hxNFf evdu3l0TgjPsO0/uu/E1FvzoUw+tNLp7ddOwAcRpQy60W7aRnD+2H6pI7WUge9Zi1NyV XPuw== X-Gm-Message-State: AOAM5312dLTX7VR9xSa8eZYXL3zYcLB6xfU5TuUVE2GT/zbMLDUr//CI JZXV/d8GzIJ2NYV+DGcZR9e7KE4q X-Google-Smtp-Source: ABdhPJye2mFQrzIepKAqLUDnC7IYTgWuIi+7I2qa8DRzQUgLX+2gR0oj+bp3uxnl8nOmUO9s5APs/msqoQ== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a62:e919:0:b0:51e:7b6e:5a3b with SMTP id j25-20020a62e919000000b0051e7b6e5a3bmr1529888pfh.78.1654813218119; Thu, 09 Jun 2022 15:20:18 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:27 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-9-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 08/12] cdrom: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813219; a=rsa-sha256; cv=none; b=SMOqP+oZSuQvBUPA+WaGqctEt4WYJ/qu10rWA9SPVntQdG+nkbFUiGJNlHcGCQalLKtEYK gXlpNsQAyGX3uKyedoGhy3bIA1ymJ6+dnHr+EApniCh9ZE8AwCfQM97D1FNQlAt30dJOaO yvAQVqdHXDDkbH9EkupYJIJLC47PAZI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NA8rGIzS; spf=pass (imf16.hostedemail.com: domain of 3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dB/VRnBqrla/uo3hQxagOMwn8rw3rKKNrg8KvvIMmrs=; b=1YXcz1WTuvwkf3Crl4Zkpqao/a6q6PZ/5ldbZOVP+Iqwyi51ex/jl2J2BYBVl9CAd4cr/9 quIdkvBxJ2ldDSImCcYXbYOYJNIgeaprSkV2s3eLeyLuOPFKQEu7/F97sbl4796tOvlXNh rg5l9cuUqyYFeIZ7JqTEFqkDGb5Za1c= X-Rspamd-Queue-Id: 42FBD180057 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NA8rGIzS; spf=pass (imf16.hostedemail.com: domain of 3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3InKiYgUKCKsXZcMZRZZRWP.NZXWTYfi-XXVgLNV.ZcR@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: y1fukfg6mg9bk76r5538krfehwbu7oue X-HE-Tag: 1654813219-156941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: drivers/cdrom/cdrom.c:3454:48: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] ret = scnprintf(info + *pos, max_size - *pos, header); ^~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- drivers/cdrom/cdrom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 416f723a2dbb..52b40120c76e 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -3451,7 +3451,7 @@ static int cdrom_print_info(const char *header, int val, char *info, struct cdrom_device_info *cdi; int ret; - ret = scnprintf(info + *pos, max_size - *pos, header); + ret = scnprintf(info + *pos, max_size - *pos, "%s", header); if (!ret) return 1; -- 2.36.1.255.ge46751e96f-goog