From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C70A8C433EF for ; Thu, 9 Jun 2022 22:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C2568D0055; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54AEE8D0034; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DB08D0055; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 238E18D0034 for ; Thu, 9 Jun 2022 18:19:12 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id F3BC412101B for ; Thu, 9 Jun 2022 22:19:11 +0000 (UTC) X-FDA: 79560114144.08.772A96D Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf08.hostedemail.com (Postfix) with ESMTP id 9A1B3160067 for ; Thu, 9 Jun 2022 22:19:11 +0000 (UTC) Received: by mail-pf1-f201.google.com with SMTP id d2-20020aa78142000000b0051c394e5226so4833291pfn.19 for ; Thu, 09 Jun 2022 15:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=fWdTUxWRVXkKLWYheGOI11e0mL2XAHFKbZxg8ksMoZM=; b=ezNDouTkewW/awvW/cRvKC6jHhcMBl4eQkJi6sdP+X2J6iJMkd00jA2jaRJhpFY7aw yxivdcEq++4iV1GgB2ziv1ayV3oP8FWg/GB0Zo4bN9LSRrIbKMWW4pYYedFNqaZbtBdq LI7orAiKEXNDUMTMRTz+eYmtPr0ihFSVRZhCMEgns7LQjXXffU9ysRs8Jm7/xp/mkHV8 hqJ/WTn4IigfYhYdyyonY3s//N3eKAKkW8RZYgrVC9YsY682gIJn1c0bZa76vTplgKaA 3OGnJiqbOGhiGk4PrcLnGinCbRAB3xGsfKwPwyZscTB2mgetoP8/LmB/5HB6hMrHCgU0 s7qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=fWdTUxWRVXkKLWYheGOI11e0mL2XAHFKbZxg8ksMoZM=; b=6J5jvBdYMQxnHqhw4+AWjqcoXvemy5gO7hckZRz5gVTvA0ItQcYeEHlIR5fwKydDNa ffnIgJf5Mmh3cPn/W0lVmAMRz9ul9GHslyONkdeWayscWK/AqLBOMdZ7Fh859Fm/JaJI DuCJ22Rv30f66EodrisWR0qGgGo9L2KHz0Y92FKRHWzlesDIxF5pqNZZHy9GfhPRqeSX bVGIgBoVGgKrNN1iSmSqcVTai8T4/dfoaRIzFYaK7bl82T94VsA4oekRFXBeWhkfd1Rx 9Ug7tTAPxnzq0mUjD/qXLtDeNpYkU8dkCypk+7I+nu4o6afywuaFUAlhYmFjRcXaBa2M slag== X-Gm-Message-State: AOAM530rx/oZXweMGf0S4dN6U91AMw32CnOAn8V6fQcDdOlPJtOJqoZK pBa26SszDkoKcW9GTC9x1sj/QhFz X-Google-Smtp-Source: ABdhPJymRh8XdI6qUr+0U3jn9BPA1WS3MroiwqAq54XxkobNI9HSYvmGC6qhWN+ZtdS8zin/gyNAdfGHUw== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a63:c5:0:b0:3fe:26a0:7abe with SMTP id 188-20020a6300c5000000b003fe26a07abemr10973746pga.152.1654813150612; Thu, 09 Jun 2022 15:19:10 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:24 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-6-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 05/12] fs: quota: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fWdTUxWRVXkKLWYheGOI11e0mL2XAHFKbZxg8ksMoZM=; b=Dbypp6TZHbduxwIg8qxU+Ga92/3Al+zWSoW8DMWiBl9AfUlmpMRUC1w57vKUhGCUIsnqOv sKL8t70f7uV9DVt6bYV+49XhJ7aY6p4+5rb+1y0rMoG6VGn9FAGHQwHGsNlPMLrR9skdrI omp7cNSwOFBRAo4H3UfnpHEfWJrfQ+Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813151; a=rsa-sha256; cv=none; b=Vhs7iSBW5JC5Aq0zmubA3/dX6OX/GzYZu2OpAlMcsTEE2m55KGNZ6NvBN9agcRJXxxx5+I j6oKhgKrjd0RyGTUZWGUwkXuH6JZvTYdWGBzngqaMt1e0LowGoDt80Fa948i5cYDHRuig/ uzQ+xwuRXkbhnI8/py+IYtAFuUEMdu8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ezNDouTk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ezNDouTk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=33nGiYgUKCGcRTWGTLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--morbo.bounces.google.com X-Stat-Signature: ih8yms6pz96koos6wbufiu81h9srbmny X-Rspamd-Queue-Id: 9A1B3160067 X-HE-Tag: 1654813151-497896 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: fs/quota/dquot.c:206:22: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] request_module(module_names[qm].qm_mod_name)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- fs/quota/dquot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index a74aef99bd3d..3b613de3b371 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -203,7 +203,7 @@ static struct quota_format_type *find_quota_format(int id) module_names[qm].qm_fmt_id != id; qm++) ; if (!module_names[qm].qm_fmt_id || - request_module(module_names[qm].qm_mod_name)) + request_module("%s", module_names[qm].qm_mod_name)) return NULL; spin_lock(&dq_list_lock); -- 2.36.1.255.ge46751e96f-goog