From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F03AC43334 for ; Thu, 9 Jun 2022 22:17:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4F128D0051; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E24238D0034; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC49C8D0051; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BD0B48D0034 for ; Thu, 9 Jun 2022 18:17:40 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8DDFF1076 for ; Thu, 9 Jun 2022 22:17:40 +0000 (UTC) X-FDA: 79560110280.26.CCBD23F Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf19.hostedemail.com (Postfix) with ESMTP id 2D23E1A0051 for ; Thu, 9 Jun 2022 22:17:40 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-30c1d90587dso212884347b3.14 for ; Thu, 09 Jun 2022 15:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=3yOhmb5LLQ31qT6YeyEoaX0jjcoMdHElvVNlhTaaJU0=; b=RBpkYSjEyD64s1FKNQbtXE7AfdgJKfYmd5PMKe66FHnMYYo7vB0Ncyw1KRR50CoJoo aoycDWjxbUREKPl/jCi5J+ZmN745Yr3i1ib/+VcJJf8M0JMLiwl79xnz8rJSR7GD/eD1 lW/QxkZdjk6n9mbnb49kc1QuGbm9WiR5bRhdOxYxvavs/N1vvPSKHy30utzBB/gyWoTU CgiL6ug+u8f1QpKo/0EMJTNBBIk/eilNKeOEcwDZBOTEwWg6fyCqMv4cdogePUE+xetI whOzeQ9ub81nWd36wnDnSka41WjIxLP4QO+2B8XH0LL13vJc0ad+W0zJV+BD/RIy1FOR 5kSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=3yOhmb5LLQ31qT6YeyEoaX0jjcoMdHElvVNlhTaaJU0=; b=6b+SdNqwANA4HcFcBCH0iSan+cNBYnfgikgjt23MzvG7obVqcJstPxRg15uoWEwrlb VL1wodqSsos/DomQc1WVumqXJ0q/uW7r8fXyqZLFdYgrLPY0JWlQHnIrH8XqJ8NT9X5y QtVb+ecv8abKTM6W4U5bh9eIhHKi3finm2zk5d6grWsMIuprWC1jHic+FaqIIrqaGZUp CPPkcj0EbGxsbenw9NKyRsRYuLfJcAvQ/aRtd44CFe3TGfwtxKimTTaPUFxAczA2ROlS OtLjSOEMbI93J4Mptx/C5IvBPuzkJP+y6mXC5/vf3OY3TjWASfv1LY/uSPWrSF6uGmyH X1qA== X-Gm-Message-State: AOAM532AwKJUrlj5aEq7+TvJ4GahOpJV8RbR7biSQ8LJRg+NymXGo/6P /r9l2fh+gOc/BHy4Ze4EyhfPHDLv X-Google-Smtp-Source: ABdhPJzTMnxRPuV6ZGJzvW5l0mMjxHOaj61kW/6XxvKjUl64lqYEHjJSEX/Dfo2Nrwl6bkVAjyNEv78Ldw== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a25:fe0d:0:b0:64d:915f:e73e with SMTP id k13-20020a25fe0d000000b0064d915fe73emr42473933ybe.447.1654813059372; Thu, 09 Jun 2022 15:17:39 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:20 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-2-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 01/12] x86/mce: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813060; a=rsa-sha256; cv=none; b=N82tXIHokgeXjUDrcYi3FFlrPRemoguyIsx3wEuGj9vuJOYFQkQt7qF39px4p0eiX2juzX 9iK+DZol9yfdmhwE7urHYHH3mjVEsPKALKynvw76Q4Np1HAu+B5MpRddVBoww8isbuYInY FVE3Jr0KOH2yUPkvnckyB7RzfmiNCJ8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RBpkYSjE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3yOhmb5LLQ31qT6YeyEoaX0jjcoMdHElvVNlhTaaJU0=; b=FXJ04DIOAlIuXzigXFXwLSvpiD2KKehplOQnAL+3uapDmwoLSQgufrFL2zCnHXjTLKvNFn X6Uyhim33f++f/mCEoYeLhcMed+TmWmjQebPSEJG8CrJlQLJTe8KTVLDY95YY+Dws0M7+e wDcOnebFHTwY41ekZ8jVdudGlYl0YnE= X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2D23E1A0051 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=RBpkYSjE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of 3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3g3GiYgUKCAwy03n0s00sxq.o0yxuz69-yyw7mow.03s@flex--morbo.bounces.google.com X-Stat-Signature: smhxtirawe4i887wab64ft8mfsmtif3o X-HE-Tag: 1654813060-797552 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] panic(msg); ^~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- arch/x86/kernel/cpu/mce/core.c | 2 +- scripts/Makefile.extrawarn | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 2c8ec5c71712..3d411b7c85ad 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) if (!fake_panic) { if (panic_timeout == 0) panic_timeout = mca_cfg.panic_timeout; - panic(msg); + panic("%s", msg); } else pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); -- 2.36.1.255.ge46751e96f-goog