From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 492C2C433EF for ; Thu, 9 Jun 2022 22:21:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC83C8D005C; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C784E8D0034; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B193E8D005C; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9BB198D0034 for ; Thu, 9 Jun 2022 18:21:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6D6DB210E4 for ; Thu, 9 Jun 2022 22:21:50 +0000 (UTC) X-FDA: 79560120780.25.51C505A Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf23.hostedemail.com (Postfix) with ESMTP id 18F93140063 for ; Thu, 9 Jun 2022 22:21:49 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-2eb7d137101so213929827b3.12 for ; Thu, 09 Jun 2022 15:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=yboyFArx2lHvBt01l8NpldAEI3xLVVvkRY3YCO31PQs=; b=E9tSuZ6hKkd5R9UrAClvzMvLuSapw21MRvFh9K5m/Q4W/Ne6NP2WMWfSPzasz8wKZX Mng11d6Obxtbq83lWoSaFsdBiVCu3gb6X9dNoHMi3E7qOKWwZUm9cJAU6WOY5s+S4WcD k0KWGk2jmTkZOAqD94Ix96O/6kgOmQ/r+QpHomefwKvJ5cV0MNofmxceF2lXxoFWF6gg j5Cs7IkuMhKv2Pf+5++JwO5hcoMx6SP3if8FmA4NjIla9U/uK2//v1BfU0Tfe7AV8KrT Ey/sE8DleSJieRPHEDBL1hPn4naIWW02H/aWpnYArbukY4zZLmv4GV2t/e5g12dM+Qzj ZcQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=yboyFArx2lHvBt01l8NpldAEI3xLVVvkRY3YCO31PQs=; b=iavjKPtMtIHz/FPAsXIkMjiyMfip7JO9LSnsDasQClck50xddQsYDK1xFVRqWNqoPt zbnpvSFWQeT2b9PQnhDp1Gx/EO7qKUeLJ5mFA5FpOQ9encio7AHCA0BRtcOOK4IpliwT KstBOvQM3Jhsbcla3pHCYtXjFuBmcMf4J1lt1xRNzN8H4Wbb+OB2DoM012sfAYbkP83H nOMNgEXLxVzZEXVrYnP5SQwlgC9hD6JciUX/FbQn3uSt7f/fj/nYGCE6tOWduiiWdkgx HrSVcBWVmRiuSrVejmVmxm6MyVDDuHmSjFn4+p5xzKV3Enst5JzTV0GAtuxkh4oF32Mp RIPA== X-Gm-Message-State: AOAM533KLNJqzeDeqeWzt6Bz++37d2zDrtHFXt7oc05efPM8aM7vmgSl aMGVi9e92MpfpQ31Fsk2XSr099qX X-Google-Smtp-Source: ABdhPJzx/fiV7355Fpicwsezz0b2tB8XbCEkcbb8KPwyuPviI/0AOw7BwG+AXnNZJgmFqRPAiS2WX3p4fQ== X-Received: from fawn.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5795]) (user=morbo job=sendgmr) by 2002:a81:c248:0:b0:313:3c2c:89cd with SMTP id t8-20020a81c248000000b003133c2c89cdmr17003210ywg.175.1654813309307; Thu, 09 Jun 2022 15:21:49 -0700 (PDT) Date: Thu, 9 Jun 2022 22:16:31 +0000 In-Reply-To: <20220609221702.347522-1-morbo@google.com> Message-Id: <20220609221702.347522-13-morbo@google.com> Mime-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog Subject: [PATCH 12/12] netfilter: conntrack: use correct format characters From: Bill Wendling To: isanbard@gmail.com Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813310; a=rsa-sha256; cv=none; b=dMbTMFJBXXby8u6HtzhF42zCbiDCdIIx0KVrFW6co6p+m9/WzAN0ZS6QzTQozmcTEL2Ufi xQQYcKhhaU2W3JEGoUVWWOO8m5+rJFlgMJfBnkQy+ANONlPW30NntmlUq+ovD7uSTfSD0n cFs+IbVWlG6TUURopQ/Key5hiYZdBOk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E9tSuZ6h; spf=pass (imf23.hostedemail.com: domain of 3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yboyFArx2lHvBt01l8NpldAEI3xLVVvkRY3YCO31PQs=; b=wwNnRFRhqiqwL1W0pUKDggxIYT4WG2LS6vORVG58sIwlgXZGkJdRaOXog0m7gX348EYues VVrBZ8qhTByYeoqeV32vHgGQrD4qGDChC6h4bxxdBPZdTjG5gx/KkolPPuMQ6O5L4nIENh zEnwzbPm3QQyQI4NFOENtJOxgXdBfpw= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 18F93140063 X-Stat-Signature: 454t73cxqjq1c6jddcsie1o68ybp3p8s X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=E9tSuZ6h; spf=pass (imf23.hostedemail.com: domain of 3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3fXKiYgUKCAguwzjwowwotm.kwutqv25-uus3iks.wzo@flex--morbo.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1654813309-113253 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bill Wendling When compiling with -Wformat, clang emits the following warnings: net/netfilter/nf_conntrack_helper.c:168:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] request_module(mod_name); ^~~~~~~~ Use a string literal for the format string. Link: https://github.com/ClangBuiltLinux/linux/issues/378 Signed-off-by: Bill Wendling --- net/netfilter/nf_conntrack_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c index c12a87ebc3ee..1e0424d37abc 100644 --- a/net/netfilter/nf_conntrack_helper.c +++ b/net/netfilter/nf_conntrack_helper.c @@ -165,7 +165,7 @@ nf_nat_helper_try_module_get(const char *name, u16 l3num, u8 protonum) if (!nat) { snprintf(mod_name, sizeof(mod_name), "%s", h->nat_mod_name); rcu_read_unlock(); - request_module(mod_name); + request_module("%s", mod_name); rcu_read_lock(); nat = nf_conntrack_nat_helper_find(mod_name); -- 2.36.1.255.ge46751e96f-goog