From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07B4C433EF for ; Thu, 9 Jun 2022 22:25:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DA708D005D; Thu, 9 Jun 2022 18:25:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48A458D0034; Thu, 9 Jun 2022 18:25:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32B458D005D; Thu, 9 Jun 2022 18:25:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 23E6F8D0034 for ; Thu, 9 Jun 2022 18:25:32 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id EDD16120F62 for ; Thu, 9 Jun 2022 22:25:31 +0000 (UTC) X-FDA: 79560130062.08.1411C5F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 7C18F8006E for ; Thu, 9 Jun 2022 22:25:31 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A447061F3D; Thu, 9 Jun 2022 22:25:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9ABFC34114; Thu, 9 Jun 2022 22:25:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654813530; bh=8DPG20VCczCvHexMZwkQ1zY5Py8+AevTKqQ6qMOe6VU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v1isGaFZcOTd3hQSFwhJjKIptScdtzZdYTbChS0lD05tHMRSy7BT4ZgRXBgnC0WDM KgLV/3LJHT5eYoc434PB9zA81twQJVarz5OWwe6dzijmGQzObvdi2M2MX6KmWex0Ff UOZ65DWa7jodmuE8mcxI6Xnz3KDxzgQuDp9E63LI= Date: Thu, 9 Jun 2022 15:25:27 -0700 From: Andrew Morton To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 00/12] Clang -Wformat warning fixes Message-Id: <20220609152527.4ad7862d4126e276e6f76315@linux-foundation.org> In-Reply-To: <20220609221702.347522-1-morbo@google.com> References: <20220609221702.347522-1-morbo@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654813531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bBsPEcUFbFv81V3oV5anqbzGLT4QmzqsPNjaMxe+zKA=; b=53Q9RgDuLJPCRUyHQ7HnEQifla63Bq39WTjsthKn5weQv8iUVbGEUAEIkjl6fcy7Phx15q +VfNYt0uOg0lAXGioRgNqQmhl5kAlQ+wlxqgnRlTwAzn9ESTdhK/XU8vY9tCrpGZE4GC8w iPJlFWTJJptLHCwiROwMOsE72fKs4wc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654813531; a=rsa-sha256; cv=none; b=mOE+cL0Os1e57w4enHJBp/Jzd7wk/yWDW+Lw+5u/mmzZ15T2SLjDj/klxcciDHDfJjlD0z P7P3XUTxmETORxC+jH/HopGpb/aa85RdEC4iSF4gR61/4z7G2JBWyFXcr2vKVfkv0vvQcv Qgx4J/ZN7c+flLfFKOLx3/qZJoEjT64= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=v1isGaFZ; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=v1isGaFZ; dmarc=none; spf=pass (imf30.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: h7tr3w4wwwd6yhgirh8qou1wc68g9gt8 X-Rspamd-Queue-Id: 7C18F8006E X-HE-Tag: 1654813531-347847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 9 Jun 2022 22:16:19 +0000 Bill Wendling wrote: > This patch set fixes some clang warnings when -Wformat is enabled. > tldr: - printk(msg); + printk("%s", msg); the only reason to make this change is where `msg' could contain a `%'. Generally, it came from userspace. Otherwise these changes are a useless consumer of runtime resources. I think it would be better to quieten clang in some fashion.